From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()
Date: Mon, 30 Nov 2015 16:35:31 +0200 [thread overview]
Message-ID: <CAHp75VfY=NU4MG7q1w=oYdTiTr0dqtNTQU3UkEaL=tXPJADH5Q@mail.gmail.com> (raw)
In-Reply-To: <1448891145-10766-2-git-send-email-peter.ujfalusi@ti.com>
On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> Treat as true condition the case when the mask is NULL.
What do you think about setting some default (all "on") mask when mask
is not supplied?
I don't know for sure but there might be cases when you don't want
literally *any* channel to satisfy.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/dmaengine.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index daf54a39bcc7..52c3eee48e2e 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -184,6 +184,9 @@ __dma_device_satisfies_mask(struct dma_device *device,
> {
> dma_cap_mask_t has;
>
> + if (!want)
> + return true;
> +
> bitmap_and(has.bits, want->bits, device->cap_mask.bits,
> DMA_TX_TYPE_END);
> return bitmap_equal(want->bits, has.bits, DMA_TX_TYPE_END);
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
dmaengine <dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux OMAP Mailing List
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm Mailing List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()
Date: Mon, 30 Nov 2015 16:35:31 +0200 [thread overview]
Message-ID: <CAHp75VfY=NU4MG7q1w=oYdTiTr0dqtNTQU3UkEaL=tXPJADH5Q@mail.gmail.com> (raw)
In-Reply-To: <1448891145-10766-2-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> wrote:
> Treat as true condition the case when the mask is NULL.
What do you think about setting some default (all "on") mask when mask
is not supplied?
I don't know for sure but there might be cases when you don't want
literally *any* channel to satisfy.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
> ---
> drivers/dma/dmaengine.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index daf54a39bcc7..52c3eee48e2e 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -184,6 +184,9 @@ __dma_device_satisfies_mask(struct dma_device *device,
> {
> dma_cap_mask_t has;
>
> + if (!want)
> + return true;
> +
> bitmap_and(has.bits, want->bits, device->cap_mask.bits,
> DMA_TX_TYPE_END);
> return bitmap_equal(want->bits, has.bits, DMA_TX_TYPE_END);
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask()
Date: Mon, 30 Nov 2015 16:35:31 +0200 [thread overview]
Message-ID: <CAHp75VfY=NU4MG7q1w=oYdTiTr0dqtNTQU3UkEaL=tXPJADH5Q@mail.gmail.com> (raw)
In-Reply-To: <1448891145-10766-2-git-send-email-peter.ujfalusi@ti.com>
On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> Treat as true condition the case when the mask is NULL.
What do you think about setting some default (all "on") mask when mask
is not supplied?
I don't know for sure but there might be cases when you don't want
literally *any* channel to satisfy.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/dmaengine.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index daf54a39bcc7..52c3eee48e2e 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -184,6 +184,9 @@ __dma_device_satisfies_mask(struct dma_device *device,
> {
> dma_cap_mask_t has;
>
> + if (!want)
> + return true;
> +
> bitmap_and(has.bits, want->bits, device->cap_mask.bits,
> DMA_TX_TYPE_END);
> return bitmap_equal(want->bits, has.bits, DMA_TX_TYPE_END);
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2015-11-30 14:35 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 13:45 [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 01/15] dmaengine: core: Allow NULL mask pointer in __dma_device_satisfies_mask() Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 14:35 ` Andy Shevchenko [this message]
2015-11-30 14:35 ` Andy Shevchenko
2015-11-30 14:35 ` Andy Shevchenko
2015-12-01 9:47 ` Peter Ujfalusi
2015-12-01 9:47 ` Peter Ujfalusi
2015-12-01 12:58 ` Andy Shevchenko
2015-12-01 12:58 ` Andy Shevchenko
2015-12-01 17:06 ` Vinod Koul
2015-12-01 17:06 ` Vinod Koul
2015-11-30 13:45 ` [RFC v02 02/15] dmaengine: core: Move and merge the code paths using private_candidate Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 14:42 ` Andy Shevchenko
2015-11-30 14:42 ` Andy Shevchenko
2015-12-01 8:41 ` Peter Ujfalusi
2015-12-01 8:41 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 03/15] dmaengine: core: Introduce new, universal API to request a channel Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 14:09 ` Arnd Bergmann
2015-11-30 14:09 ` Arnd Bergmann
2015-11-30 14:09 ` Arnd Bergmann
2015-12-01 9:48 ` Peter Ujfalusi
2015-12-01 9:48 ` Peter Ujfalusi
2015-12-01 9:48 ` Peter Ujfalusi
2015-11-30 14:51 ` Andy Shevchenko
2015-11-30 14:51 ` Andy Shevchenko
2015-11-30 14:51 ` Andy Shevchenko
2015-12-01 9:56 ` Peter Ujfalusi
2015-12-01 9:56 ` Peter Ujfalusi
2015-12-01 10:07 ` Andy Shevchenko
2015-12-01 10:07 ` Andy Shevchenko
2015-11-30 15:51 ` Tony Lindgren
2015-11-30 15:51 ` Tony Lindgren
2015-11-30 15:51 ` Tony Lindgren
2015-12-01 8:13 ` Peter Ujfalusi
2015-12-01 8:13 ` Peter Ujfalusi
2015-12-01 8:13 ` Peter Ujfalusi
2015-12-01 17:00 ` Tony Lindgren
2015-12-01 17:00 ` Tony Lindgren
2015-12-02 10:00 ` Peter Ujfalusi
2015-12-02 10:00 ` Peter Ujfalusi
2015-12-02 10:00 ` Peter Ujfalusi
2015-12-02 10:00 ` Peter Ujfalusi
2015-12-02 15:00 ` Tony Lindgren
2015-12-02 15:00 ` Tony Lindgren
2015-12-02 15:00 ` Tony Lindgren
2015-11-30 13:45 ` [RFC v02 04/15] dmaengine: edma: Add support for DMA filter mapping to slave devices Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 14:11 ` Arnd Bergmann
2015-11-30 14:11 ` Arnd Bergmann
2015-12-01 9:58 ` Peter Ujfalusi
2015-12-01 9:58 ` Peter Ujfalusi
2015-12-01 9:58 ` Peter Ujfalusi
2015-12-01 10:14 ` Arnd Bergmann
2015-12-01 10:14 ` Arnd Bergmann
2015-12-01 17:22 ` Vinod Koul
2015-12-01 17:22 ` Vinod Koul
2015-12-01 20:20 ` Arnd Bergmann
2015-12-01 20:20 ` Arnd Bergmann
2015-12-01 20:20 ` Arnd Bergmann
2015-12-02 4:37 ` Vinod Koul
2015-12-02 4:37 ` Vinod Koul
2015-12-02 4:37 ` Vinod Koul
2015-12-02 10:02 ` Peter Ujfalusi
2015-12-02 10:02 ` Peter Ujfalusi
2015-12-02 10:02 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 05/15] ARM: davinci: devices-da8xx: Add dma_filter_map to edma Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 06/15] ARM: davinci: dm355: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 07/15] ARM: davinci: dm365: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 08/15] ARM: davinci: dm644x: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 09/15] ARM: davinci: dm646x: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 10/15] mmc: davinci_mmc: Use dma_request_chan() to requesting DMA channel Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 11/15] spi: davinci: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2016-05-02 11:04 ` Applied "spi: davinci: Use dma_request_chan() for requesting DMA channel" to the spi tree Mark Brown
2016-05-02 11:04 ` Mark Brown
2015-11-30 13:45 ` [RFC v02 12/15] ARM: davinci: devices-da8xx: Remove DMA resources for MMC and SPI Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 13/15] ARM: davinci: devices: Remove DMA resources for MMC Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 14/15] ARM: davinci: dm355: Remove DMA resources for SPI Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` [RFC v02 15/15] ARM: davinci: dm365: " Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 13:45 ` Peter Ujfalusi
2015-11-30 14:18 ` [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel Arnd Bergmann
2015-11-30 14:18 ` Arnd Bergmann
2015-12-01 10:12 ` Peter Ujfalusi
2015-12-01 10:12 ` Peter Ujfalusi
2015-12-01 10:12 ` Peter Ujfalusi
2015-12-01 10:12 ` Peter Ujfalusi
2015-12-01 10:15 ` Arnd Bergmann
2015-12-01 10:15 ` Arnd Bergmann
2015-12-01 10:15 ` Arnd Bergmann
2015-11-30 14:32 ` Andy Shevchenko
2015-11-30 14:32 ` Andy Shevchenko
2015-12-01 13:45 ` Peter Ujfalusi
2015-12-01 13:45 ` Peter Ujfalusi
2015-12-01 14:24 ` Arnd Bergmann
2015-12-01 14:24 ` Arnd Bergmann
2015-12-02 10:51 ` Peter Ujfalusi
2015-12-02 10:51 ` Peter Ujfalusi
2015-12-02 13:38 ` Arnd Bergmann
2015-12-02 13:38 ` Arnd Bergmann
2015-12-02 13:38 ` Arnd Bergmann
2015-12-01 16:59 ` Vinod Koul
2015-12-01 16:59 ` Vinod Koul
2015-12-01 16:59 ` Vinod Koul
2015-12-01 20:17 ` Arnd Bergmann
2015-12-01 20:17 ` Arnd Bergmann
2015-12-01 20:17 ` Arnd Bergmann
2015-12-02 4:52 ` Vinod Koul
2015-12-02 4:52 ` Vinod Koul
2015-12-02 8:23 ` Arnd Bergmann
2015-12-02 8:23 ` Arnd Bergmann
2015-12-02 12:29 ` Peter Ujfalusi
2015-12-02 12:29 ` Peter Ujfalusi
2015-12-02 12:29 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfY=NU4MG7q1w=oYdTiTr0dqtNTQU3UkEaL=tXPJADH5Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.