From: Adrian Chadd <adrian@freebsd.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: govinds@codeaurora.org, pillair@codeaurora.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Sebastian Gottschall <s.gottschall@dd-wrt.com>, Arend Van Spriel <arend.vanspriel@broadcom.com> Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save Date: Thu, 19 Apr 2018 10:00:22 -0700 [thread overview] Message-ID: <CAJ-Vmoky1JkQ5ZFc_zmvRdtRkVwVftLgqZehvfn6e8bH8TqKCg@mail.gmail.com> (raw) In-Reply-To: <8736zrjgq6.fsf@kamboji.qca.qualcomm.com> Hi, My 2c here. As much as I like power save stuff, I've been bitten enough times by these wifi chips kinda implementing mostly-ok-but-not-that-particular-time power savings stuff and so have had to make it configurable chip by chip. A good example is active state power management in various runtime and idle modes on different chips, how it intersects with things like bluetooth, btcoex, is the bios buggy, etc, etc. So I'd at least like a way to control that feature as a module load and/or debugfs entry to aide users trying to figure out why chips disappear or behave erratically. I'm ok with it being turned on but I'm not ok with a debugging step being "oh yeah, so just go comment this out and recompile", especially if people are debugging on an embedded target where it's not easily self hosted or easy to rebuild things. -adrian
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Chadd <adrian@freebsd.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>, govinds@codeaurora.org, linux-wireless@vger.kernel.org, Sebastian Gottschall <s.gottschall@dd-wrt.com>, pillair@codeaurora.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2 4/4] ath10k: Enable sta idle power save Date: Thu, 19 Apr 2018 10:00:22 -0700 [thread overview] Message-ID: <CAJ-Vmoky1JkQ5ZFc_zmvRdtRkVwVftLgqZehvfn6e8bH8TqKCg@mail.gmail.com> (raw) In-Reply-To: <8736zrjgq6.fsf@kamboji.qca.qualcomm.com> Hi, My 2c here. As much as I like power save stuff, I've been bitten enough times by these wifi chips kinda implementing mostly-ok-but-not-that-particular-time power savings stuff and so have had to make it configurable chip by chip. A good example is active state power management in various runtime and idle modes on different chips, how it intersects with things like bluetooth, btcoex, is the bios buggy, etc, etc. So I'd at least like a way to control that feature as a module load and/or debugfs entry to aide users trying to figure out why chips disappear or behave erratically. I'm ok with it being turned on but I'm not ok with a debugging step being "oh yeah, so just go comment this out and recompile", especially if people are debugging on an embedded target where it's not easily self hosted or easy to rebuild things. -adrian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-04-19 17:00 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 12:06 [PATCH v2 0/4] Support for STA idle mode power save(IMPS) pillair 2018-04-17 12:06 ` pillair 2018-04-17 12:06 ` [PATCH v2 1/4] ath10k: Add hw params for shadow register support pillair 2018-04-17 12:06 ` pillair 2018-04-24 6:05 ` [v2,1/4] " Kalle Valo 2018-04-24 6:05 ` Kalle Valo 2018-04-17 12:06 ` [PATCH v2 2/4] ath10k: Add support for shadow register for WNC3990 pillair 2018-04-17 12:06 ` pillair 2018-04-17 12:07 ` [PATCH v2 3/4] ath10k: Enable SRRI/DRRI support on ddr for WCN3990 pillair 2018-04-17 12:07 ` pillair 2018-04-17 12:07 ` [PATCH v2 4/4] ath10k: Enable sta idle power save pillair 2018-04-17 12:07 ` pillair 2018-04-18 7:06 ` Sebastian Gottschall 2018-04-18 7:06 ` Sebastian Gottschall 2018-04-18 13:07 ` govinds 2018-04-18 13:07 ` govinds 2018-04-18 13:16 ` Kalle Valo 2018-04-18 13:16 ` Kalle Valo 2018-04-18 14:44 ` Arend van Spriel 2018-04-18 14:44 ` Arend van Spriel 2018-04-19 4:32 ` govinds 2018-04-19 4:32 ` govinds 2018-04-19 16:36 ` Kalle Valo 2018-04-19 16:36 ` Kalle Valo 2018-04-19 17:00 ` Adrian Chadd [this message] 2018-04-19 17:00 ` Adrian Chadd 2018-04-20 7:21 ` Sebastian Gottschall 2018-04-20 7:21 ` Sebastian Gottschall 2018-04-20 8:16 ` Arend van Spriel 2018-04-20 8:16 ` Arend van Spriel 2018-04-20 12:43 ` govinds 2018-04-20 12:43 ` govinds 2018-04-23 15:50 ` Kalle Valo 2018-04-23 15:50 ` Kalle Valo 2018-04-23 16:17 ` 9984 with 10.4.3.5.3-0057 crashes Sebastian Gottschall 2018-04-24 5:27 ` Kalle Valo 2018-04-24 6:08 ` Sebastian Gottschall 2018-04-25 15:23 ` Kalle Valo 2018-04-26 6:23 ` Sebastian Gottschall 2018-04-26 7:36 ` Sebastian Gottschall 2018-04-23 16:41 ` [PATCH v2 4/4] ath10k: Enable sta idle power save Adrian Chadd 2018-04-23 16:41 ` Adrian Chadd 2018-04-24 5:35 ` Kalle Valo 2018-04-24 5:35 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJ-Vmoky1JkQ5ZFc_zmvRdtRkVwVftLgqZehvfn6e8bH8TqKCg@mail.gmail.com \ --to=adrian@freebsd.org \ --cc=arend.vanspriel@broadcom.com \ --cc=ath10k@lists.infradead.org \ --cc=govinds@codeaurora.org \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ --cc=pillair@codeaurora.org \ --cc=s.gottschall@dd-wrt.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.