From: Krzysztof Kozlowski <krzk@kernel.org> To: l.luba@partner.samsung.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, corbet@lwn.net, "Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>, kgene@kernel.org, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org> Subject: Re: [PATCH v2 06/11] arm64: dts: exynos5433: add support for thermal trip irq-mode Date: Mon, 12 Nov 2018 10:00:33 +0100 [thread overview] Message-ID: <CAJKOXPcGOiVwVuaT+2RHGs0VxA2XRjOd6efsDQaGrWWCJS7vNg@mail.gmail.com> (raw) In-Reply-To: <1541610593-28542-7-git-send-email-l.luba@partner.samsung.com> Thanks Lukasz for patches. I like your work! I have few more comments which will probably apply for all the DTS commits. On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@partner.samsung.com> wrote: > > This patch adds support for new flag which indicates This patch does not add support. Support for flag was added in your first drivers/thermal patches in this set. This patch adds new flag. (and does something more, so read on) > that trip point triggers IRQ when temperature is met. > Exynos5433 supports 8 trip point which will trigger IRQ. /8 trip point/8 trip points/ > Above that number other trip points should be registered > without 'irq-mode' flag. Please fix the line-wrap. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 105 ++++++++++++++++--------- > 1 file changed, 70 insertions(+), 35 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > index fe3a0b1..c4330f6 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > @@ -17,37 +17,44 @@ thermal-zones { > atlas0_alert_0: atlas0-alert-0 { > temperature = <65000>; /* millicelsius */ > hysteresis = <1000>; /* millicelsius */ > - type = "active"; > + type = "passive"; This change is not explained in commit msg. Basically you are doing here two things (related to each other). You clearly define which trip points are IRQ-type and you correct the type of trip point. Active is incorrect. This second thing is missing in your commit msg and I believe it is main reason behind this patch. You should focus then on this reason - start from it. Subject could be like "Use proper passive type for thermal trip points". Without this explanation I don't see the strong reason behind that patch. IOW, everything was working fine before... so why adding this new flag? Or maybe something was not fine... and then it is real reason why you are sending the patch. Usually commit message should answer to the most important question "WHY". Now, it explains "WHAT"... but I can see it from the source code. However from the code it is not easy to guess WHY. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 06/11] arm64: dts: exynos5433: add support for thermal trip irq-mode Date: Mon, 12 Nov 2018 10:00:33 +0100 [thread overview] Message-ID: <CAJKOXPcGOiVwVuaT+2RHGs0VxA2XRjOd6efsDQaGrWWCJS7vNg@mail.gmail.com> (raw) In-Reply-To: <1541610593-28542-7-git-send-email-l.luba@partner.samsung.com> Thanks Lukasz for patches. I like your work! I have few more comments which will probably apply for all the DTS commits. On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@partner.samsung.com> wrote: > > This patch adds support for new flag which indicates This patch does not add support. Support for flag was added in your first drivers/thermal patches in this set. This patch adds new flag. (and does something more, so read on) > that trip point triggers IRQ when temperature is met. > Exynos5433 supports 8 trip point which will trigger IRQ. /8 trip point/8 trip points/ > Above that number other trip points should be registered > without 'irq-mode' flag. Please fix the line-wrap. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: devicetree at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-samsung-soc at vger.kernel.org > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 105 ++++++++++++++++--------- > 1 file changed, 70 insertions(+), 35 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > index fe3a0b1..c4330f6 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi > @@ -17,37 +17,44 @@ thermal-zones { > atlas0_alert_0: atlas0-alert-0 { > temperature = <65000>; /* millicelsius */ > hysteresis = <1000>; /* millicelsius */ > - type = "active"; > + type = "passive"; This change is not explained in commit msg. Basically you are doing here two things (related to each other). You clearly define which trip points are IRQ-type and you correct the type of trip point. Active is incorrect. This second thing is missing in your commit msg and I believe it is main reason behind this patch. You should focus then on this reason - start from it. Subject could be like "Use proper passive type for thermal trip points". Without this explanation I don't see the strong reason behind that patch. IOW, everything was working fine before... so why adding this new flag? Or maybe something was not fine... and then it is real reason why you are sending the patch. Usually commit message should answer to the most important question "WHY". Now, it explains "WHAT"... but I can see it from the source code. However from the code it is not easy to guess WHY. Best regards, Krzysztof
next prev parent reply other threads:[~2018-11-12 9:00 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20181107171019eucas1p1fcb1f44e00265434548d901479f2ea94@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 00/11] thermal: add new flag irq-mode for trip point Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171022eucas1p1c2431f0561d9b1357ab569ab77deca34@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 01/11] thermal: remove unused function parameter Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171036eucas1p13253d56b463c8f888ab8f8e418635297@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 02/11] thermal: add irq-mode configuration for trip point Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba 2018-12-05 15:09 ` Zhang Rui 2018-12-05 15:09 ` Zhang Rui 2018-12-06 19:18 ` Lukasz Luba 2018-12-06 19:18 ` Lukasz Luba 2018-12-06 19:55 ` Lukasz Luba 2018-12-06 19:55 ` Lukasz Luba 2019-01-10 14:20 ` Zhang Rui 2019-01-10 14:20 ` Zhang Rui [not found] ` <CGME20181107171037eucas1p1b475d186830d4401b50fcd2c16781f92@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 03/11] thermal: add new sysfs file for irq-mode Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171038eucas1p1eb5dce12a1f5f7a3587f82f8396fa075@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 04/11] Doc: thermal: new irq-mode for trip point Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171039eucas1p2227bd4bc573fd0d2a3a97986004be16b@eucas1p2.samsung.com> 2018-11-07 17:09 ` [PATCH v2 05/11] Doc: DT: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba 2018-11-12 8:51 ` Krzysztof Kozlowski 2018-11-12 8:51 ` Krzysztof Kozlowski 2018-11-13 10:06 ` Lukasz Luba 2018-11-13 10:06 ` Lukasz Luba 2018-11-12 19:09 ` Rob Herring 2018-11-12 19:09 ` Rob Herring 2018-11-13 10:13 ` Lukasz Luba 2018-11-13 10:13 ` Lukasz Luba [not found] ` <CGME20181107171041eucas1p1a3cf91435b9071fd6e6f84101ebbcd9f@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 06/11] arm64: dts: exynos5433: add support for thermal trip irq-mode Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba 2018-11-12 9:00 ` Krzysztof Kozlowski [this message] 2018-11-12 9:00 ` Krzysztof Kozlowski 2018-11-13 10:10 ` Lukasz Luba 2018-11-13 10:10 ` Lukasz Luba [not found] ` <CGME20181107171042eucas1p1675eb589f3951e516461a0a775ee87da@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 07/11] arm64: dts: exynos7: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171043eucas1p16be3fa901c7bceb129c70fc81dba6e48@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 08/11] arm: dts: exynos4: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171044eucas1p198434e21cf21ee754302615a6a8f3c20@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 09/11] arm: dts: exynos5420: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171045eucas1p26ec5feb1b2a397971c919592f6d87b40@eucas1p2.samsung.com> 2018-11-07 17:09 ` [PATCH v2 10/11] arm: dts: exynos5422: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba [not found] ` <CGME20181107171046eucas1p1649bcf14a88ef9dd183724dde3a98f8c@eucas1p1.samsung.com> 2018-11-07 17:09 ` [PATCH v2 11/11] arm: dts: exynos5410: " Lukasz Luba 2018-11-07 17:09 ` Lukasz Luba 2018-12-05 15:08 ` [PATCH v2 00/11] thermal: add new flag irq-mode for trip point Zhang Rui 2018-12-05 15:08 ` Zhang Rui 2018-12-05 15:33 ` Lukasz Luba 2018-12-05 15:33 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJKOXPcGOiVwVuaT+2RHGs0VxA2XRjOd6efsDQaGrWWCJS7vNg@mail.gmail.com \ --to=krzk@kernel.org \ --cc=b.zolnierkie@samsung.com \ --cc=corbet@lwn.net \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=kgene@kernel.org \ --cc=l.luba@partner.samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.