From: "Krzysztof Kozłowski" <k.kozlowski.k@gmail.com>
To: weiyj_lk@163.com
Cc: Kukjin Kim <kgene@kernel.org>, Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
Date: Thu, 16 Apr 2015 21:24:03 +0900 [thread overview]
Message-ID: <CAJKOXPf5kiC4pvk0zAOYXu2z8LJAWTLHbcMMzdXzvL+rpiT8Lw@mail.gmail.com> (raw)
In-Reply-To: <1429186682-20629-1-git-send-email-weiyj_lk@163.com>
2015-04-16 21:18 GMT+09:00 <weiyj_lk@163.com>:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski.k@gmail.com (Krzysztof Kozłowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
Date: Thu, 16 Apr 2015 21:24:03 +0900 [thread overview]
Message-ID: <CAJKOXPf5kiC4pvk0zAOYXu2z8LJAWTLHbcMMzdXzvL+rpiT8Lw@mail.gmail.com> (raw)
In-Reply-To: <1429186682-20629-1-git-send-email-weiyj_lk@163.com>
2015-04-16 21:18 GMT+09:00 <weiyj_lk@163.com>:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-04-16 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 12:18 [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe() weiyj_lk
2015-04-16 12:18 ` weiyj_lk at 163.com
2015-04-16 12:24 ` Krzysztof Kozłowski [this message]
2015-04-16 12:24 ` Krzysztof Kozłowski
2015-04-16 12:35 ` Varka Bhadram
2015-04-16 12:35 ` Varka Bhadram
2015-04-17 13:23 ` Mark Brown
2015-04-17 13:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPf5kiC4pvk0zAOYXu2z8LJAWTLHbcMMzdXzvL+rpiT8Lw@mail.gmail.com \
--to=k.kozlowski.k@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.