From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Aurelien Jarno <aurelien@aurel32.net> Cc: devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Emil Renner Berthing <kernel@esmil.dk>, Ziv Xu <ziv.xu@starfivetech.com>, William Qiu <william.qiu@starfivetech.com> Subject: Re: [PATCH] riscv: dts: starfive: fix NOR flash reserved-data partition size Date: Sat, 26 Aug 2023 23:50:26 +0200 [thread overview] Message-ID: <CAJM55Z8zsfywScSeoSyKogAJZndKuPTF+_4GGd9+9ZcYraqLHQ@mail.gmail.com> (raw) In-Reply-To: <20230826182702.2641743-1-aurelien@aurel32.net> On Sat, 26 Aug 2023 at 20:28, Aurelien Jarno <aurelien@aurel32.net> wrote: > > The Starfive VisionFive 2 has a 16MiB NOR flash, while the reserved-data > partition is declared starting at address 0x600000 with a size of > 0x1000000. This causes the kernel to output the following warning: > > [ 22.156589] mtd: partition "reserved-data" extends beyond the end of device "13010000.spi.0" -- size truncated to 0xa00000 > > It seems to be a confusion between the size of the partition and the end > address. Fix that by specifying the right size. > > Fixes: 8384087a4223 ("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC") Thanks! Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > --- > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > index 498eb179d90f..30c85ba6da02 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > @@ -262,7 +262,7 @@ uboot@100000 { > reg = <0x100000 0x400000>; > }; > reserved-data@600000 { > - reg = <0x600000 0x1000000>; > + reg = <0x600000 0xa00000>; > }; > }; > }; > -- > 2.39.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Aurelien Jarno <aurelien@aurel32.net> Cc: devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Emil Renner Berthing <kernel@esmil.dk>, Ziv Xu <ziv.xu@starfivetech.com>, William Qiu <william.qiu@starfivetech.com> Subject: Re: [PATCH] riscv: dts: starfive: fix NOR flash reserved-data partition size Date: Sat, 26 Aug 2023 23:50:26 +0200 [thread overview] Message-ID: <CAJM55Z8zsfywScSeoSyKogAJZndKuPTF+_4GGd9+9ZcYraqLHQ@mail.gmail.com> (raw) In-Reply-To: <20230826182702.2641743-1-aurelien@aurel32.net> On Sat, 26 Aug 2023 at 20:28, Aurelien Jarno <aurelien@aurel32.net> wrote: > > The Starfive VisionFive 2 has a 16MiB NOR flash, while the reserved-data > partition is declared starting at address 0x600000 with a size of > 0x1000000. This causes the kernel to output the following warning: > > [ 22.156589] mtd: partition "reserved-data" extends beyond the end of device "13010000.spi.0" -- size truncated to 0xa00000 > > It seems to be a confusion between the size of the partition and the end > address. Fix that by specifying the right size. > > Fixes: 8384087a4223 ("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC") Thanks! Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > --- > arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > index 498eb179d90f..30c85ba6da02 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > @@ -262,7 +262,7 @@ uboot@100000 { > reg = <0x100000 0x400000>; > }; > reserved-data@600000 { > - reg = <0x600000 0x1000000>; > + reg = <0x600000 0xa00000>; > }; > }; > }; > -- > 2.39.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-08-26 21:51 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-26 18:27 [PATCH] riscv: dts: starfive: fix NOR flash reserved-data partition size Aurelien Jarno 2023-08-26 18:27 ` Aurelien Jarno 2023-08-26 21:50 ` Emil Renner Berthing [this message] 2023-08-26 21:50 ` Emil Renner Berthing 2023-08-28 15:54 ` Conor Dooley 2023-08-28 15:54 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJM55Z8zsfywScSeoSyKogAJZndKuPTF+_4GGd9+9ZcYraqLHQ@mail.gmail.com \ --to=emil.renner.berthing@canonical.com \ --cc=aurelien@aurel32.net \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@esmil.dk \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=william.qiu@starfivetech.com \ --cc=ziv.xu@starfivetech.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.