All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Hicks <mort@bork.org>
To: Kim Phillips <kim.phillips@freescale.com>,
	Scott Wood <scottwood@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>
Cc: Martin Hicks <mort@bork.org>,
	linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/5] crypto: talitos: Add crypto async queue handling
Date: Fri, 20 Feb 2015 13:23:28 -0500	[thread overview]
Message-ID: <CAJUS3XmnuUhgezxhBKeu2QLk-QqGVf3ZuwSycs_w=J3KC3BATg@mail.gmail.com> (raw)
In-Reply-To: <1424449276-5288-1-git-send-email-mort@bork.org>


[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]

I've just noticed that performance is pretty terrible with maxcpus=1, so
I'll investigate that.
mh

On Fri, Feb 20, 2015 at 11:21 AM, Martin Hicks <mort@bork.org> wrote:

> I was testing dm-crypt performance with a Freescale P1022 board with
> a recent kernel and was getting IO errors while doing testing with LUKS.
> Investigation showed that all hardware FIFO slots were filling and
> the driver was returning EAGAIN to the block layer, which is not an
> expected response for an async crypto implementation.
>
> The following patch series adds a few small fixes, and reworks the
> submission path to use the crypto_queue mechanism to handle the
> request backlog.
>
>
> Martin Hicks (5):
>   crypto: talitos: Simplify per-channel initialization
>   crypto: talitos: Remove MD5_BLOCK_SIZE
>   crypto: talitos: Fix off-by-one and use all hardware slots
>   crypto: talitos: Reorganize request submission data structures
>   crypto: talitos: Add software backlog queue handling
>
>  drivers/crypto/talitos.c |  189
> ++++++++++++++++++++++++----------------------
>  drivers/crypto/talitos.h |   44 +++++++++--
>  2 files changed, 137 insertions(+), 96 deletions(-)
>
> --
> 1.7.10.4
>
>


-- 
Martin Hicks P.Eng.      |         mort@bork.org
Bork Consulting Inc.     |   +1 (613) 266-2296

[-- Attachment #1.2: Type: text/html, Size: 2014 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

WARNING: multiple messages have this Message-ID (diff)
From: Martin Hicks <mort@bork.org>
To: Kim Phillips <kim.phillips@freescale.com>,
	Scott Wood <scottwood@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>
Cc: Martin Hicks <mort@bork.org>,
	linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/5] crypto: talitos: Add crypto async queue handling
Date: Fri, 20 Feb 2015 13:23:28 -0500	[thread overview]
Message-ID: <CAJUS3XmnuUhgezxhBKeu2QLk-QqGVf3ZuwSycs_w=J3KC3BATg@mail.gmail.com> (raw)
In-Reply-To: <1424449276-5288-1-git-send-email-mort@bork.org>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

I've just noticed that performance is pretty terrible with maxcpus=1, so
I'll investigate that.
mh

On Fri, Feb 20, 2015 at 11:21 AM, Martin Hicks <mort@bork.org> wrote:

> I was testing dm-crypt performance with a Freescale P1022 board with
> a recent kernel and was getting IO errors while doing testing with LUKS.
> Investigation showed that all hardware FIFO slots were filling and
> the driver was returning EAGAIN to the block layer, which is not an
> expected response for an async crypto implementation.
>
> The following patch series adds a few small fixes, and reworks the
> submission path to use the crypto_queue mechanism to handle the
> request backlog.
>
>
> Martin Hicks (5):
>   crypto: talitos: Simplify per-channel initialization
>   crypto: talitos: Remove MD5_BLOCK_SIZE
>   crypto: talitos: Fix off-by-one and use all hardware slots
>   crypto: talitos: Reorganize request submission data structures
>   crypto: talitos: Add software backlog queue handling
>
>  drivers/crypto/talitos.c |  189
> ++++++++++++++++++++++++----------------------
>  drivers/crypto/talitos.h |   44 +++++++++--
>  2 files changed, 137 insertions(+), 96 deletions(-)
>
> --
> 1.7.10.4
>
>


-- 
Martin Hicks P.Eng.      |         mort@bork.org
Bork Consulting Inc.     |   +1 (613) 266-2296

[-- Attachment #2: Type: text/html, Size: 2014 bytes --]

  parent reply	other threads:[~2015-02-20 18:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 16:21 [PATCH 0/5] crypto: talitos: Add crypto async queue handling Martin Hicks
2015-02-20 16:21 ` Martin Hicks
2015-02-20 16:21 ` [PATCH 1/5] crypto: talitos: Simplify per-channel initialization Martin Hicks
2015-02-20 16:21   ` Martin Hicks
2015-02-20 16:21 ` [PATCH 2/5] crypto: talitos: Remove MD5_BLOCK_SIZE Martin Hicks
2015-02-20 16:21   ` Martin Hicks
2015-02-27 11:03   ` Horia Geantă
2015-02-27 11:03     ` Horia Geantă
2015-03-01  9:32   ` Herbert Xu
2015-03-01  9:32     ` Herbert Xu
2015-02-20 16:21 ` [PATCH 3/5] crypto: talitos: Fix off-by-one and use all hardware slots Martin Hicks
2015-02-20 16:21   ` Martin Hicks
2015-02-20 16:21 ` [PATCH 4/5] crypto: talitos: Reorganize request submission data structures Martin Hicks
2015-02-20 16:21   ` Martin Hicks
2015-02-20 16:21 ` [PATCH 5/5] crypto: talitos: Add software backlog queue handling Martin Hicks
2015-02-20 16:21   ` Martin Hicks
2015-02-24 18:21   ` Horia Geantă
2015-02-24 18:21     ` Horia Geantă
2015-02-26 19:22     ` Martin Hicks
2015-02-26 19:22       ` Martin Hicks
2015-02-20 18:23 ` Martin Hicks [this message]
2015-02-20 18:23   ` [PATCH 0/5] crypto: talitos: Add crypto async " Martin Hicks
2015-02-20 18:26   ` Martin Hicks
2015-02-20 18:26     ` Martin Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJUS3XmnuUhgezxhBKeu2QLk-QqGVf3ZuwSycs_w=J3KC3BATg@mail.gmail.com' \
    --to=mort@bork.org \
    --cc=galak@kernel.crashing.org \
    --cc=kim.phillips@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.