From: "Rafael J. Wysocki" <rafael@kernel.org> To: Wang Qing <wangqing@vivo.com>, Dan Williams <dan.j.williams@intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead Date: Fri, 14 Aug 2020 17:28:52 +0200 [thread overview] Message-ID: <CAJZ5v0h=UmD33X_i80X3ww7nC=xQL7V8XaoNq2XvU_XcdQGfZQ@mail.gmail.com> (raw) In-Reply-To: <1597286952-5706-1-git-send-email-wangqing@vivo.com> On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote: > > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing <wangqing@vivo.com> LGTM Dan, any objections? > --- > drivers/acpi/nfit/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index fa4500f..3bb350b > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm *nvdimm = to_nvdimm(dev); > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > -- > 2.7.4 > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rafael@kernel.org> To: Wang Qing <wangqing@vivo.com>, Dan Williams <dan.j.williams@intel.com> Cc: Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead Date: Fri, 14 Aug 2020 17:28:52 +0200 [thread overview] Message-ID: <CAJZ5v0h=UmD33X_i80X3ww7nC=xQL7V8XaoNq2XvU_XcdQGfZQ@mail.gmail.com> (raw) In-Reply-To: <1597286952-5706-1-git-send-email-wangqing@vivo.com> On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote: > > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing <wangqing@vivo.com> LGTM Dan, any objections? > --- > drivers/acpi/nfit/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index fa4500f..3bb350b > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm *nvdimm = to_nvdimm(dev); > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > -- > 2.7.4 >
next prev parent reply other threads:[~2020-08-14 15:29 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-13 2:49 [PATCH] acpi/nfit: Use kobj_to_dev() instead Wang Qing 2020-08-13 2:49 ` Wang Qing 2020-08-14 15:28 ` Rafael J. Wysocki [this message] 2020-08-14 15:28 ` Rafael J. Wysocki 2020-08-14 22:52 ` Verma, Vishal L 2020-08-14 22:52 ` Verma, Vishal L 2020-09-15 17:39 ` Rafael J. Wysocki 2020-09-15 17:39 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJZ5v0h=UmD33X_i80X3ww7nC=xQL7V8XaoNq2XvU_XcdQGfZQ@mail.gmail.com' \ --to=rafael@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=rjw@rjwysocki.net \ --cc=wangqing@vivo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.