From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Robert Moore <robert.moore@intel.com>,
Erik Schmauss <erik.schmauss@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
<devel@acpica.org>
Subject: Re: [PATCH V2 05/10] ACPI: cpufreq: Switch to QoS requests instead of cpufreq notifier
Date: Tue, 6 Aug 2019 10:01:05 +0200 [thread overview]
Message-ID: <CAJZ5v0iqwc4mvqHoTHwoNS-T1zueS07S2e-1STEsKhFhoOh0dA@mail.gmail.com> (raw)
In-Reply-To: <20190806043904.dbpon4qf3mfsm4vz@vireshk-i7>
On Tue, Aug 6, 2019 at 6:39 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 05-08-19, 11:42, Rafael J. Wysocki wrote:
> > On Tuesday, July 23, 2019 8:14:05 AM CEST Viresh Kumar wrote:
> > > @@ -310,8 +339,11 @@ static int __init acpi_processor_driver_init(void)
> > > cpuhp_setup_state_nocalls(CPUHP_ACPI_CPUDRV_DEAD, "acpi/cpu-drv:dead",
> > > NULL, acpi_soft_cpu_dead);
> > >
> > > - acpi_thermal_cpufreq_init();
> > > - acpi_processor_ppc_init();
> > > + if (!cpufreq_register_notifier(&acpi_processor_notifier_block,
> > > + CPUFREQ_POLICY_NOTIFIER)) {
> > > + acpi_processor_cpufreq_init = true;
> >
> > Can't that be set/cleared by acpi_processor_notifier() itself?
>
> This is required to be done only once at initialization and setting it
> to true again and again on every invocation of the notifier callback
> doesn't look right.
>
> I have updated the patch based on rest of your suggestions, please see
> if it looks okay now.
Yes, it does, thanks!
[No need to resend, I'll take it from this message.]
WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael at kernel.org>
To: devel@acpica.org
Subject: Re: [Devel] [PATCH V2 05/10] ACPI: cpufreq: Switch to QoS requests instead of cpufreq notifier
Date: Tue, 06 Aug 2019 10:01:05 +0200 [thread overview]
Message-ID: <CAJZ5v0iqwc4mvqHoTHwoNS-T1zueS07S2e-1STEsKhFhoOh0dA@mail.gmail.com> (raw)
In-Reply-To: 20190806043904.dbpon4qf3mfsm4vz@vireshk-i7
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Tue, Aug 6, 2019 at 6:39 AM Viresh Kumar <viresh.kumar(a)linaro.org> wrote:
>
> On 05-08-19, 11:42, Rafael J. Wysocki wrote:
> > On Tuesday, July 23, 2019 8:14:05 AM CEST Viresh Kumar wrote:
> > > @@ -310,8 +339,11 @@ static int __init acpi_processor_driver_init(void)
> > > cpuhp_setup_state_nocalls(CPUHP_ACPI_CPUDRV_DEAD, "acpi/cpu-drv:dead",
> > > NULL, acpi_soft_cpu_dead);
> > >
> > > - acpi_thermal_cpufreq_init();
> > > - acpi_processor_ppc_init();
> > > + if (!cpufreq_register_notifier(&acpi_processor_notifier_block,
> > > + CPUFREQ_POLICY_NOTIFIER)) {
> > > + acpi_processor_cpufreq_init = true;
> >
> > Can't that be set/cleared by acpi_processor_notifier() itself?
>
> This is required to be done only once at initialization and setting it
> to true again and again on every invocation of the notifier callback
> doesn't look right.
>
> I have updated the patch based on rest of your suggestions, please see
> if it looks okay now.
Yes, it does, thanks!
[No need to resend, I'll take it from this message.]
next prev parent reply other threads:[~2019-08-06 8:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 6:14 [PATCH V2 00/10] cpufreq: Migrate users of policy notifiers to QoS requests Viresh Kumar
2019-07-23 6:26 ` Viresh Kumar
2019-07-23 6:14 ` Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 01/10] cpufreq: Add policy create/remove notifiers Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 02/10] thermal: cpu_cooling: Switch to QoS requests instead of cpufreq notifier Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 03/10] powerpc: macintosh: " Viresh Kumar
2019-07-23 6:14 ` Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 04/10] cpufreq: powerpc_cbe: " Viresh Kumar
2019-08-09 2:34 ` Viresh Kumar
2019-08-09 9:01 ` Rafael J. Wysocki
2019-08-19 2:26 ` Viresh Kumar
2019-08-19 6:42 ` Rafael J. Wysocki
2019-08-19 6:47 ` Viresh Kumar
2019-08-10 12:19 ` Rafael J. Wysocki
2019-07-23 6:14 ` [PATCH V2 05/10] ACPI: cpufreq: " Viresh Kumar
2019-08-05 9:42 ` Rafael J. Wysocki
2019-08-05 9:42 ` [Devel] " Rafael J. Wysocki
2019-08-06 4:39 ` Viresh Kumar
2019-08-06 8:01 ` Rafael J. Wysocki [this message]
2019-08-06 8:01 ` [Devel] " Rafael J. Wysocki
2019-08-06 8:47 ` Viresh Kumar
2019-08-09 2:33 ` Viresh Kumar
2019-08-10 12:13 ` Rafael J. Wysocki
2019-08-10 12:13 ` [Devel] " Rafael J. Wysocki
2019-08-28 8:50 ` [PATCH V3 " Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 06/10] arch_topology: Use CPUFREQ_CREATE_POLICY instead of CPUFREQ_NOTIFY Viresh Kumar
2019-07-25 13:36 ` Greg Kroah-Hartman
2019-07-23 6:14 ` [PATCH V2 07/10] video: sa1100fb: Remove cpufreq policy notifier Viresh Kumar
2019-07-23 6:26 ` Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 08/10] video: pxafb: " Viresh Kumar
2019-07-23 6:26 ` Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 09/10] cpufreq: Remove CPUFREQ_ADJUST and CPUFREQ_NOTIFY policy notifier events Viresh Kumar
2019-07-23 6:14 ` [PATCH V2 10/10] Documentation: cpufreq: Update policy notifier documentation Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iqwc4mvqHoTHwoNS-T1zueS07S2e-1STEsKhFhoOh0dA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.