From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
<devel@acpica.org>, Linux PM <linux-pm@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' after top level declarator
Date: Fri, 25 Feb 2022 16:10:17 +0100 [thread overview]
Message-ID: <CAJZ5v0jmFJMrKT5RsR+JEfJHaYFxHTi2xjS0UnkNUhSn7-r==A@mail.gmail.com> (raw)
In-Reply-To: <0d4d70ca-a17f-b8de-53f7-a85a59304d36@redhat.com>
On Fri, Feb 25, 2022 at 12:49 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Rafael,
>
> On 2/25/22 00:24, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> > head: 8276cbee5a52543c614a1e1bc2624188d5970848
> > commit: 62fabd56faafe033eb0be3ba24000b8db13d4c17 [59/73] x86/PCI: Disable exclusion of E820 reserved addresses in some cases
> > config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220225/202202250758.oDiHyXAy-lkp@intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=62fabd56faafe033eb0be3ba24000b8db13d4c17
> > git remote add rafael-pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> > git fetch --no-tags rafael-pm bleeding-edge
> > git checkout 62fabd56faafe033eb0be3ba24000b8db13d4c17
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from arch/x86/kernel/resource.c:4:
> > arch/x86/include/asm/pci_x86.h:97:8: error: unknown type name 'raw_spinlock_t'
> > extern raw_spinlock_t pci_config_lock;
> > ^
> >>> arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_pciprobe(void);
> > ^
> > ;
> > arch/x86/include/asm/pci_x86.h:134:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_skip_isa_align(void);
> > ^
> > ;
>
> So the problem here seems to be that arch/x86/include/asm/pci_x86.h does not include
> all the headers which it relies on. Instead it release on the files which include it
> to include those headers before hand.
>
> This should fix the errors reported here:
>
> --- a/arch/x86/include/asm/pci_x86.h
> +++ b/arch/x86/include/asm/pci_x86.h
> @@ -5,7 +5,9 @@
> * (c) 1999 Martin Mares <mj@ucw.cz>
> */
>
> +#include <linux/init.h>
> #include <linux/ioport.h>
> +#include <linux/spinlock.h>
>
> #undef DEBUG
>
> I believe this is best squashed into the original commit,
Done, thanks!
> but let me know if
> you want me to send this out as a proper follow up patch; or if you want a
> new version of the troublesome commit to replace the original one.
WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected '; ' after top level declarator
Date: Fri, 25 Feb 2022 16:10:17 +0100 [thread overview]
Message-ID: <CAJZ5v0jmFJMrKT5RsR+JEfJHaYFxHTi2xjS0UnkNUhSn7-r==A@mail.gmail.com> (raw)
In-Reply-To: <0d4d70ca-a17f-b8de-53f7-a85a59304d36@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3010 bytes --]
On Fri, Feb 25, 2022 at 12:49 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Rafael,
>
> On 2/25/22 00:24, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> > head: 8276cbee5a52543c614a1e1bc2624188d5970848
> > commit: 62fabd56faafe033eb0be3ba24000b8db13d4c17 [59/73] x86/PCI: Disable exclusion of E820 reserved addresses in some cases
> > config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220225/202202250758.oDiHyXAy-lkp(a)intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=62fabd56faafe033eb0be3ba24000b8db13d4c17
> > git remote add rafael-pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> > git fetch --no-tags rafael-pm bleeding-edge
> > git checkout 62fabd56faafe033eb0be3ba24000b8db13d4c17
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from arch/x86/kernel/resource.c:4:
> > arch/x86/include/asm/pci_x86.h:97:8: error: unknown type name 'raw_spinlock_t'
> > extern raw_spinlock_t pci_config_lock;
> > ^
> >>> arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_pciprobe(void);
> > ^
> > ;
> > arch/x86/include/asm/pci_x86.h:134:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_skip_isa_align(void);
> > ^
> > ;
>
> So the problem here seems to be that arch/x86/include/asm/pci_x86.h does not include
> all the headers which it relies on. Instead it release on the files which include it
> to include those headers before hand.
>
> This should fix the errors reported here:
>
> --- a/arch/x86/include/asm/pci_x86.h
> +++ b/arch/x86/include/asm/pci_x86.h
> @@ -5,7 +5,9 @@
> * (c) 1999 Martin Mares <mj@ucw.cz>
> */
>
> +#include <linux/init.h>
> #include <linux/ioport.h>
> +#include <linux/spinlock.h>
>
> #undef DEBUG
>
> I believe this is best squashed into the original commit,
Done, thanks!
> but let me know if
> you want me to send this out as a proper follow up patch; or if you want a
> new version of the troublesome commit to replace the original one.
WARNING: multiple messages have this Message-ID (diff)
From: Rafael J. Wysocki <rafael at kernel.org>
To: devel@acpica.org
Subject: [Devel] Re: [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected '; ' after top level declarator
Date: Fri, 25 Feb 2022 16:10:17 +0100 [thread overview]
Message-ID: <CAJZ5v0jmFJMrKT5RsR+JEfJHaYFxHTi2xjS0UnkNUhSn7-r==A@mail.gmail.com> (raw)
In-Reply-To: 0d4d70ca-a17f-b8de-53f7-a85a59304d36@redhat.com
[-- Attachment #1: Type: text/plain, Size: 3016 bytes --]
On Fri, Feb 25, 2022 at 12:49 PM Hans de Goede <hdegoede(a)redhat.com> wrote:
>
> Hi Rafael,
>
> On 2/25/22 00:24, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> > head: 8276cbee5a52543c614a1e1bc2624188d5970848
> > commit: 62fabd56faafe033eb0be3ba24000b8db13d4c17 [59/73] x86/PCI: Disable exclusion of E820 reserved addresses in some cases
> > config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220225/202202250758.oDiHyXAy-lkp(a)intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=62fabd56faafe033eb0be3ba24000b8db13d4c17
> > git remote add rafael-pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> > git fetch --no-tags rafael-pm bleeding-edge
> > git checkout 62fabd56faafe033eb0be3ba24000b8db13d4c17
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp(a)intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from arch/x86/kernel/resource.c:4:
> > arch/x86/include/asm/pci_x86.h:97:8: error: unknown type name 'raw_spinlock_t'
> > extern raw_spinlock_t pci_config_lock;
> > ^
> >>> arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_pciprobe(void);
> > ^
> > ;
> > arch/x86/include/asm/pci_x86.h:134:19: error: expected ';' after top level declarator
> > extern void __init dmi_check_skip_isa_align(void);
> > ^
> > ;
>
> So the problem here seems to be that arch/x86/include/asm/pci_x86.h does not include
> all the headers which it relies on. Instead it release on the files which include it
> to include those headers before hand.
>
> This should fix the errors reported here:
>
> --- a/arch/x86/include/asm/pci_x86.h
> +++ b/arch/x86/include/asm/pci_x86.h
> @@ -5,7 +5,9 @@
> * (c) 1999 Martin Mares <mj(a)ucw.cz>
> */
>
> +#include <linux/init.h>
> #include <linux/ioport.h>
> +#include <linux/spinlock.h>
>
> #undef DEBUG
>
> I believe this is best squashed into the original commit,
Done, thanks!
> but let me know if
> you want me to send this out as a proper follow up patch; or if you want a
> new version of the troublesome commit to replace the original one.
next prev parent reply other threads:[~2022-02-25 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 23:24 [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' after top level declarator kernel test robot
2022-02-24 23:24 ` [Devel] [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected '; ' " kernel test robot
2022-02-25 11:49 ` [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected ';' " Hans de Goede
2022-02-25 11:49 ` [rafael-pm:bleeding-edge 59/73] arch/x86/include/asm/pci_x86.h:133:19: error: expected '; ' " Hans de Goede
2022-02-25 15:10 ` Rafael J. Wysocki [this message]
2022-02-25 15:10 ` [Devel] " Rafael J. Wysocki
2022-02-25 15:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jmFJMrKT5RsR+JEfJHaYFxHTi2xjS0UnkNUhSn7-r==A@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=devel@acpica.org \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.