From: Miklos Szeredi <miklos@szeredi.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Linux fsdevel mailing list <linux-fsdevel@vger.kernel.org>,
virtio-fs-list <virtio-fs@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] virtiofs: Fail dax mount if device does not support it
Date: Fri, 5 Mar 2021 15:48:02 +0100 [thread overview]
Message-ID: <CAJfpegs9uCd8666YKjuhSd_0=_tqLNEmrtQEtX44=+AdcEHVdA@mail.gmail.com> (raw)
In-Reply-To: <20210305133401.GA109162@redhat.com>
On Fri, Mar 5, 2021 at 2:34 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> On Tue, Feb 09, 2021 at 05:47:54PM -0500, Vivek Goyal wrote:
> > Right now "mount -t virtiofs -o dax myfs /mnt/virtiofs" succeeds even
> > if filesystem deivce does not have a cache window and hence DAX can't
> > be supported.
> >
> > This gives a false sense to user that they are using DAX with virtiofs
> > but fact of the matter is that they are not.
> >
> > Fix this by returning error if dax can't be supported and user has asked
> > for it.
>
> Hi Miklos,
>
> Did you get a chance to look at this patch.
Thanks for the reminder. Pushed out now.
Miklos
WARNING: multiple messages have this Message-ID (diff)
From: Miklos Szeredi <miklos@szeredi.hu>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Linux fsdevel mailing list <linux-fsdevel@vger.kernel.org>,
virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] [PATCH] virtiofs: Fail dax mount if device does not support it
Date: Fri, 5 Mar 2021 15:48:02 +0100 [thread overview]
Message-ID: <CAJfpegs9uCd8666YKjuhSd_0=_tqLNEmrtQEtX44=+AdcEHVdA@mail.gmail.com> (raw)
In-Reply-To: <20210305133401.GA109162@redhat.com>
On Fri, Mar 5, 2021 at 2:34 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> On Tue, Feb 09, 2021 at 05:47:54PM -0500, Vivek Goyal wrote:
> > Right now "mount -t virtiofs -o dax myfs /mnt/virtiofs" succeeds even
> > if filesystem deivce does not have a cache window and hence DAX can't
> > be supported.
> >
> > This gives a false sense to user that they are using DAX with virtiofs
> > but fact of the matter is that they are not.
> >
> > Fix this by returning error if dax can't be supported and user has asked
> > for it.
>
> Hi Miklos,
>
> Did you get a chance to look at this patch.
Thanks for the reminder. Pushed out now.
Miklos
next prev parent reply other threads:[~2021-03-05 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 22:47 [PATCH] virtiofs: Fail dax mount if device does not support it Vivek Goyal
2021-02-09 22:47 ` [Virtio-fs] " Vivek Goyal
2021-02-10 14:58 ` Stefan Hajnoczi
2021-02-10 14:58 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-05 13:34 ` Vivek Goyal
2021-03-05 13:34 ` [Virtio-fs] " Vivek Goyal
2021-03-05 14:48 ` Miklos Szeredi [this message]
2021-03-05 14:48 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegs9uCd8666YKjuhSd_0=_tqLNEmrtQEtX44=+AdcEHVdA@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=dgilbert@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.