From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Marcus Cooper <codekipper@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio
Date: Tue, 28 Apr 2020 10:54:00 +0200 [thread overview]
Message-ID: <CAJiuCcc2LQ4L36KSfO8iLVFBUO6k+zsZFX+_Ovm_10PoWO4AsA@mail.gmail.com> (raw)
In-Reply-To: <20200428080020.35qcuylwq2ylmubu@gilmour.lan>
Hi Maxime,
On Tue, 28 Apr 2020 at 10:00, Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Sun, Apr 26, 2020 at 02:04:39PM +0200, Clément Péron wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Add a simple-soundcard to link audio between HDMI and I2S.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index e56e1e3d4b73..08ab6b5e72a5 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -102,6 +102,25 @@
> > status = "disabled";
> > };
> >
> > + hdmi_sound: hdmi-sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,name = "allwinner,hdmi";
>
> I'm not sure what the usual card name should be like though. I would assume that
> this should be something specific enough so that you're able to differentiate
> between boards / SoC so that the userspace can choose a different configuration
> based on it?
I really don't know what we should use here,
I just have a look at other SoC:
rk3328: "HDMI"
rk3399: "hdmi-sound"
r8a774c0-cat874: "CAT874 HDMI sound"
But maybe it's time to introduce proper name:
What about :
sun50i-a64-hdmi
sun50i-h6-hdmi
How should we handle this with h3 / h5 ?
settings the simple-audio-card,name in each SoC dts?
Or using sun50i-h3-hdmi as they are both identical?
Regards,
Clement
>
> If so, it's really too generic.
>
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree <devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio
Date: Tue, 28 Apr 2020 10:54:00 +0200 [thread overview]
Message-ID: <CAJiuCcc2LQ4L36KSfO8iLVFBUO6k+zsZFX+_Ovm_10PoWO4AsA@mail.gmail.com> (raw)
In-Reply-To: <20200428080020.35qcuylwq2ylmubu@gilmour.lan>
Hi Maxime,
On Tue, 28 Apr 2020 at 10:00, Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Sun, Apr 26, 2020 at 02:04:39PM +0200, Clément Péron wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Add a simple-soundcard to link audio between HDMI and I2S.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index e56e1e3d4b73..08ab6b5e72a5 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -102,6 +102,25 @@
> > status = "disabled";
> > };
> >
> > + hdmi_sound: hdmi-sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,name = "allwinner,hdmi";
>
> I'm not sure what the usual card name should be like though. I would assume that
> this should be something specific enough so that you're able to differentiate
> between boards / SoC so that the userspace can choose a different configuration
> based on it?
I really don't know what we should use here,
I just have a look at other SoC:
rk3328: "HDMI"
rk3399: "hdmi-sound"
r8a774c0-cat874: "CAT874 HDMI sound"
But maybe it's time to introduce proper name:
What about :
sun50i-a64-hdmi
sun50i-h6-hdmi
How should we handle this with h3 / h5 ?
settings the simple-audio-card,name in each SoC dts?
Or using sun50i-h3-hdmi as they are both identical?
Regards,
Clement
>
> If so, it's really too generic.
>
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree <devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio
Date: Tue, 28 Apr 2020 10:54:00 +0200 [thread overview]
Message-ID: <CAJiuCcc2LQ4L36KSfO8iLVFBUO6k+zsZFX+_Ovm_10PoWO4AsA@mail.gmail.com> (raw)
In-Reply-To: <20200428080020.35qcuylwq2ylmubu@gilmour.lan>
Hi Maxime,
On Tue, 28 Apr 2020 at 10:00, Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Sun, Apr 26, 2020 at 02:04:39PM +0200, Clément Péron wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Add a simple-soundcard to link audio between HDMI and I2S.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index e56e1e3d4b73..08ab6b5e72a5 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -102,6 +102,25 @@
> > status = "disabled";
> > };
> >
> > + hdmi_sound: hdmi-sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,name = "allwinner,hdmi";
>
> I'm not sure what the usual card name should be like though. I would assume that
> this should be something specific enough so that you're able to differentiate
> between boards / SoC so that the userspace can choose a different configuration
> based on it?
I really don't know what we should use here,
I just have a look at other SoC:
rk3328: "HDMI"
rk3399: "hdmi-sound"
r8a774c0-cat874: "CAT874 HDMI sound"
But maybe it's time to introduce proper name:
What about :
sun50i-a64-hdmi
sun50i-h6-hdmi
How should we handle this with h3 / h5 ?
settings the simple-audio-card,name in each SoC dts?
Or using sun50i-h3-hdmi as they are both identical?
Regards,
Clement
>
> If so, it's really too generic.
>
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 8:54 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 12:04 [RFT PATCH 0/7] Add Allwinner H3/H5/A64 HDMI audio Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` [PATCH 1/7] arm: dts: sunxi: h3/h5: Add DAI node for HDMI Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` [PATCH 2/7] arm: dts: sunxi: h3/h5: Add HDMI audio Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-28 7:58 ` Maxime Ripard
2020-04-28 7:58 ` Maxime Ripard
2020-04-28 7:58 ` Maxime Ripard
2020-04-26 12:04 ` [PATCH 3/7] arm64: dts: allwinner: a64: Add DAI node for HDMI Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-28 8:00 ` Maxime Ripard
2020-04-28 8:00 ` Maxime Ripard
2020-04-28 8:00 ` Maxime Ripard
2020-04-28 8:54 ` Clément Péron [this message]
2020-04-28 8:54 ` Clément Péron
2020-04-28 8:54 ` Clément Péron
2020-04-28 16:04 ` Maxime Ripard
2020-04-28 16:04 ` Maxime Ripard
2020-04-28 16:04 ` Maxime Ripard
2020-04-28 16:49 ` Audio sound card name [was [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio] Clément Péron
2020-04-28 16:49 ` Clément Péron
2020-04-28 16:49 ` Clément Péron
2020-04-28 16:57 ` Mark Brown
2020-04-28 16:57 ` Mark Brown
2020-04-28 16:57 ` Mark Brown
2020-04-28 17:11 ` Robin Murphy
2020-04-28 17:11 ` Robin Murphy
2020-04-28 17:11 ` Robin Murphy
2020-04-29 6:24 ` [linux-sunxi] " Chen-Yu Tsai
2020-04-29 6:24 ` Chen-Yu Tsai
2020-04-29 6:24 ` Chen-Yu Tsai
2020-04-29 8:17 ` Maxime Ripard
2020-04-29 8:17 ` Maxime Ripard
2020-04-29 8:17 ` Maxime Ripard
2020-04-29 10:42 ` Clément Péron
2020-04-29 10:42 ` Clément Péron
2020-04-29 10:42 ` Clément Péron
2020-04-29 10:43 ` Robin Murphy
2020-04-29 10:43 ` Robin Murphy
2020-04-29 10:43 ` Robin Murphy
2020-04-29 10:53 ` Jernej Škrabec
2020-04-29 10:53 ` Jernej Škrabec
2020-04-29 10:53 ` Jernej Škrabec
2020-04-29 11:07 ` Robin Murphy
2020-04-29 11:07 ` Robin Murphy
2020-04-29 11:07 ` Robin Murphy
2020-04-29 11:46 ` Maxime Ripard
2020-04-29 11:46 ` Maxime Ripard
2020-04-29 11:46 ` Maxime Ripard
2020-04-29 11:55 ` Maxime Ripard
2020-04-29 11:55 ` Maxime Ripard
2020-04-29 11:55 ` Maxime Ripard
2020-04-29 11:59 ` Takashi Iwai
2020-04-29 11:59 ` Takashi Iwai
2020-04-29 11:59 ` Takashi Iwai
2020-04-29 12:05 ` Mark Brown
2020-04-29 12:05 ` Mark Brown
2020-04-29 12:05 ` Mark Brown
2020-04-26 12:04 ` [PATCH 5/7] arm: sun8i: h3: Add HDMI audio to Orange Pi 2 Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` [PATCH 6/7] arm: sun8i: h3: Add HDMI audio to Beelink X2 Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` [PATCH 7/7] arm64: dts: allwinner: a64: Add HDMI audio to Pine64 Clément Péron
2020-04-26 12:04 ` Clément Péron
2020-04-26 12:04 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJiuCcc2LQ4L36KSfO8iLVFBUO6k+zsZFX+_Ovm_10PoWO4AsA@mail.gmail.com \
--to=peron.clem@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime@cerno.tech \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.