From: Chuanhong Guo <gch981213@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Cai Huoqing <cai.huoqing@linux.dev>,
Florian Fainelli <f.fainelli@gmail.com>,
Colin Ian King <colin.king@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi
Date: Mon, 4 Apr 2022 00:01:32 +0800 [thread overview]
Message-ID: <CAJsYDVK9UB=71Yj2t9Rc658W66Lf=uK6eLn5S+Y8Rj3skz4g+w@mail.gmail.com> (raw)
In-Reply-To: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org>
Hi!
On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> [...]
> >>> +
> >>> + ecc-engine:
> >>
> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
> >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
> >> use properties from existing YAML.
> >
> > The ecc-engine code is shared between mtk_nand.c and this driver, and
> > the property name is defined in the shared part. I left it as-is so that
> > existing dt for mtk_nand doesn't break.
>
> This can be easily fixed with:
> np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
> if (!np) {
> /* Backwards compatible */
> np = of_parse_phandle(of_node, "ecc-engine", 0);
> }
>
> I would like to avoid having one property in generic NAND schema and
> keep adding something slightly different everywhere else.
OK. I'll add a commit for this in the next version.
--
Regards,
Chuanhong Guo
WARNING: multiple messages have this Message-ID (diff)
From: Chuanhong Guo <gch981213@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Cai Huoqing <cai.huoqing@linux.dev>,
Florian Fainelli <f.fainelli@gmail.com>,
Colin Ian King <colin.king@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi
Date: Mon, 4 Apr 2022 00:01:32 +0800 [thread overview]
Message-ID: <CAJsYDVK9UB=71Yj2t9Rc658W66Lf=uK6eLn5S+Y8Rj3skz4g+w@mail.gmail.com> (raw)
In-Reply-To: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org>
Hi!
On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> [...]
> >>> +
> >>> + ecc-engine:
> >>
> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
> >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
> >> use properties from existing YAML.
> >
> > The ecc-engine code is shared between mtk_nand.c and this driver, and
> > the property name is defined in the shared part. I left it as-is so that
> > existing dt for mtk_nand doesn't break.
>
> This can be easily fixed with:
> np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
> if (!np) {
> /* Backwards compatible */
> np = of_parse_phandle(of_node, "ecc-engine", 0);
> }
>
> I would like to avoid having one property in generic NAND schema and
> keep adding something slightly different everywhere else.
OK. I'll add a commit for this in the next version.
--
Regards,
Chuanhong Guo
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Chuanhong Guo <gch981213@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Cai Huoqing <cai.huoqing@linux.dev>,
Florian Fainelli <f.fainelli@gmail.com>,
Colin Ian King <colin.king@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi
Date: Mon, 4 Apr 2022 00:01:32 +0800 [thread overview]
Message-ID: <CAJsYDVK9UB=71Yj2t9Rc658W66Lf=uK6eLn5S+Y8Rj3skz4g+w@mail.gmail.com> (raw)
In-Reply-To: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org>
Hi!
On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> [...]
> >>> +
> >>> + ecc-engine:
> >>
> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
> >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
> >> use properties from existing YAML.
> >
> > The ecc-engine code is shared between mtk_nand.c and this driver, and
> > the property name is defined in the shared part. I left it as-is so that
> > existing dt for mtk_nand doesn't break.
>
> This can be easily fixed with:
> np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
> if (!np) {
> /* Backwards compatible */
> np = of_parse_phandle(of_node, "ecc-engine", 0);
> }
>
> I would like to avoid having one property in generic NAND schema and
> keep adding something slightly different everywhere else.
OK. I'll add a commit for this in the next version.
--
Regards,
Chuanhong Guo
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Chuanhong Guo <gch981213@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Cai Huoqing <cai.huoqing@linux.dev>,
Florian Fainelli <f.fainelli@gmail.com>,
Colin Ian King <colin.king@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Paul Cercueil <paul@crapouillou.net>,
Pratyush Yadav <p.yadav@ti.com>, Yu Kuai <yukuai3@huawei.com>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi
Date: Mon, 4 Apr 2022 00:01:32 +0800 [thread overview]
Message-ID: <CAJsYDVK9UB=71Yj2t9Rc658W66Lf=uK6eLn5S+Y8Rj3skz4g+w@mail.gmail.com> (raw)
In-Reply-To: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org>
Hi!
On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> [...]
> >>> +
> >>> + ecc-engine:
> >>
> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
> >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
> >> use properties from existing YAML.
> >
> > The ecc-engine code is shared between mtk_nand.c and this driver, and
> > the property name is defined in the shared part. I left it as-is so that
> > existing dt for mtk_nand doesn't break.
>
> This can be easily fixed with:
> np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
> if (!np) {
> /* Backwards compatible */
> np = of_parse_phandle(of_node, "ecc-engine", 0);
> }
>
> I would like to avoid having one property in generic NAND schema and
> keep adding something slightly different everywhere else.
OK. I'll add a commit for this in the next version.
--
Regards,
Chuanhong Guo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-03 16:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 13:11 [PATCH 0/4] spi: add support for Mediatek SPI-NAND controller Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` [PATCH 1/4] mtd: nand: make mtk_ecc.c a separated module Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` [PATCH 2/4] spi: add driver for MTK SPI NAND Flash Interface Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 15:37 ` Krzysztof Kozlowski
2022-04-03 15:37 ` Krzysztof Kozlowski
2022-04-03 15:37 ` Krzysztof Kozlowski
2022-04-03 15:37 ` Krzysztof Kozlowski
2022-04-03 15:45 ` Chuanhong Guo
2022-04-03 15:45 ` Chuanhong Guo
2022-04-03 15:45 ` Chuanhong Guo
2022-04-03 15:45 ` Chuanhong Guo
2022-04-03 15:49 ` Krzysztof Kozlowski
2022-04-03 15:49 ` Krzysztof Kozlowski
2022-04-03 15:49 ` Krzysztof Kozlowski
2022-04-03 15:49 ` Krzysztof Kozlowski
2022-04-03 16:01 ` Chuanhong Guo [this message]
2022-04-03 16:01 ` Chuanhong Guo
2022-04-03 16:01 ` Chuanhong Guo
2022-04-03 16:01 ` Chuanhong Guo
2022-04-03 13:11 ` [PATCH 4/4] arm64: dts: mediatek: add dt node for MTK SNFI Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
2022-04-03 13:11 ` Chuanhong Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJsYDVK9UB=71Yj2t9Rc658W66Lf=uK6eLn5S+Y8Rj3skz4g+w@mail.gmail.com' \
--to=gch981213@gmail.com \
--cc=broonie@kernel.org \
--cc=cai.huoqing@linux.dev \
--cc=colin.king@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.