From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Christoph Hellwig <hch@lst.de>,
mporter@kernel.crashing.org, Alex Bounine <alex.bou9@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-pci@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI
Date: Thu, 1 Nov 2018 00:33:04 +0900 [thread overview]
Message-ID: <CAK7LNARa7xqG1iyQb9PE271L8QTC7nsaVXSAofm0hzku8T5Xvg@mail.gmail.com> (raw)
In-Reply-To: <20181019151019.GA5618@localhost>
On Sat, Oct 20, 2018 at 12:10 AM Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote:
> > Various powerpc boards select the PCI_MSI config option without selecting
> > PCI, resulting in potentially not compilable configurations if the by
> > default enabled PCI option is disabled. Explicitly select PCI to ensure
> > we always have valid configs.
> [...]
> > --- a/arch/powerpc/platforms/44x/Kconfig
> > +++ b/arch/powerpc/platforms/44x/Kconfig
> > @@ -24,6 +24,7 @@ config BLUESTONE
> > default n
> > select PPC44x_SIMPLE
> > select APM821xx
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_MSI
> > select PPC4xx_PCI_EXPRESS
> > @@ -78,6 +79,7 @@ config KATMAI
> > select 440SPe
> > select PCI
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
>
> This case already had PCI selected a couple of lines above.
Good catch!
I dropped this hunk,
and applied to linux-kbuild.
> > select PPC4xx_MSI
> > help
> > @@ -219,6 +221,7 @@ config AKEBONO
> > select SWIOTLB
> > select 476FPE
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_HSTA_MSI
> > select I2C
> > --
> > 2.19.1
> >
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Alex Bounine <alex.bou9@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/9] powerpc: PCI_MSI needs PCI
Date: Thu, 1 Nov 2018 00:33:04 +0900 [thread overview]
Message-ID: <CAK7LNARa7xqG1iyQb9PE271L8QTC7nsaVXSAofm0hzku8T5Xvg@mail.gmail.com> (raw)
In-Reply-To: <20181019151019.GA5618@localhost>
On Sat, Oct 20, 2018 at 12:10 AM Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote:
> > Various powerpc boards select the PCI_MSI config option without selecting
> > PCI, resulting in potentially not compilable configurations if the by
> > default enabled PCI option is disabled. Explicitly select PCI to ensure
> > we always have valid configs.
> [...]
> > --- a/arch/powerpc/platforms/44x/Kconfig
> > +++ b/arch/powerpc/platforms/44x/Kconfig
> > @@ -24,6 +24,7 @@ config BLUESTONE
> > default n
> > select PPC44x_SIMPLE
> > select APM821xx
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_MSI
> > select PPC4xx_PCI_EXPRESS
> > @@ -78,6 +79,7 @@ config KATMAI
> > select 440SPe
> > select PCI
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
>
> This case already had PCI selected a couple of lines above.
Good catch!
I dropped this hunk,
and applied to linux-kbuild.
> > select PPC4xx_MSI
> > help
> > @@ -219,6 +221,7 @@ config AKEBONO
> > select SWIOTLB
> > select 476FPE
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_HSTA_MSI
> > select I2C
> > --
> > 2.19.1
> >
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] powerpc: PCI_MSI needs PCI
Date: Thu, 1 Nov 2018 00:33:04 +0900 [thread overview]
Message-ID: <CAK7LNARa7xqG1iyQb9PE271L8QTC7nsaVXSAofm0hzku8T5Xvg@mail.gmail.com> (raw)
In-Reply-To: <20181019151019.GA5618@localhost>
On Sat, Oct 20, 2018 at 12:10 AM Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote:
> > Various powerpc boards select the PCI_MSI config option without selecting
> > PCI, resulting in potentially not compilable configurations if the by
> > default enabled PCI option is disabled. Explicitly select PCI to ensure
> > we always have valid configs.
> [...]
> > --- a/arch/powerpc/platforms/44x/Kconfig
> > +++ b/arch/powerpc/platforms/44x/Kconfig
> > @@ -24,6 +24,7 @@ config BLUESTONE
> > default n
> > select PPC44x_SIMPLE
> > select APM821xx
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_MSI
> > select PPC4xx_PCI_EXPRESS
> > @@ -78,6 +79,7 @@ config KATMAI
> > select 440SPe
> > select PCI
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
>
> This case already had PCI selected a couple of lines above.
Good catch!
I dropped this hunk,
and applied to linux-kbuild.
> > select PPC4xx_MSI
> > help
> > @@ -219,6 +221,7 @@ config AKEBONO
> > select SWIOTLB
> > select 476FPE
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_HSTA_MSI
> > select I2C
> > --
> > 2.19.1
> >
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-10-31 15:33 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:09 move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v3 Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` [PATCH 1/9] aha152x: rename the PCMCIA define Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-31 15:22 ` Masahiro Yamada
2018-10-31 15:22 ` Masahiro Yamada
2018-10-31 15:22 ` Masahiro Yamada
2018-10-19 12:09 ` [PATCH 2/9] arm: remove EISA kconfig option Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:56 ` Masahiro Yamada
2018-10-19 12:56 ` Masahiro Yamada
2018-10-19 12:56 ` Masahiro Yamada
2018-10-19 12:09 ` [PATCH 3/9] powerpc: remove CONFIG_PCI_QSPAN Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-31 15:27 ` Masahiro Yamada
2018-10-31 15:27 ` Masahiro Yamada
2018-10-31 15:27 ` Masahiro Yamada
2018-10-19 12:09 ` [PATCH 4/9] powerpc: remove CONFIG_MCA leftovers Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-31 15:31 ` Masahiro Yamada
2018-10-31 15:31 ` Masahiro Yamada
2018-10-31 15:31 ` Masahiro Yamada
2018-10-19 12:09 ` [PATCH 5/9] powerpc: PCI_MSI needs PCI Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 15:10 ` Josh Triplett
2018-10-19 15:10 ` Josh Triplett
2018-10-19 15:10 ` Josh Triplett
2018-10-31 15:33 ` Masahiro Yamada [this message]
2018-10-31 15:33 ` Masahiro Yamada
2018-10-31 15:33 ` Masahiro Yamada
2018-10-19 12:09 ` [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:22 ` Russell King - ARM Linux
2018-10-19 12:22 ` Russell King - ARM Linux
2018-10-19 12:22 ` Russell King - ARM Linux
2018-10-19 12:58 ` Masahiro Yamada
2018-10-19 12:58 ` Masahiro Yamada
2018-10-19 12:58 ` Masahiro Yamada
2018-10-31 16:05 ` Masahiro Yamada
2018-10-31 16:05 ` Masahiro Yamada
2018-10-31 16:05 ` Masahiro Yamada
2018-11-01 5:48 ` Christoph Hellwig
2018-11-01 5:48 ` Christoph Hellwig
2018-11-01 5:48 ` Christoph Hellwig
2018-11-01 10:24 ` Russell King - ARM Linux
2018-11-01 10:24 ` Russell King - ARM Linux
2018-11-01 10:24 ` Russell King - ARM Linux
2018-10-19 18:18 ` Palmer Dabbelt
2018-10-19 18:18 ` Palmer Dabbelt
2018-10-19 18:18 ` Palmer Dabbelt
2018-11-08 22:45 ` Bjorn Helgaas
2018-11-08 22:45 ` Bjorn Helgaas
2018-11-08 22:45 ` Bjorn Helgaas
2018-10-19 12:09 ` [PATCH 7/9] pcmcia: allow PCMCIA support independent of the architecture Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` [PATCH 8/9] rapidio: consolidate RAPIDIO config entry in drivers/rapidio Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` [PATCH 9/9] eisa: consolidate EISA Kconfig entry in drivers/eisa Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
2018-10-19 12:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARa7xqG1iyQb9PE271L8QTC7nsaVXSAofm0hzku8T5Xvg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=alex.bou9@gmail.com \
--cc=hch@lst.de \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.