From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER
Date: Tue, 20 Sep 2016 17:47:45 +0900 [thread overview]
Message-ID: <CAK7LNASDYjUjUoUEstFygA1GOboVgDTNKak8Zkpcj_B3XbK-1w@mail.gmail.com> (raw)
In-Reply-To: <1474356608.4030.7.camel@pengutronix.de>
Hi Philipp,
2016-09-20 16:30 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Hi Masahiro,
>
> Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada:
>> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been
>> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Philipp,
>>
>> IIRC, you mentioned that you were planning to consolidate the double
>> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER.
>>
>> I have not seen it in the ML, so I am sending this.
>>
>> Please let me know if you have some updates.
>
> I had started to doodle a bit, see
>
> git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig
>
> but I haven't found time for cleanup and testing.
OK, I will merge this patch for now.
BTW, I did not understand some of your commits under way.
commit 7fe911f9c83737449565db03bebf953d3d94bbbf
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Tue Aug 9 11:18:51 2016 +0200
dmaengine: sunx6i: do not depend on reset controller framework
The reset controller framework provides inline function stubs if
disabled.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
As far as I see from drivers/dma/sun6i-dma.c,
the reset control is mandatory for this driver.
Why are you removing the dependency?
Don't you care if it works on run-time
as long as it can build?
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER
Date: Tue, 20 Sep 2016 17:47:45 +0900 [thread overview]
Message-ID: <CAK7LNASDYjUjUoUEstFygA1GOboVgDTNKak8Zkpcj_B3XbK-1w@mail.gmail.com> (raw)
In-Reply-To: <1474356608.4030.7.camel@pengutronix.de>
Hi Philipp,
2016-09-20 16:30 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Hi Masahiro,
>
> Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada:
>> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been
>> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Philipp,
>>
>> IIRC, you mentioned that you were planning to consolidate the double
>> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER.
>>
>> I have not seen it in the ML, so I am sending this.
>>
>> Please let me know if you have some updates.
>
> I had started to doodle a bit, see
>
> git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig
>
> but I haven't found time for cleanup and testing.
OK, I will merge this patch for now.
BTW, I did not understand some of your commits under way.
commit 7fe911f9c83737449565db03bebf953d3d94bbbf
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Tue Aug 9 11:18:51 2016 +0200
dmaengine: sunx6i: do not depend on reset controller framework
The reset controller framework provides inline function stubs if
disabled.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
As far as I see from drivers/dma/sun6i-dma.c,
the reset control is mandatory for this driver.
Why are you removing the dependency?
Don't you care if it works on run-time
as long as it can build?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2016-09-20 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 4:43 [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Masahiro Yamada
2016-09-20 4:43 ` Masahiro Yamada
2016-09-20 7:30 ` Philipp Zabel
2016-09-20 7:30 ` Philipp Zabel
2016-09-20 8:47 ` Masahiro Yamada [this message]
2016-09-20 8:47 ` Masahiro Yamada
2016-09-20 10:44 ` Philipp Zabel
2016-09-20 10:44 ` Philipp Zabel
2016-09-26 5:47 ` Masahiro Yamada
2016-09-26 5:47 ` Masahiro Yamada
2016-09-20 7:30 ` Philipp Zabel
2016-09-20 7:30 ` Philipp Zabel
2016-10-08 2:18 ` Masahiro Yamada
2016-10-08 2:18 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASDYjUjUoUEstFygA1GOboVgDTNKak8Zkpcj_B3XbK-1w@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.