Re: [PATCH v3 1/1] gen_compile_commands: fix invalid escape sequence warning

From: Masahiro Yamada <masahiroy@kernel.org>
To: Andrew Ballance <andrewjballance@gmail.com>
Cc: justinstitt@google.com, linux-kbuild@vger.kernel.org,
	 linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org,  llvm@lists.linux.dev,
	morbo@google.com, nathan@kernel.org,  ndesaulniers@google.com,
	nicolas@fjasle.eu, skhan@linuxfoundation.org
Subject: Re: [PATCH v3 1/1] gen_compile_commands: fix invalid escape sequence warning
Date: Thu, 15 Feb 2024 06:27:24 +0900	[thread overview]
Message-ID: <CAK7LNASspq7uYYPx6QLOad_WUeXsyRmtbq9qibXJP_Fbo3Fs0g@mail.gmail.com> (raw)
In-Reply-To: <20240214012439.879134-2-andrewjballance@gmail.com>

On Wed, Feb 14, 2024 at 10:25 AM Andrew Ballance
<andrewjballance@gmail.com> wrote:
>
> with python 3.12.1 '\#' results in this warning
>     SyntaxWarning: invalid escape sequence '\#'

I changed "3.12.1" to "3.12" when I applied it
because this occurs for Python 3.12.0

Thanks.

>
> Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
> ---
>  scripts/clang-tools/gen_compile_commands.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> index 5dea4479240b..e4fb686dfaa9 100755
> --- a/scripts/clang-tools/gen_compile_commands.py
> +++ b/scripts/clang-tools/gen_compile_commands.py
> @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path):
>      # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the
>      # kernel version). The compile_commands.json file is not interepreted
>      # by Make, so this code replaces the escaped version with '#'.
> -    prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#')
> +    prefix = command_prefix.replace(r'\#', '#').replace('$(pound)', '#')
>
>      # Return the canonical path, eliminating any symbolic links encountered in the path.
>      abs_path = os.path.realpath(os.path.join(root_directory, file_path))
> --
> 2.43.0
>

-- 
Best Regards
Masahiro Yamada