From: Nicolas Schier <nicolas@fjasle.eu>
To: Andrew Ballance <andrewjballance@gmail.com>
Cc: masahiroy@kernel.org, justinstitt@google.com,
linux-kbuild@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
morbo@google.com, nathan@kernel.org, ndesaulniers@google.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2] gen_compile_commands: fix invalid escape sequence warning
Date: Tue, 13 Feb 2024 21:00:03 +0100 [thread overview]
Message-ID: <ZcvKQ3SpLNR9RfIe@bergen.fjasle.eu> (raw)
In-Reply-To: <20240213022552.754830-1-andrewjballance@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote:
> with python 12.1 '\#' results in this warning
funny typo: it's Python 3.12 :)
Kind regards,
Nicolas
> SyntaxWarning: invalid escape sequence '\#'
>
> Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
> ---
> scripts/clang-tools/gen_compile_commands.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> index 5dea4479240b..93f64095fda9 100755
> --- a/scripts/clang-tools/gen_compile_commands.py
> +++ b/scripts/clang-tools/gen_compile_commands.py
> @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path):
> # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the
> # kernel version). The compile_commands.json file is not interepreted
> # by Make, so this code replaces the escaped version with '#'.
> - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#')
> + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#')
>
> # Return the canonical path, eliminating any symbolic links encountered in the path.
> abs_path = os.path.realpath(os.path.join(root_directory, file_path))
> --
> 2.43.0
>
--
Nicolas Schier
epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-13 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 1:20 [PATCH] gen_compile_commands: fix invalid escape sequence Andrew Ballance
2024-02-13 1:48 ` Masahiro Yamada
2024-02-13 2:25 ` [PATCH v2] gen_compile_commands: fix invalid escape sequence warning Andrew Ballance
2024-02-13 20:00 ` Nicolas Schier [this message]
2024-02-14 0:31 ` Justin Stitt
2024-02-14 1:23 ` [PATCH v3 0/1] " Andrew Ballance
2024-02-14 1:23 ` [PATCH v3 1/1] " Andrew Ballance
2024-02-14 18:28 ` Justin Stitt
2024-02-14 21:27 ` Masahiro Yamada
2024-02-14 0:40 ` [PATCH v2] " Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcvKQ3SpLNR9RfIe@bergen.fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=andrewjballance@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.