From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Christoph Hellwig <hch@lst.de>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv@lists.infradead.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 01/11] powerpc: remove dead ifdefs in <asm/checksum.h>
Date: Fri, 15 Feb 2019 18:30:09 +0900 [thread overview]
Message-ID: <CAK7LNATnsMbciyEd-1HZZmb5A66-TBtq0R3X-=JPMNT6iADo4w@mail.gmail.com> (raw)
In-Reply-To: <d5451fc4-9183-702a-e9ed-4a2be1f82a11@c-s.fr>
On Fri, Feb 15, 2019 at 5:18 PM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 14/02/2019 à 18:05, Christoph Hellwig a écrit :
> > On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote:
> >> Could you also remove the 'config GENERIC_CSUM' item in
> >> arch/powerpc/Kconfig ?
> >
> > All the separate declarations go away later in this series.
> >
>
> I saw, but the purpose of the later patch is to replace arch defined
> GENERIC_CSUM by a common one that arches select. For the powerpc you are
> not in that case as the powerpc does not select GENERIC_CSUM.
>
> So I really believe that all stale bits of remaining GENERIC_CSUM in
> powerpc should go away as a single dedicated patch, as a fix of commit
> d4fde568a34a ("powerpc/64: Use optimized checksum routines on
> little-endian")
>
> Regarding the #ifdef __KERNEL__ , I think we should do a wide cleanup in
> arch/powerpc/include/asm, not only asm/checksum.h
>
> Christophe
Please send such cleanups to PowerPC ML
instead of to me (Kbuild).
Christoph,
I think this one is independent of the rest of this series.
How about separating it if you volunteer to Powerpc cleansup?
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv@lists.infradead.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/11] powerpc: remove dead ifdefs in <asm/checksum.h>
Date: Fri, 15 Feb 2019 18:30:09 +0900 [thread overview]
Message-ID: <CAK7LNATnsMbciyEd-1HZZmb5A66-TBtq0R3X-=JPMNT6iADo4w@mail.gmail.com> (raw)
In-Reply-To: <d5451fc4-9183-702a-e9ed-4a2be1f82a11@c-s.fr>
On Fri, Feb 15, 2019 at 5:18 PM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 14/02/2019 à 18:05, Christoph Hellwig a écrit :
> > On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote:
> >> Could you also remove the 'config GENERIC_CSUM' item in
> >> arch/powerpc/Kconfig ?
> >
> > All the separate declarations go away later in this series.
> >
>
> I saw, but the purpose of the later patch is to replace arch defined
> GENERIC_CSUM by a common one that arches select. For the powerpc you are
> not in that case as the powerpc does not select GENERIC_CSUM.
>
> So I really believe that all stale bits of remaining GENERIC_CSUM in
> powerpc should go away as a single dedicated patch, as a fix of commit
> d4fde568a34a ("powerpc/64: Use optimized checksum routines on
> little-endian")
>
> Regarding the #ifdef __KERNEL__ , I think we should do a wide cleanup in
> arch/powerpc/include/asm, not only asm/checksum.h
>
> Christophe
Please send such cleanups to PowerPC ML
instead of to me (Kbuild).
Christoph,
I think this one is independent of the rest of this series.
How about separating it if you volunteer to Powerpc cleansup?
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv@lists.infradead.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/11] powerpc: remove dead ifdefs in <asm/checksum.h>
Date: Fri, 15 Feb 2019 18:30:09 +0900 [thread overview]
Message-ID: <CAK7LNATnsMbciyEd-1HZZmb5A66-TBtq0R3X-=JPMNT6iADo4w@mail.gmail.com> (raw)
In-Reply-To: <d5451fc4-9183-702a-e9ed-4a2be1f82a11@c-s.fr>
On Fri, Feb 15, 2019 at 5:18 PM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 14/02/2019 à 18:05, Christoph Hellwig a écrit :
> > On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote:
> >> Could you also remove the 'config GENERIC_CSUM' item in
> >> arch/powerpc/Kconfig ?
> >
> > All the separate declarations go away later in this series.
> >
>
> I saw, but the purpose of the later patch is to replace arch defined
> GENERIC_CSUM by a common one that arches select. For the powerpc you are
> not in that case as the powerpc does not select GENERIC_CSUM.
>
> So I really believe that all stale bits of remaining GENERIC_CSUM in
> powerpc should go away as a single dedicated patch, as a fix of commit
> d4fde568a34a ("powerpc/64: Use optimized checksum routines on
> little-endian")
>
> Regarding the #ifdef __KERNEL__ , I think we should do a wide cleanup in
> arch/powerpc/include/asm, not only asm/checksum.h
>
> Christophe
Please send such cleanups to PowerPC ML
instead of to me (Kbuild).
Christoph,
I think this one is independent of the rest of this series.
How about separating it if you volunteer to Powerpc cleansup?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-02-15 9:31 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 17:39 consolidate a few more arch support config options Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` [PATCH 01/11] powerpc: remove dead ifdefs in <asm/checksum.h> Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-14 8:26 ` Christophe Leroy
2019-02-14 8:26 ` Christophe Leroy
2019-02-14 8:26 ` Christophe Leroy
2019-02-14 17:05 ` Christoph Hellwig
2019-02-14 17:05 ` Christoph Hellwig
2019-02-14 17:05 ` Christoph Hellwig
2019-02-15 8:17 ` Christophe Leroy
2019-02-15 8:17 ` Christophe Leroy
2019-02-15 8:17 ` Christophe Leroy
2019-02-15 9:30 ` Masahiro Yamada [this message]
2019-02-15 9:30 ` Masahiro Yamada
2019-02-15 9:30 ` Masahiro Yamada
2019-02-14 8:54 ` Andreas Schwab
2019-02-14 8:54 ` Andreas Schwab
2019-02-14 8:54 ` Andreas Schwab
2019-02-13 17:39 ` [PATCH 02/11] riscv: remove the HAVE_KPROBES option Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-15 9:32 ` Masahiro Yamada
2019-02-15 9:32 ` Masahiro Yamada
2019-02-15 9:32 ` Masahiro Yamada
2019-02-19 15:17 ` Christoph Hellwig
2019-02-19 15:17 ` Christoph Hellwig
2019-02-19 15:17 ` Christoph Hellwig
2019-02-19 21:55 ` Palmer Dabbelt
2019-02-19 21:55 ` Palmer Dabbelt
2019-02-19 21:55 ` Palmer Dabbelt
2019-02-19 21:55 ` Palmer Dabbelt
2019-02-13 17:39 ` [PATCH 03/11] kernel/locks: consolidate RWSEM_GENERIC_* options Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-14 8:10 ` Geert Uytterhoeven
2019-02-14 8:10 ` Geert Uytterhoeven
2019-02-14 8:10 ` Geert Uytterhoeven
2019-02-14 10:52 ` Geert Uytterhoeven
2019-02-14 10:52 ` Geert Uytterhoeven
2019-02-14 10:52 ` Geert Uytterhoeven
2019-02-14 15:26 ` Waiman Long
2019-02-14 15:26 ` Waiman Long
2019-02-14 15:26 ` Waiman Long
2019-02-14 17:04 ` Christoph Hellwig
2019-02-14 17:04 ` Christoph Hellwig
2019-02-14 17:04 ` Christoph Hellwig
2019-02-14 17:24 ` Waiman Long
2019-02-14 17:24 ` Waiman Long
2019-02-14 17:24 ` Waiman Long
2019-02-13 17:39 ` [PATCH 04/11] tracing: consolidate the STACKTRACE_SUPPORT symbol Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-13 17:39 ` Christoph Hellwig
2019-02-15 7:55 ` Masahiro Yamada
2019-02-15 7:55 ` Masahiro Yamada
2019-02-15 7:55 ` Masahiro Yamada
2019-02-19 1:40 ` Ley Foon Tan
2019-02-19 1:40 ` Ley Foon Tan
2019-02-19 1:40 ` Ley Foon Tan
2019-02-13 17:40 ` [PATCH 06/11] lockdep: consolidate the LOCKDEP_SUPPORT symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-15 7:16 ` Masahiro Yamada
2019-02-15 7:16 ` Masahiro Yamada
2019-02-15 7:16 ` Masahiro Yamada
2019-02-15 7:58 ` Greentime Hu
2019-02-15 7:58 ` Greentime Hu
2019-02-15 7:58 ` Greentime Hu
2019-02-13 17:40 ` [PATCH 07/11] init: consolidate the GENERIC_CALIBRATE_DELAY symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-14 8:11 ` Geert Uytterhoeven
2019-02-14 8:11 ` Geert Uytterhoeven
2019-02-14 8:11 ` Geert Uytterhoeven
2019-02-13 17:40 ` [PATCH 08/11] lib: consolidate the GENERIC_BUG symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-15 8:42 ` Masahiro Yamada
2019-02-15 8:42 ` Masahiro Yamada
2019-02-15 8:42 ` Masahiro Yamada
2019-02-13 17:40 ` [PATCH 09/11] lib: consolidate the GENERIC_CSUM symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-14 8:12 ` Geert Uytterhoeven
2019-02-14 8:12 ` Geert Uytterhoeven
2019-02-14 8:12 ` Geert Uytterhoeven
2019-02-15 8:03 ` Masahiro Yamada
2019-02-15 8:03 ` Masahiro Yamada
2019-02-15 8:03 ` Masahiro Yamada
2019-02-13 17:40 ` [PATCH 10/11] lib: consolidate the GENERIC_HWEIGHT symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-14 8:13 ` Geert Uytterhoeven
2019-02-14 8:13 ` Geert Uytterhoeven
2019-02-14 8:13 ` Geert Uytterhoeven
2019-02-18 3:06 ` Masahiro Yamada
2019-02-18 3:06 ` Masahiro Yamada
2019-02-18 3:06 ` Masahiro Yamada
2019-02-13 17:40 ` [PATCH 11/11] s390: don't redefined the HAS_IOMEM symbol Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-13 17:40 ` Christoph Hellwig
2019-02-15 7:44 ` Masahiro Yamada
2019-02-15 7:44 ` Masahiro Yamada
2019-02-15 7:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATnsMbciyEd-1HZZmb5A66-TBtq0R3X-=JPMNT6iADo4w@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=christophe.leroy@c-s.fr \
--cc=hch@lst.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.