From: Arnd Bergmann <arnd@arndb.de>
To: Michael Kelley <mikelley@microsoft.com>
Cc: Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
gregkh <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-hyperv@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
wei.liu@kernel.org, Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files
Date: Mon, 24 Aug 2020 20:38:45 +0200 [thread overview]
Message-ID: <CAK8P3a0qAZ5nGQ6eEjtAR4MD=CNnkU_uW1PsUdwJiZC1Hy+bpg@mail.gmail.com> (raw)
In-Reply-To: <1598287583-71762-3-git-send-email-mikelley@microsoft.com>
On Mon, Aug 24, 2020 at 6:47 PM Michael Kelley <mikelley@microsoft.com> wrote:
> +
> +#define hv_get_simp(val) (val = hv_get_vpreg(HV_REGISTER_SIPP))
> +
> +#define hv_get_siefp(val) (val = hv_get_vpreg(HV_REGISTER_SIFP))
Macros that modify their arguments are generally a bad idea. Since each one
of these only has a few callers, could you just redefine the x86 version to
use function-style calling conventions and turn them into inline functions?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Michael Kelley <mikelley@microsoft.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arch <linux-arch@vger.kernel.org>,
linux-hyperv@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
wei.liu@kernel.org, Marc Zyngier <maz@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files
Date: Mon, 24 Aug 2020 20:38:45 +0200 [thread overview]
Message-ID: <CAK8P3a0qAZ5nGQ6eEjtAR4MD=CNnkU_uW1PsUdwJiZC1Hy+bpg@mail.gmail.com> (raw)
In-Reply-To: <1598287583-71762-3-git-send-email-mikelley@microsoft.com>
On Mon, Aug 24, 2020 at 6:47 PM Michael Kelley <mikelley@microsoft.com> wrote:
> +
> +#define hv_get_simp(val) (val = hv_get_vpreg(HV_REGISTER_SIPP))
> +
> +#define hv_get_siefp(val) (val = hv_get_vpreg(HV_REGISTER_SIFP))
Macros that modify their arguments are generally a bad idea. Since each one
of these only has a few callers, could you just redefine the x86 version to
use function-style calling conventions and turn them into inline functions?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-24 18:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 16:46 [PATCH v7 00/10] Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 01/10] arm/arm64: smccc-1.1: Add vendor specific owner definition Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 02/10] arm64: hyperv: Add core Hyper-V include files Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 18:38 ` Arnd Bergmann [this message]
2020-08-24 18:38 ` Arnd Bergmann
2020-08-24 16:46 ` [PATCH v7 03/10] arm64: hyperv: Add hypercall and register access functions Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 04/10] arm64: hyperv: Add memory alloc/free functions for Hyper-V size pages Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 05/10] arm64: hyperv: Add interrupt handlers for VMbus and stimer Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 18:54 ` Arnd Bergmann
2020-08-24 18:54 ` Arnd Bergmann
2020-08-25 22:04 ` Michael Kelley
2020-08-25 22:04 ` Michael Kelley
2020-08-26 7:14 ` Arnd Bergmann
2020-08-26 7:14 ` Arnd Bergmann
2020-08-24 16:46 ` [PATCH v7 06/10] arm64: hyperv: Add kexec and panic handlers Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 07/10] arm64: hyperv: Initialize hypervisor on boot Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 18:33 ` Arnd Bergmann
2020-08-24 18:33 ` Arnd Bergmann
2020-08-25 21:20 ` Michael Kelley
2020-08-25 21:20 ` Michael Kelley
2020-08-26 7:18 ` Arnd Bergmann
2020-08-26 7:18 ` Arnd Bergmann
2020-08-24 16:46 ` [PATCH v7 08/10] Drivers: hv: vmbus: Add hooks for per-CPU IRQ Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 16:46 ` [PATCH v7 09/10] arm64: efi: Export screen_info Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 17:21 ` Ard Biesheuvel
2020-08-24 17:21 ` Ard Biesheuvel
2020-08-24 17:35 ` Greg KH
2020-08-24 17:35 ` Greg KH
2020-08-24 17:40 ` Michael Kelley
2020-08-24 17:40 ` Michael Kelley
2020-08-24 17:52 ` Greg KH
2020-08-24 17:52 ` Greg KH
2020-08-24 16:46 ` [PATCH v7 10/10] Drivers: hv: Enable Hyper-V code to be built on ARM64 Michael Kelley
2020-08-24 16:46 ` Michael Kelley
2020-08-24 17:24 ` Ard Biesheuvel
2020-08-24 17:24 ` Ard Biesheuvel
2020-08-24 17:28 ` Michael Kelley
2020-08-24 17:28 ` Michael Kelley
2020-08-25 8:47 ` Ben Dooks
2020-08-25 8:47 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0qAZ5nGQ6eEjtAR4MD=CNnkU_uW1PsUdwJiZC1Hy+bpg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mikelley@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.