From: Arnd Bergmann <arnd@arndb.de>
To: Alex Elder <elder@linaro.org>
Cc: David Miller <davem@davemloft.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Networking <netdev@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
syadagir@codeaurora.org, mjavid@codeaurora.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RFC PATCH 07/12] soc: qcom: ipa: IPA register abstraction
Date: Thu, 15 Nov 2018 06:42:45 -0800 [thread overview]
Message-ID: <CAK8P3a1RKVYRhM7OtUK3BhPj=jip2-j_8ziW_6Z5rnhFCTOOUw@mail.gmail.com> (raw)
In-Reply-To: <e9114caf-0c92-7cac-33cd-6bea548b0375@linaro.org>
On Wed, Nov 14, 2018 at 6:48 PM Alex Elder <elder@linaro.org> wrote:
>
> On 11/7/18 9:00 AM, Arnd Bergmann wrote:
> > On Wed, Nov 7, 2018 at 1:33 AM Alex Elder <elder@linaro.org> wrote:
> >> diff --git a/drivers/net/ipa/ipa_reg.c b/drivers/net/ipa/ipa_reg.c
> >> new file mode 100644
> >> index 000000000000..5e0aa6163235
> >> --- /dev/null
> >> +++ b/drivers/net/ipa/ipa_reg.c
> >> @@ -0,0 +1,972 @@
> It may be that this parse/construct mechanism isn't justified
> at this point. I thought the way it presented a generic
> interface was useful, but with just one (initial) hardware
> target we don't (yet) realize its potential benefit. It could
> be added back later, as support for new versions is added.
>
> As of now I don't plan to change this, but if you or someone
> else feels it would be better without it I can do that.
Fair enough. I do think that it would be better to avoid this, but
it's much less important than the other issues I mentioned,
so please put this on the bottom of your priorities list, we
can talk about it again when we get closer to merging the driver.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 07/12] soc: qcom: ipa: IPA register abstraction
Date: Thu, 15 Nov 2018 06:42:45 -0800 [thread overview]
Message-ID: <CAK8P3a1RKVYRhM7OtUK3BhPj=jip2-j_8ziW_6Z5rnhFCTOOUw@mail.gmail.com> (raw)
In-Reply-To: <e9114caf-0c92-7cac-33cd-6bea548b0375@linaro.org>
On Wed, Nov 14, 2018 at 6:48 PM Alex Elder <elder@linaro.org> wrote:
>
> On 11/7/18 9:00 AM, Arnd Bergmann wrote:
> > On Wed, Nov 7, 2018 at 1:33 AM Alex Elder <elder@linaro.org> wrote:
> >> diff --git a/drivers/net/ipa/ipa_reg.c b/drivers/net/ipa/ipa_reg.c
> >> new file mode 100644
> >> index 000000000000..5e0aa6163235
> >> --- /dev/null
> >> +++ b/drivers/net/ipa/ipa_reg.c
> >> @@ -0,0 +1,972 @@
> It may be that this parse/construct mechanism isn't justified
> at this point. I thought the way it presented a generic
> interface was useful, but with just one (initial) hardware
> target we don't (yet) realize its potential benefit. It could
> be added back later, as support for new versions is added.
>
> As of now I don't plan to change this, but if you or someone
> else feels it would be better without it I can do that.
Fair enough. I do think that it would be better to avoid this, but
it's much less important than the other issues I mentioned,
so please put this on the bottom of your priorities list, we
can talk about it again when we get closer to merging the driver.
Arnd
next prev parent reply other threads:[~2018-11-15 14:42 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 0:32 [RFC PATCH 00/12] net: introduce Qualcomm IPA driver Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 01/12] dt-bindings: soc: qcom: add IPA bindings Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 11:50 ` Arnd Bergmann
2018-11-07 11:50 ` Arnd Bergmann
2018-11-09 22:38 ` Alex Elder
2018-11-09 22:38 ` Alex Elder
2018-11-07 14:59 ` Rob Herring
2018-11-07 14:59 ` Rob Herring
2018-11-09 22:38 ` Alex Elder
2018-11-09 22:38 ` Alex Elder
2018-11-11 1:40 ` Rob Herring
2018-11-11 1:40 ` Rob Herring
2018-11-11 1:40 ` Rob Herring
2018-11-13 16:28 ` Alex Elder
2018-11-13 16:28 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 02/12] soc: qcom: ipa: DMA helpers Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 12:17 ` Arnd Bergmann
2018-11-07 12:17 ` Arnd Bergmann
2018-11-13 16:33 ` Alex Elder
2018-11-13 16:33 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 03/12] soc: qcom: ipa: generic software interface Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 04/12] soc: qcom: ipa: immediate commands Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 14:36 ` Arnd Bergmann
2018-11-07 14:36 ` Arnd Bergmann
2018-11-13 16:58 ` Alex Elder
2018-11-13 16:58 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 05/12] soc: qcom: ipa: IPA interrupts and the microcontroller Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 06/12] soc: qcom: ipa: QMI modem communication Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 07/12] soc: qcom: ipa: IPA register abstraction Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 15:00 ` Arnd Bergmann
2018-11-07 15:00 ` Arnd Bergmann
2018-11-15 2:48 ` Alex Elder
2018-11-15 2:48 ` Alex Elder
2018-11-15 14:42 ` Arnd Bergmann [this message]
2018-11-15 14:42 ` Arnd Bergmann
2018-11-07 0:32 ` [RFC PATCH 08/12] soc: qcom: ipa: utility functions Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 09/12] soc: qcom: ipa: main IPA source file Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 14:08 ` Arnd Bergmann
2018-11-07 14:08 ` Arnd Bergmann
2018-11-15 3:11 ` Alex Elder
2018-11-15 3:11 ` Alex Elder
2018-11-07 0:32 ` [RFC PATCH 10/12] soc: qcom: ipa: data path Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 14:55 ` Arnd Bergmann
2018-11-07 14:55 ` Arnd Bergmann
2018-11-15 3:31 ` Alex Elder
2018-11-15 3:31 ` Alex Elder
2018-11-15 14:48 ` Arnd Bergmann
2018-11-15 14:48 ` Arnd Bergmann
2018-11-07 0:32 ` [RFC PATCH 11/12] soc: qcom: ipa: IPA rmnet interface Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 13:30 ` Arnd Bergmann
2018-11-07 13:30 ` Arnd Bergmann
2018-11-07 15:26 ` Dan Williams
2018-11-07 15:26 ` Dan Williams
2018-11-07 0:32 ` [RFC PATCH 12/12] soc: qcom: ipa: build and "ipa_i.h" Alex Elder
2018-11-07 0:32 ` Alex Elder
2018-11-07 0:40 ` Randy Dunlap
2018-11-07 0:40 ` Randy Dunlap
2018-11-07 0:40 ` Randy Dunlap
2018-11-08 16:22 ` Alex Elder
2018-11-08 16:22 ` Alex Elder
2018-11-07 12:34 ` Arnd Bergmann
2018-11-07 12:34 ` Arnd Bergmann
2018-11-07 15:46 ` [RFC PATCH 00/12] net: introduce Qualcomm IPA driver Arnd Bergmann
2018-11-07 15:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1RKVYRhM7OtUK3BhPj=jip2-j_8ziW_6Z5rnhFCTOOUw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mjavid@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=syadagir@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.