From: Arnd Bergmann <arnd@arndb.de>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
clang-built-linux@googlegroups.com,
Nick Desaulniers <ndesaulniers@google.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Max Krummenacher <max.krummenacher@toradex.com>,
Lee Jones <lee.jones@linaro.org>, Stefan Agner <stefan@agner.ch>,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: stmpe-adc: avoid harmless clang warning
Date: Fri, 22 Mar 2019 16:09:05 +0100 [thread overview]
Message-ID: <CAK8P3a1k96x_vqjCWU9Dmj3N7arpD3LLY1Tx3NLwciG-q26hzg@mail.gmail.com> (raw)
In-Reply-To: <20190322145828.GB6521@archlinux-ryzen>
On Fri, Mar 22, 2019 at 3:58 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Fri, Mar 22, 2019 at 03:08:39PM +0100, Arnd Bergmann wrote:
> > Clang points out a control flow bug, which happens to be harmless:
> >
> > drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> >
> > The warning is sensible here, so let's just avoid the case by
> > adding appropriate error handling.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/iio/adc/stmpe-adc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> > index 37f4b74a5d32..ed3817c5c896 100644
> > --- a/drivers/iio/adc/stmpe-adc.c
> > +++ b/drivers/iio/adc/stmpe-adc.c
> > @@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
> > /* Read value */
> > stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2,
> > (u8 *) &data);
> > + } else {
> > + return IRQ_NONE;
> > }
> >
> > info->value = (u32) be16_to_cpu(data);
> > --
> > 2.20.0
> >
>
> I sent a similar patch, which is sitting in Jonathan's testing branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=e15146e4d4349b3f309f5591ea8de8d24071265f
Ok, sorry for the dup. Your seems to be better than mine, too.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Max Krummenacher <max.krummenacher@toradex.com>,
linux-iio@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stefan Agner <stefan@agner.ch>,
clang-built-linux@googlegroups.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Lee Jones <lee.jones@linaro.org>,
linux-stm32@st-md-mailman.stormreply.com,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: stmpe-adc: avoid harmless clang warning
Date: Fri, 22 Mar 2019 16:09:05 +0100 [thread overview]
Message-ID: <CAK8P3a1k96x_vqjCWU9Dmj3N7arpD3LLY1Tx3NLwciG-q26hzg@mail.gmail.com> (raw)
In-Reply-To: <20190322145828.GB6521@archlinux-ryzen>
On Fri, Mar 22, 2019 at 3:58 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Fri, Mar 22, 2019 at 03:08:39PM +0100, Arnd Bergmann wrote:
> > Clang points out a control flow bug, which happens to be harmless:
> >
> > drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> >
> > The warning is sensible here, so let's just avoid the case by
> > adding appropriate error handling.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/iio/adc/stmpe-adc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> > index 37f4b74a5d32..ed3817c5c896 100644
> > --- a/drivers/iio/adc/stmpe-adc.c
> > +++ b/drivers/iio/adc/stmpe-adc.c
> > @@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
> > /* Read value */
> > stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2,
> > (u8 *) &data);
> > + } else {
> > + return IRQ_NONE;
> > }
> >
> > info->value = (u32) be16_to_cpu(data);
> > --
> > 2.20.0
> >
>
> I sent a similar patch, which is sitting in Jonathan's testing branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=e15146e4d4349b3f309f5591ea8de8d24071265f
Ok, sorry for the dup. Your seems to be better than mine, too.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-22 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:08 [PATCH] iio: stmpe-adc: avoid harmless clang warning Arnd Bergmann
2019-03-22 14:08 ` Arnd Bergmann
2019-03-22 14:58 ` Nathan Chancellor
2019-03-22 14:58 ` Nathan Chancellor
2019-03-22 15:09 ` Arnd Bergmann [this message]
2019-03-22 15:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1k96x_vqjCWU9Dmj3N7arpD3LLY1Tx3NLwciG-q26hzg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=max.krummenacher@toradex.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.