From: Arnd Bergmann <arnd@arndb.de>
To: Vishnu Dasa <vdasa@vmware.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Pv-drivers <Pv-drivers@vmware.com>,
linux-kernel-review list
<linux-kernel-review@mailman2.vmware.com>,
Cyprien Laplace <claplace@vmware.com>,
Bryan Tan <bryantan@vmware.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] VMCI: Add support for ARM64
Date: Wed, 11 May 2022 22:02:43 +0200 [thread overview]
Message-ID: <CAK8P3a1yCBO5fJ8pacxVd4Umjt0Qy7wfgwZNkqqYMKjofZFvLQ@mail.gmail.com> (raw)
In-Reply-To: <245F4717-CF83-40BC-BC87-5EB8563E0588@vmware.com>
On Wed, May 11, 2022 at 9:54 PM Vishnu Dasa <vdasa@vmware.com> wrote:
>
>
> > FWIW, it seems you're doing three things at once, better split this into
> > a 3-patch series.
>
> Thanks for the feedback. I was debating between the two ways of doing
> it and ultimately did it one way. It is a bit late now to change it as it has
> made its way to linux-next already.
It's really ok either way here. While there are clearly multiple changes in the
source file, they are all trivial, and the Kconfig change doesn't make sense
without the other changes, so having a combined patch seems totally
reasonable as well.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Vishnu Dasa <vdasa@vmware.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Pv-drivers <Pv-drivers@vmware.com>,
linux-kernel-review list
<linux-kernel-review@mailman2.vmware.com>,
Cyprien Laplace <claplace@vmware.com>,
Bryan Tan <bryantan@vmware.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] VMCI: Add support for ARM64
Date: Wed, 11 May 2022 22:02:43 +0200 [thread overview]
Message-ID: <CAK8P3a1yCBO5fJ8pacxVd4Umjt0Qy7wfgwZNkqqYMKjofZFvLQ@mail.gmail.com> (raw)
In-Reply-To: <245F4717-CF83-40BC-BC87-5EB8563E0588@vmware.com>
On Wed, May 11, 2022 at 9:54 PM Vishnu Dasa <vdasa@vmware.com> wrote:
>
>
> > FWIW, it seems you're doing three things at once, better split this into
> > a 3-patch series.
>
> Thanks for the feedback. I was debating between the two ways of doing
> it and ultimately did it one way. It is a bit late now to change it as it has
> made its way to linux-next already.
It's really ok either way here. While there are clearly multiple changes in the
source file, they are all trivial, and the Kconfig change doesn't make sense
without the other changes, so having a combined patch seems totally
reasonable as well.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Vishnu Dasa <vdasa@vmware.com>
Cc: Pv-drivers <Pv-drivers@vmware.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
linux-kernel-review list
<linux-kernel-review@mailman2.vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Bryan Tan <bryantan@vmware.com>,
Cyprien Laplace <claplace@vmware.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] VMCI: Add support for ARM64
Date: Wed, 11 May 2022 22:02:43 +0200 [thread overview]
Message-ID: <CAK8P3a1yCBO5fJ8pacxVd4Umjt0Qy7wfgwZNkqqYMKjofZFvLQ@mail.gmail.com> (raw)
In-Reply-To: <245F4717-CF83-40BC-BC87-5EB8563E0588@vmware.com>
On Wed, May 11, 2022 at 9:54 PM Vishnu Dasa <vdasa@vmware.com> wrote:
>
>
> > FWIW, it seems you're doing three things at once, better split this into
> > a 3-patch series.
>
> Thanks for the feedback. I was debating between the two ways of doing
> it and ultimately did it one way. It is a bit late now to change it as it has
> made its way to linux-next already.
It's really ok either way here. While there are clearly multiple changes in the
source file, they are all trivial, and the Kconfig change doesn't make sense
without the other changes, so having a combined patch seems totally
reasonable as well.
Arnd
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-11 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 19:33 [PATCH] VMCI: Add support for ARM64 vdasa
2022-04-14 19:33 ` vdasa
2022-04-14 19:33 ` vdasa
2022-05-06 14:13 ` Vitaly Kuznetsov
2022-05-06 14:13 ` Vitaly Kuznetsov
2022-05-06 14:13 ` Vitaly Kuznetsov
2022-05-11 19:54 ` Vishnu Dasa
2022-05-11 19:54 ` Vishnu Dasa
2022-05-11 19:54 ` Vishnu Dasa
2022-05-11 20:02 ` Arnd Bergmann [this message]
2022-05-11 20:02 ` Arnd Bergmann
2022-05-11 20:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1yCBO5fJ8pacxVd4Umjt0Qy7wfgwZNkqqYMKjofZFvLQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=Pv-drivers@vmware.com \
--cc=bryantan@vmware.com \
--cc=claplace@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-review@mailman2.vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vdasa@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.