All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: arm-soc <arm@kernel.org>, SoC Team <soc@kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: defconfig: gemini: Update defconfig
Date: Tue, 13 Apr 2021 11:17:31 +0200	[thread overview]
Message-ID: <CAK8P3a1yKNF9NkRZNKtySjFKZ2WzLKrk0B+XkcmH3A=awi6C7g@mail.gmail.com> (raw)
In-Reply-To: <20210412134700.1977619-1-linus.walleij@linaro.org>

On Mon, Apr 12, 2021 at 3:47 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Update the Gemini defconfig: some moved options, added som
> WLAN drivers existing on the supported platforms and enabled
> the drivetemp sensor which is used on the NAS devices.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I don't like patches that mix functional changes with what comes down
to whitespace. Can you resend this one as a series?

At the minimum, make one patch that adds BFQ, DRIVETEMP
and WLAN changes and another one that moves options
around that change after 'savedefconfig'.

For the CONFIG_ENABLE_MUST_CHECK removal, can you
send a patch that removes this line from all defconfig files at once?

      Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: arm-soc <arm@kernel.org>, SoC Team <soc@kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: defconfig: gemini: Update defconfig
Date: Tue, 13 Apr 2021 11:17:31 +0200	[thread overview]
Message-ID: <CAK8P3a1yKNF9NkRZNKtySjFKZ2WzLKrk0B+XkcmH3A=awi6C7g@mail.gmail.com> (raw)
Message-ID: <20210413091731.uYwHeqs8v_gWjSxKDH_zvLEWfUt_WNEycEyC1hN26yA@z> (raw)
In-Reply-To: <20210412134700.1977619-1-linus.walleij@linaro.org>

On Mon, Apr 12, 2021 at 3:47 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Update the Gemini defconfig: some moved options, added som
> WLAN drivers existing on the supported platforms and enabled
> the drivetemp sensor which is used on the NAS devices.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I don't like patches that mix functional changes with what comes down
to whitespace. Can you resend this one as a series?

At the minimum, make one patch that adds BFQ, DRIVETEMP
and WLAN changes and another one that moves options
around that change after 'savedefconfig'.

For the CONFIG_ENABLE_MUST_CHECK removal, can you
send a patch that removes this line from all defconfig files at once?

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-13  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 13:47 [PATCH] ARM: defconfig: gemini: Update defconfig Linus Walleij
2021-04-12 13:47 ` Linus Walleij
2021-04-13  9:17 ` Arnd Bergmann [this message]
2021-04-13  9:17   ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2020-01-01 14:35 Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1yKNF9NkRZNKtySjFKZ2WzLKrk0B+XkcmH3A=awi6C7g@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.