From: Anup Patel <apatel@ventanamicro.com> To: Palmer Dabbelt <palmer@dabbelt.com> Cc: mail@conchuod.ie, anup@brainfault.org, atishp@atishpatra.org, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, conor.dooley@microchip.com, guoren@kernel.org, vincent.chen@sifive.com, xianting.tian@linux.alibaba.com, heiko@sntech.de, wangkefeng.wang@huawei.com, tongtiangen@huawei.com, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] misc warning cleanup in arch/risc-v Date: Fri, 19 Aug 2022 21:44:32 +0530 [thread overview] Message-ID: <CAK9=C2UGJgu0eXHARkvftf+xbqnTaK2k9Jbz_4WVS8PQpgtaWg@mail.gmail.com> (raw) In-Reply-To: <mhng-49e49c17-7241-45f8-bea3-17188bd1d0fa@palmer-ri-x1c9> On Fri, Aug 19, 2022 at 4:32 AM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > On Sun, 14 Aug 2022 07:12:34 PDT (-0700), mail@conchuod.ie wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > Hey all, > > Couple fixes here for most of what's left of the {sparse,} warnings in > > arch/riscv that are still in need of patches. Ben has sent patches > > for the VDSO issue already (although they seem to need rework). > > > > VDSO aside, With this patchset applied, we are left with: > > - cpuinfo_ops missing prototype: this likely needs to go into an > > asm-generic header & I'll send a separate patch for that. > > - Complaints about an error in mm/init.c: > > "error inarch/riscv/mm/init.c:819:2: error: "setup_vm() is <trunc> > > I think this can be ignored. > > - 600+ -Woverride-init warnings for syscall table setup where > > overriding seems to be the whole point of the macro. > > - Warnings about imported kvm core code. > > - Flexible array member warnings that look like common KVM code > > patterns > > - An unexpected unlock in kvm_riscv_check_vcpu_requests that was added > > intentionally: > > https://lore.kernel.org/all/20220710151105.687193-1-apatel@ventanamicro.com/ > > Is it worth looking into whether that's a false positive or not? > > > > Thanks, > > Conor. > > > > Conor Dooley (4): > > riscv: kvm: vcpu_timer: fix unused variable warnings > > riscv: kvm: move extern sbi_ext declarations to a header > > riscv: signal: fix missing prototype warning > > riscv: traps: add missing prototype > > > > arch/riscv/include/asm/kvm_vcpu_sbi.h | 12 ++++++++++++ > > arch/riscv/include/asm/signal.h | 12 ++++++++++++ > > arch/riscv/include/asm/thread_info.h | 2 ++ > > arch/riscv/kernel/signal.c | 1 + > > arch/riscv/kernel/traps.c | 3 ++- > > arch/riscv/kvm/vcpu_sbi.c | 12 +----------- > > arch/riscv/kvm/vcpu_timer.c | 4 ---- > > 7 files changed, 30 insertions(+), 16 deletions(-) > > create mode 100644 arch/riscv/include/asm/signal.h > > These generally look good to me. Anup handles the KVM bits so I'll let > him chime in there, but > > Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > on all of them. > > Happy to do some sort of shared tag thing, but it looks like these are > all independent enough that it'd be easier to just split them up. I've > put the non-KVM bits over at palmer/riscv-variable_fixes_without_kvm, if > you guys are all OK splitting this up then I'll go take those onto > riscv/fixes. I'll wait a bit for folks to get a chance to look, so it > won't be for tomorrow morning. Thanks Palmer. I have queued the KVM fixes (first two patches). Regards, Anup > > Thanks! > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <apatel@ventanamicro.com> To: Palmer Dabbelt <palmer@dabbelt.com> Cc: mail@conchuod.ie, anup@brainfault.org, atishp@atishpatra.org, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, conor.dooley@microchip.com, guoren@kernel.org, vincent.chen@sifive.com, xianting.tian@linux.alibaba.com, heiko@sntech.de, wangkefeng.wang@huawei.com, tongtiangen@huawei.com, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] misc warning cleanup in arch/risc-v Date: Fri, 19 Aug 2022 21:44:32 +0530 [thread overview] Message-ID: <CAK9=C2UGJgu0eXHARkvftf+xbqnTaK2k9Jbz_4WVS8PQpgtaWg@mail.gmail.com> (raw) In-Reply-To: <mhng-49e49c17-7241-45f8-bea3-17188bd1d0fa@palmer-ri-x1c9> On Fri, Aug 19, 2022 at 4:32 AM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > On Sun, 14 Aug 2022 07:12:34 PDT (-0700), mail@conchuod.ie wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > Hey all, > > Couple fixes here for most of what's left of the {sparse,} warnings in > > arch/riscv that are still in need of patches. Ben has sent patches > > for the VDSO issue already (although they seem to need rework). > > > > VDSO aside, With this patchset applied, we are left with: > > - cpuinfo_ops missing prototype: this likely needs to go into an > > asm-generic header & I'll send a separate patch for that. > > - Complaints about an error in mm/init.c: > > "error inarch/riscv/mm/init.c:819:2: error: "setup_vm() is <trunc> > > I think this can be ignored. > > - 600+ -Woverride-init warnings for syscall table setup where > > overriding seems to be the whole point of the macro. > > - Warnings about imported kvm core code. > > - Flexible array member warnings that look like common KVM code > > patterns > > - An unexpected unlock in kvm_riscv_check_vcpu_requests that was added > > intentionally: > > https://lore.kernel.org/all/20220710151105.687193-1-apatel@ventanamicro.com/ > > Is it worth looking into whether that's a false positive or not? > > > > Thanks, > > Conor. > > > > Conor Dooley (4): > > riscv: kvm: vcpu_timer: fix unused variable warnings > > riscv: kvm: move extern sbi_ext declarations to a header > > riscv: signal: fix missing prototype warning > > riscv: traps: add missing prototype > > > > arch/riscv/include/asm/kvm_vcpu_sbi.h | 12 ++++++++++++ > > arch/riscv/include/asm/signal.h | 12 ++++++++++++ > > arch/riscv/include/asm/thread_info.h | 2 ++ > > arch/riscv/kernel/signal.c | 1 + > > arch/riscv/kernel/traps.c | 3 ++- > > arch/riscv/kvm/vcpu_sbi.c | 12 +----------- > > arch/riscv/kvm/vcpu_timer.c | 4 ---- > > 7 files changed, 30 insertions(+), 16 deletions(-) > > create mode 100644 arch/riscv/include/asm/signal.h > > These generally look good to me. Anup handles the KVM bits so I'll let > him chime in there, but > > Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > on all of them. > > Happy to do some sort of shared tag thing, but it looks like these are > all independent enough that it'd be easier to just split them up. I've > put the non-KVM bits over at palmer/riscv-variable_fixes_without_kvm, if > you guys are all OK splitting this up then I'll go take those onto > riscv/fixes. I'll wait a bit for folks to get a chance to look, so it > won't be for tomorrow morning. Thanks Palmer. I have queued the KVM fixes (first two patches). Regards, Anup > > Thanks! > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv
next prev parent reply other threads:[~2022-08-19 16:15 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-14 14:12 [PATCH 0/4] misc warning cleanup in arch/risc-v Conor Dooley 2022-08-14 14:12 ` Conor Dooley 2022-08-14 14:12 ` [PATCH 1/4] riscv: kvm: vcpu_timer: fix unused variable warnings Conor Dooley 2022-08-14 14:12 ` Conor Dooley 2022-08-19 16:11 ` Anup Patel 2022-08-19 16:11 ` Anup Patel 2022-08-19 20:09 ` Atish Patra 2022-08-19 20:09 ` Atish Patra 2022-08-14 14:12 ` [PATCH 2/4] riscv: kvm: move extern sbi_ext declarations to a header Conor Dooley 2022-08-14 14:12 ` Conor Dooley 2022-08-19 16:12 ` Anup Patel 2022-08-19 16:12 ` Anup Patel 2022-08-14 14:12 ` [PATCH 3/4] riscv: signal: fix missing prototype warning Conor Dooley 2022-08-14 14:12 ` Conor Dooley 2022-08-14 14:12 ` [PATCH 4/4] riscv: traps: add missing prototype Conor Dooley 2022-08-14 14:12 ` Conor Dooley 2022-08-18 23:01 ` [PATCH 0/4] misc warning cleanup in arch/risc-v Palmer Dabbelt 2022-08-18 23:01 ` Palmer Dabbelt 2022-08-19 11:34 ` Conor.Dooley 2022-08-19 11:34 ` Conor.Dooley 2022-08-19 16:14 ` Anup Patel [this message] 2022-08-19 16:14 ` Anup Patel 2022-08-25 23:42 ` Palmer Dabbelt 2022-08-25 23:42 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK9=C2UGJgu0eXHARkvftf+xbqnTaK2k9Jbz_4WVS8PQpgtaWg@mail.gmail.com' \ --to=apatel@ventanamicro.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atishp@atishpatra.org \ --cc=conor.dooley@microchip.com \ --cc=guoren@kernel.org \ --cc=heiko@sntech.de \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mail@conchuod.ie \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=tongtiangen@huawei.com \ --cc=vincent.chen@sifive.com \ --cc=wangkefeng.wang@huawei.com \ --cc=xianting.tian@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.