From: Sachin Kamat <sachin.kamat@linaro.org>
To: Olof Johansson <olof@lixom.net>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver
Date: Thu, 24 Oct 2013 21:12:09 +0530 [thread overview]
Message-ID: <CAK9yfHxaLsdFGXiCxvs+HpMSuY6xWd=CGPv-YfSkJqWSxE+f-w@mail.gmail.com> (raw)
In-Reply-To: <CAOesGMhwotSY-1WQmt+wtsrsH2m30VE=j-MwyhpYU3mt_PSPPw@mail.gmail.com>
Hi Olof,
On 24 October 2013 20:00, Olof Johansson <olof@lixom.net> wrote:
> Hi Kishon,
>
> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
>> index 32e5406..00b3a52 100644
>> --- a/drivers/video/exynos/exynos_mipi_dsi.c
>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power)
>> exynos_mipi_regulator_enable(dsim);
>>
>> /* enable MIPI-DSI PHY. */
>> - if (dsim->pd->phy_enable)
>> - dsim->pd->phy_enable(pdev, true);
>> + phy_power_on(dsim->phy);
>>
>> clk_enable(dsim->clock);
>>
>
> This introduces the below with exynos_defconfig:
>
> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function
> 'exynos_mipi_dsi_blank_mode':
> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused
> variable 'pdev' [-Wunused-variable]
> struct platform_device *pdev = to_platform_device(dsim->dev);
>
I have already submitted a patch to fix this [1]
[1] http://marc.info/?l=linux-fbdev&m=138233359617936&w=2
--
With warm regards,
Sachin
WARNING: multiple messages have this Message-ID (diff)
From: Sachin Kamat <sachin.kamat@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver
Date: Thu, 24 Oct 2013 15:54:09 +0000 [thread overview]
Message-ID: <CAK9yfHxaLsdFGXiCxvs+HpMSuY6xWd=CGPv-YfSkJqWSxE+f-w@mail.gmail.com> (raw)
In-Reply-To: <CAOesGMhwotSY-1WQmt+wtsrsH2m30VE=j-MwyhpYU3mt_PSPPw@mail.gmail.com>
Hi Olof,
On 24 October 2013 20:00, Olof Johansson <olof@lixom.net> wrote:
> Hi Kishon,
>
> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
>> index 32e5406..00b3a52 100644
>> --- a/drivers/video/exynos/exynos_mipi_dsi.c
>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power)
>> exynos_mipi_regulator_enable(dsim);
>>
>> /* enable MIPI-DSI PHY. */
>> - if (dsim->pd->phy_enable)
>> - dsim->pd->phy_enable(pdev, true);
>> + phy_power_on(dsim->phy);
>>
>> clk_enable(dsim->clock);
>>
>
> This introduces the below with exynos_defconfig:
>
> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function
> 'exynos_mipi_dsi_blank_mode':
> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused
> variable 'pdev' [-Wunused-variable]
> struct platform_device *pdev = to_platform_device(dsim->dev);
>
I have already submitted a patch to fix this [1]
[1] http://marc.info/?l=linux-fbdev&m\x138233359617936&w=2
--
With warm regards,
Sachin
WARNING: multiple messages have this Message-ID (diff)
From: sachin.kamat@linaro.org (Sachin Kamat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver
Date: Thu, 24 Oct 2013 21:12:09 +0530 [thread overview]
Message-ID: <CAK9yfHxaLsdFGXiCxvs+HpMSuY6xWd=CGPv-YfSkJqWSxE+f-w@mail.gmail.com> (raw)
In-Reply-To: <CAOesGMhwotSY-1WQmt+wtsrsH2m30VE=j-MwyhpYU3mt_PSPPw@mail.gmail.com>
Hi Olof,
On 24 October 2013 20:00, Olof Johansson <olof@lixom.net> wrote:
> Hi Kishon,
>
> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
>> index 32e5406..00b3a52 100644
>> --- a/drivers/video/exynos/exynos_mipi_dsi.c
>> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
>> @@ -156,8 +157,7 @@ static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power)
>> exynos_mipi_regulator_enable(dsim);
>>
>> /* enable MIPI-DSI PHY. */
>> - if (dsim->pd->phy_enable)
>> - dsim->pd->phy_enable(pdev, true);
>> + phy_power_on(dsim->phy);
>>
>> clk_enable(dsim->clock);
>>
>
> This introduces the below with exynos_defconfig:
>
> ../../drivers/video/exynos/exynos_mipi_dsi.c: In function
> 'exynos_mipi_dsi_blank_mode':
> ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused
> variable 'pdev' [-Wunused-variable]
> struct platform_device *pdev = to_platform_device(dsim->dev);
>
I have already submitted a patch to fix this [1]
[1] http://marc.info/?l=linux-fbdev&m=138233359617936&w=2
--
With warm regards,
Sachin
next prev parent reply other threads:[~2013-10-24 15:42 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:28 [PATCH 0/7] video phy's adaptation to *generic phy framework* Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 1/7] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 2/7] exynos4-is: Use the generic MIPI CSIS PHY driver Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 3/7] video: exynos_mipi_dsim: Use the generic " Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-24 14:30 ` Olof Johansson
2013-10-24 14:30 ` Olof Johansson
2013-10-24 14:30 ` Olof Johansson
2013-10-24 15:27 ` [PATCH] drivers: video: exynos: Fix compiler Warning Kishon Vijay Abraham I
2013-10-24 15:39 ` Kishon Vijay Abraham I
2013-10-24 15:27 ` Kishon Vijay Abraham I
2013-10-24 15:27 ` Kishon Vijay Abraham I
2013-10-24 15:31 ` Felipe Balbi
2013-10-24 15:31 ` Felipe Balbi
2013-10-24 15:31 ` Felipe Balbi
2013-10-24 15:31 ` Felipe Balbi
2013-10-24 15:42 ` Sachin Kamat [this message]
2013-10-24 15:54 ` [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver Sachin Kamat
2013-10-24 15:42 ` Sachin Kamat
2013-10-24 15:57 ` Kishon Vijay Abraham I
2013-10-24 15:57 ` Kishon Vijay Abraham I
2013-10-24 15:57 ` Kishon Vijay Abraham I
2013-10-24 15:57 ` Kishon Vijay Abraham I
2013-10-24 21:57 ` Sylwester Nawrocki
2013-10-24 21:57 ` Sylwester Nawrocki
2013-10-24 21:57 ` Sylwester Nawrocki
2013-10-28 6:12 ` Donghwa Lee
2013-10-28 6:12 ` Donghwa Lee
2013-10-28 6:12 ` Donghwa Lee
2013-10-28 12:24 ` Tomasz Figa
2013-10-28 12:24 ` Tomasz Figa
2013-10-28 12:24 ` Tomasz Figa
2013-10-29 8:38 ` Donghwa Lee
2013-10-29 8:38 ` Donghwa Lee
2013-10-29 8:38 ` Donghwa Lee
2013-10-30 0:43 ` Sylwester Nawrocki
2013-10-30 0:43 ` Sylwester Nawrocki
2013-10-30 0:43 ` Sylwester Nawrocki
2013-10-24 17:06 ` Olof Johansson
2013-10-24 17:06 ` Olof Johansson
2013-10-24 17:06 ` Olof Johansson
2013-10-16 16:28 ` [PATCH 4/7] ARM: Samsung: Remove the MIPI PHY setup code Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 5/7] phy: Add driver for Exynos DP PHY Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-24 15:13 ` Tomasz Stanislawski
2013-10-24 15:13 ` Tomasz Stanislawski
2013-10-24 15:13 ` Tomasz Stanislawski
2013-10-16 16:28 ` [PATCH 6/7] video: exynos_dp: remove non-DT support for Exynos Display Port Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 7/7] video: exynos_dp: Use the generic PHY driver Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 17:03 ` [PATCH] phy: exynos-mipi-video: Fix phy_power_off() callback Sylwester Nawrocki
2013-10-16 17:03 ` Sylwester Nawrocki
2013-10-16 23:10 ` Jingoo Han
2013-10-16 23:10 ` Jingoo Han
2013-10-18 5:31 ` Kishon Vijay Abraham I
2013-10-18 5:31 ` Kishon Vijay Abraham I
2013-10-16 20:49 ` [PATCH 0/7] video phy's adaptation to *generic phy framework* Greg KH
2013-10-16 20:49 ` Greg KH
2013-10-16 20:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK9yfHxaLsdFGXiCxvs+HpMSuY6xWd=CGPv-YfSkJqWSxE+f-w@mail.gmail.com' \
--to=sachin.kamat@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.