From: Willian Rampazzo <wrampazz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings
Date: Mon, 29 Mar 2021 12:39:45 -0300 [thread overview]
Message-ID: <CAKJDGDY_xqos+nCL7cCvXD+iXqd4ZtZ5jBLdsizuNufYT12NCA@mail.gmail.com> (raw)
In-Reply-To: <20210329132632.68901-4-mreitz@redhat.com>
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz <mreitz@redhat.com> wrote:
>
> There are a couple of things pylint takes issue with:
> - The "time" import is unused
> - The import order (iotests should come last)
> - get_bitmap_hash() doesn't use @self and so should be a function
> - Semicolons at the end of some lines
> - Parentheses after "if"
> - Some lines are too long (80 characters instead of 79)
> - inject_test_case()'s @name parameter shadows a top-level @name
> variable
> - "lambda self: mc(self)" is equivalent to just "mc"
> - Always put two empty lines after a function
> - f'exec: cat > /dev/null' does not need to be an f-string
>
> Fix them.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++++++++++---------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
next prev parent reply other threads:[~2021-03-29 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 13:26 [PATCH 0/4] iotests/297: Cover tests/ Max Reitz
2021-03-29 13:26 ` [PATCH 1/4] iotests/297: Drop 169 and 199 from the skip list Max Reitz
2021-03-29 15:35 ` Willian Rampazzo
2021-03-30 16:42 ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings Max Reitz
2021-03-29 15:36 ` Willian Rampazzo
2021-03-30 16:47 ` Vladimir Sementsov-Ogievskiy
2021-03-30 17:18 ` Max Reitz
2021-03-30 17:36 ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 3/4] migrate-bitmaps-test: " Max Reitz
2021-03-29 15:39 ` Willian Rampazzo [this message]
2021-03-30 16:55 ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 4/4] iotests/297: Cover tests/ Max Reitz
2021-03-29 15:40 ` Willian Rampazzo
2021-03-30 17:00 ` Vladimir Sementsov-Ogievskiy
2021-04-07 16:50 ` [PATCH 0/4] " Kevin Wolf
2021-05-05 8:02 ` Vladimir Sementsov-Ogievskiy
2021-05-12 17:39 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKJDGDY_xqos+nCL7cCvXD+iXqd4ZtZ5jBLdsizuNufYT12NCA@mail.gmail.com \
--to=wrampazz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.