All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 0/4] iotests/297: Cover tests/
Date: Wed, 7 Apr 2021 18:50:52 +0200	[thread overview]
Message-ID: <YG3i7ECFtLJ7tINA@merkur.fritz.box> (raw)
In-Reply-To: <20210329132632.68901-1-mreitz@redhat.com>

Am 29.03.2021 um 15:26 hat Max Reitz geschrieben:
> Hi,
> 
> When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
> far does not cover named tests.  That isn’t so good.
> 
> This series makes it cover them, and because tests/ is rather sparse at
> this point, I decided to also fix up the two tests in there that don’t
> pass pylint’s scrutiny yet.  I think it would be nice if we could keep
> all of tests/ clean.

For patch 2, Vladimir already made the point I would have made.

For the rest:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>



  parent reply	other threads:[~2021-04-07 16:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 13:26 [PATCH 0/4] iotests/297: Cover tests/ Max Reitz
2021-03-29 13:26 ` [PATCH 1/4] iotests/297: Drop 169 and 199 from the skip list Max Reitz
2021-03-29 15:35   ` Willian Rampazzo
2021-03-30 16:42   ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings Max Reitz
2021-03-29 15:36   ` Willian Rampazzo
2021-03-30 16:47   ` Vladimir Sementsov-Ogievskiy
2021-03-30 17:18     ` Max Reitz
2021-03-30 17:36       ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 3/4] migrate-bitmaps-test: " Max Reitz
2021-03-29 15:39   ` Willian Rampazzo
2021-03-30 16:55   ` Vladimir Sementsov-Ogievskiy
2021-03-29 13:26 ` [PATCH 4/4] iotests/297: Cover tests/ Max Reitz
2021-03-29 15:40   ` Willian Rampazzo
2021-03-30 17:00   ` Vladimir Sementsov-Ogievskiy
2021-04-07 16:50 ` Kevin Wolf [this message]
2021-05-05  8:02 ` [PATCH 0/4] " Vladimir Sementsov-Ogievskiy
2021-05-12 17:39   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG3i7ECFtLJ7tINA@merkur.fritz.box \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.