From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: clear up wedged transitions
Date: Wed, 5 Dec 2012 18:14:16 +0100 [thread overview]
Message-ID: <CAKMK7uGbuH4pcUt2bhZjQ+bGC5ZS06GZ9cLDyigdNt31Jn8irQ@mail.gmail.com> (raw)
In-Reply-To: <CAPX-8+-xbxDJeh9NrwL=AejuXXph1=e=zk3KTW7Hi8Y92dePOg@mail.gmail.com>
On Wed, Dec 5, 2012 at 5:38 PM, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Thu, Nov 15, 2012 at 4:17 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1596,7 +1596,7 @@ i915_wedged_read(struct file *filp,
>>
>> len = snprintf(buf, sizeof(buf),
>> "wedged : %d\n",
>> - atomic_read(&dev_priv->gpu_error.wedged));
>> + atomic_read(&dev_priv->gpu_error.reset_counter));
>
> I was wondering if you might want to expose wedge as
> (gpu_error.reset_counter == I915_WEDGED) and have a separate
> reset_counter set to (gpu_error.reset_counter >> 1)
Other interfaces are equally raw in debugfs, so I've figured this is
good enough ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-12-05 17:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 16:14 [PATCH 0/6] robustify reset transitions Daniel Vetter
2012-11-14 16:14 ` [PATCH 1/6] drm/i915: move dev_priv->mm out of line Daniel Vetter
2012-12-04 16:31 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 2/6] drm/i915: extract hangcheck/reset/error_state state into substruct Daniel Vetter
2012-12-04 17:20 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 3/6] drm/i915: move wedged to the other gpu error handling stuff Daniel Vetter
2012-12-04 17:24 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 4/6] drm/i915: fix reset handling in the throttle ioctl Daniel Vetter
2012-12-05 14:08 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 5/6] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-14 16:14 ` [PATCH 6/6] drm/i915: create a race-free reset detection Daniel Vetter
2012-11-15 16:17 ` [PATCH 1/2] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-15 16:17 ` [PATCH 2/2] drm/i915: create a race-free reset detection Daniel Vetter
2012-12-05 16:35 ` Damien Lespiau
2012-12-06 8:01 ` [PATCH] " Daniel Vetter
2012-12-06 15:23 ` [PATCH] drm/i915: clarify concurrent hang detect/gpu reset consistency Daniel Vetter
2013-01-18 20:48 ` [PATCH 2/2] drm/i915: create a race-free reset detection Daniel Vetter
2013-01-21 12:06 ` Damien Lespiau
2013-01-21 19:15 ` Daniel Vetter
2012-12-05 14:54 ` [PATCH 1/2] drm/i915: clear up wedged transitions Damien Lespiau
2012-12-05 16:38 ` Damien Lespiau
2012-12-05 17:14 ` Daniel Vetter [this message]
2014-09-03 20:26 ` Chris Wilson
2014-09-04 6:03 ` Daniel Vetter
2014-09-04 6:11 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uGbuH4pcUt2bhZjQ+bGC5ZS06GZ9cLDyigdNt31Jn8irQ@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.