From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/6] drm/i915: fix reset handling in the throttle ioctl
Date: Wed, 5 Dec 2012 14:08:29 +0000 [thread overview]
Message-ID: <CAPX-8+__SZdUKQqddjpuUnNC8cOC2pqyhof4mqX2chdGobaj0Q@mail.gmail.com> (raw)
In-Reply-To: <1352909648-21514-5-git-send-email-daniel.vetter@ffwll.ch>
On Wed, Nov 14, 2012 at 4:14 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The throttle ioctl doesn't take the struct_mutex, so to avoid busy-looping
> with -EAGAIN while a reset is in process, check for errors first and wait
> for the handler to complete if a reset is pending by calling
> i915_gem_wait_for_error.
The code looks like it does the right thing (wait for the completion
first and then call check_wedge()), but here the commit message states
that it check for errors first and then wait for the completion?
Other than that:
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
next prev parent reply other threads:[~2012-12-05 14:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 16:14 [PATCH 0/6] robustify reset transitions Daniel Vetter
2012-11-14 16:14 ` [PATCH 1/6] drm/i915: move dev_priv->mm out of line Daniel Vetter
2012-12-04 16:31 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 2/6] drm/i915: extract hangcheck/reset/error_state state into substruct Daniel Vetter
2012-12-04 17:20 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 3/6] drm/i915: move wedged to the other gpu error handling stuff Daniel Vetter
2012-12-04 17:24 ` Damien Lespiau
2012-11-14 16:14 ` [PATCH 4/6] drm/i915: fix reset handling in the throttle ioctl Daniel Vetter
2012-12-05 14:08 ` Damien Lespiau [this message]
2012-11-14 16:14 ` [PATCH 5/6] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-14 16:14 ` [PATCH 6/6] drm/i915: create a race-free reset detection Daniel Vetter
2012-11-15 16:17 ` [PATCH 1/2] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-15 16:17 ` [PATCH 2/2] drm/i915: create a race-free reset detection Daniel Vetter
2012-12-05 16:35 ` Damien Lespiau
2012-12-06 8:01 ` [PATCH] " Daniel Vetter
2012-12-06 15:23 ` [PATCH] drm/i915: clarify concurrent hang detect/gpu reset consistency Daniel Vetter
2013-01-18 20:48 ` [PATCH 2/2] drm/i915: create a race-free reset detection Daniel Vetter
2013-01-21 12:06 ` Damien Lespiau
2013-01-21 19:15 ` Daniel Vetter
2012-12-05 14:54 ` [PATCH 1/2] drm/i915: clear up wedged transitions Damien Lespiau
2012-12-05 16:38 ` Damien Lespiau
2012-12-05 17:14 ` Daniel Vetter
2014-09-03 20:26 ` Chris Wilson
2014-09-04 6:03 ` Daniel Vetter
2014-09-04 6:11 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPX-8+__SZdUKQqddjpuUnNC8cOC2pqyhof4mqX2chdGobaj0Q@mail.gmail.com \
--to=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.