From: Alistair Francis <alistair23@gmail.com> To: Andreas Kemnade <andreas@kemnade.info> Cc: Alistair Francis <alistair@alistair23.me>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, lgirdwood@gmail.com, Rob Herring <robh+dt@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, rui.zhang@intel.com, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Sascha Hauer <s.hauer@pengutronix.de>, linux-hwmon@vger.kernel.org, amitk@kernel.org, linux-pm@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>, Shawn Guo <shawnguo@kernel.org> Subject: Re: [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Date: Tue, 23 Nov 2021 22:14:18 +1000 [thread overview] Message-ID: <CAKmqyKPFOqWD7t6tC1Act97CVcY+yazrhwMLLr3j_wOyH50GTA@mail.gmail.com> (raw) In-Reply-To: <20211116000634.767dcdc0@aktux> On Tue, Nov 16, 2021 at 9:10 AM Andreas Kemnade <andreas@kemnade.info> wrote: > > Hi, > > this all creates a lot of question marks... > One of my main question is whether sy7636a = sy7636 (at least the > driver in the kobo vendor kernels does not have the "A" at the end, > whic does not necessarily mean a difference). > > https://www.silergy.com/products/panel_pmic > lists only a SY7636ARMC, so chances are good that the letters were just > stripped away by the driver developers. Printing on chip package is > cryptic so it is not that helpful. It is just "BWNBDA" I don't have a definite answer for you. But I think it's sy7636a The page you linked to above lists SY7636ARMC as well as SY7627RMC, SY7570RMC. That makes me think that the RMC is a generic suffix and this actual IC is the SY7636A. > > On Wed, 10 Nov 2021 22:29:43 +1000 > Alistair Francis <alistair@alistair23.me> wrote: > > [...] > > diff --git a/include/linux/mfd/sy7636a.h b/include/linux/mfd/sy7636a.h > > new file mode 100644 > > index 000000000000..2797c22dabc2 > > --- /dev/null > > +++ b/include/linux/mfd/sy7636a.h > > @@ -0,0 +1,36 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Functions to access SY3686A power management chip. > > Typo? or is it really a SY3686A? So what we are talking about? I think it's SY7636A > > > + * > > + * Copyright (C) 2021 reMarkable AS - http://www.remarkable.com/ > > + */ > > + > > +#ifndef __MFD_SY7636A_H > > +#define __MFD_SY7636A_H > > + > > +#define SY7636A_REG_OPERATION_MODE_CRL 0x00 > > +#define SY7636A_OPERATION_MODE_CRL_VCOMCTL BIT(6) > > hmm, this thing is called VCOM_MANUAL in the 4.1.15-based driver for the > Kobos and in the 3.0.35 kernel for the Tolinos it is: > > // 1:controll the vcom by external VCOM_EN pin > #define SY7636_REG_OPM_VCOM_EXT_mask 0x1 // > #define SY7636_REG_OPM_VCOM_EXT_lsb 6 // > > In both kernels, it is set if a gpio is used to control the regulator. > That does not necessarily conflict with your usage. The gpio might just > be hardwired to something in your device. Maybe just a comment about > that issue. Ok, I'll add a comment. > > > +#define SY7636A_OPERATION_MODE_CRL_ONOFF BIT(7) > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_L 0x01 > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_H 0x02 > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_MASK 0x01ff > > +#define SY7636A_REG_VLDO_VOLTAGE_ADJULST_CTRL 0x03 > > +#define SY7636A_REG_POWER_ON_DELAY_TIME 0x06 > > +#define SY7636A_REG_FAULT_FLAG 0x07 > > +#define SY7636A_FAULT_FLAG_PG BIT(0) > > +#define SY7636A_REG_TERMISTOR_READOUT 0x08 > > + > > +#define SY7636A_REG_MAX 0x08 > > + > > +#define VCOM_MIN 0 > > +#define VCOM_MAX 5000 > > hmm, what does that maximum mean? What you can set without something > freaking out just by setting it? Or the limit where the driver works > reliably? Good question. This is unused so I have just removed it. > > + > > +#define VCOM_ADJUST_CTRL_MASK 0x1ff > > +// Used to shift the high byte > > +#define VCOM_ADJUST_CTRL_SHIFT 8 > > +// Used to scale from VCOM_ADJUST_CTRL to mv > > +#define VCOM_ADJUST_CTRL_SCAL 10000 > > + > > +#define FAULT_FLAG_SHIFT 1 > > + > > +#endif /* __LINUX_MFD_SY7636A_H */ > > Hmm, are that all defines you know about? I am fine with not including > unused things now, but I am curious. Yep, this is all that I currently have information on. > For comparison, here is my "scratchpad" of all the information I could > squeeze out of the sy7636 driver until now: > > OPMODE 0 > RAILS_ON 7 > VCOM_MANUAL 6 > LIGHTNESS 5 > > VDDH_DISABLE 4 > VEE_DISABLE 3 > VPOS_DISABLE 2 > VNEG_DISABLE 1 > VCOM_DISABLE 0 > > -> combined as RAILS_DISABLE in code > > VCOM: 10000 uV per step, accepts up to 2.75V (that is a bit contradictory) > VCOM_ADJ1 1 > > VCOM_ADJ2 2 > VCOM2_B8 7 > VDDH_EXT 0..4 > > VLDO_ADJ 3 > VLDO_ADJ = 5..7 > VPDD_ADJ = 0..4 > > VPDD_LEN 4 > VPPD_LEN 0..4 > > VEE_VP_EXT 5 > VP_EXT 5..6 > VEE_EXT 0..4 > > PWRON_DLY = 6 > TDLY4 = 6..7 > TDLY3 = 4..5 > TDLY2 = 2..3 > TDLY1 = 0..1 > > FAULTFLAGS 7 > FAULS 1..4: to be read out after interrupt and cleared > 0 no faults > 1 UVP at VB rail > 2 UVP at VN rail > 3 UVP at VPOS rail > 4 UVP at VNEG rail > 5 UVP at VDDH rail > 6 UVP at VEE rail > 7 SCP at VB rail > 8 SCP at VN rail > 9 SCP at VPOS rail > A SCP at VNEG rail > B SCP at VDDH rail > C SCP at VEE rail > D SCP at VCOM rail > E UVLO > F Thermal shutdown > > PG 0 > > THERM 8 Cool! Alistair > > Regards, > Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: Andreas Kemnade <andreas@kemnade.info> Cc: Alistair Francis <alistair@alistair23.me>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, lgirdwood@gmail.com, Rob Herring <robh+dt@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, rui.zhang@intel.com, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Sascha Hauer <s.hauer@pengutronix.de>, linux-hwmon@vger.kernel.org, amitk@kernel.org, linux-pm@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>, Shawn Guo <shawnguo@kernel.org> Subject: Re: [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a Date: Tue, 23 Nov 2021 22:14:18 +1000 [thread overview] Message-ID: <CAKmqyKPFOqWD7t6tC1Act97CVcY+yazrhwMLLr3j_wOyH50GTA@mail.gmail.com> (raw) In-Reply-To: <20211116000634.767dcdc0@aktux> On Tue, Nov 16, 2021 at 9:10 AM Andreas Kemnade <andreas@kemnade.info> wrote: > > Hi, > > this all creates a lot of question marks... > One of my main question is whether sy7636a = sy7636 (at least the > driver in the kobo vendor kernels does not have the "A" at the end, > whic does not necessarily mean a difference). > > https://www.silergy.com/products/panel_pmic > lists only a SY7636ARMC, so chances are good that the letters were just > stripped away by the driver developers. Printing on chip package is > cryptic so it is not that helpful. It is just "BWNBDA" I don't have a definite answer for you. But I think it's sy7636a The page you linked to above lists SY7636ARMC as well as SY7627RMC, SY7570RMC. That makes me think that the RMC is a generic suffix and this actual IC is the SY7636A. > > On Wed, 10 Nov 2021 22:29:43 +1000 > Alistair Francis <alistair@alistair23.me> wrote: > > [...] > > diff --git a/include/linux/mfd/sy7636a.h b/include/linux/mfd/sy7636a.h > > new file mode 100644 > > index 000000000000..2797c22dabc2 > > --- /dev/null > > +++ b/include/linux/mfd/sy7636a.h > > @@ -0,0 +1,36 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Functions to access SY3686A power management chip. > > Typo? or is it really a SY3686A? So what we are talking about? I think it's SY7636A > > > + * > > + * Copyright (C) 2021 reMarkable AS - http://www.remarkable.com/ > > + */ > > + > > +#ifndef __MFD_SY7636A_H > > +#define __MFD_SY7636A_H > > + > > +#define SY7636A_REG_OPERATION_MODE_CRL 0x00 > > +#define SY7636A_OPERATION_MODE_CRL_VCOMCTL BIT(6) > > hmm, this thing is called VCOM_MANUAL in the 4.1.15-based driver for the > Kobos and in the 3.0.35 kernel for the Tolinos it is: > > // 1:controll the vcom by external VCOM_EN pin > #define SY7636_REG_OPM_VCOM_EXT_mask 0x1 // > #define SY7636_REG_OPM_VCOM_EXT_lsb 6 // > > In both kernels, it is set if a gpio is used to control the regulator. > That does not necessarily conflict with your usage. The gpio might just > be hardwired to something in your device. Maybe just a comment about > that issue. Ok, I'll add a comment. > > > +#define SY7636A_OPERATION_MODE_CRL_ONOFF BIT(7) > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_L 0x01 > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_H 0x02 > > +#define SY7636A_REG_VCOM_ADJUST_CTRL_MASK 0x01ff > > +#define SY7636A_REG_VLDO_VOLTAGE_ADJULST_CTRL 0x03 > > +#define SY7636A_REG_POWER_ON_DELAY_TIME 0x06 > > +#define SY7636A_REG_FAULT_FLAG 0x07 > > +#define SY7636A_FAULT_FLAG_PG BIT(0) > > +#define SY7636A_REG_TERMISTOR_READOUT 0x08 > > + > > +#define SY7636A_REG_MAX 0x08 > > + > > +#define VCOM_MIN 0 > > +#define VCOM_MAX 5000 > > hmm, what does that maximum mean? What you can set without something > freaking out just by setting it? Or the limit where the driver works > reliably? Good question. This is unused so I have just removed it. > > + > > +#define VCOM_ADJUST_CTRL_MASK 0x1ff > > +// Used to shift the high byte > > +#define VCOM_ADJUST_CTRL_SHIFT 8 > > +// Used to scale from VCOM_ADJUST_CTRL to mv > > +#define VCOM_ADJUST_CTRL_SCAL 10000 > > + > > +#define FAULT_FLAG_SHIFT 1 > > + > > +#endif /* __LINUX_MFD_SY7636A_H */ > > Hmm, are that all defines you know about? I am fine with not including > unused things now, but I am curious. Yep, this is all that I currently have information on. > For comparison, here is my "scratchpad" of all the information I could > squeeze out of the sy7636 driver until now: > > OPMODE 0 > RAILS_ON 7 > VCOM_MANUAL 6 > LIGHTNESS 5 > > VDDH_DISABLE 4 > VEE_DISABLE 3 > VPOS_DISABLE 2 > VNEG_DISABLE 1 > VCOM_DISABLE 0 > > -> combined as RAILS_DISABLE in code > > VCOM: 10000 uV per step, accepts up to 2.75V (that is a bit contradictory) > VCOM_ADJ1 1 > > VCOM_ADJ2 2 > VCOM2_B8 7 > VDDH_EXT 0..4 > > VLDO_ADJ 3 > VLDO_ADJ = 5..7 > VPDD_ADJ = 0..4 > > VPDD_LEN 4 > VPPD_LEN 0..4 > > VEE_VP_EXT 5 > VP_EXT 5..6 > VEE_EXT 0..4 > > PWRON_DLY = 6 > TDLY4 = 6..7 > TDLY3 = 4..5 > TDLY2 = 2..3 > TDLY1 = 0..1 > > FAULTFLAGS 7 > FAULS 1..4: to be read out after interrupt and cleared > 0 no faults > 1 UVP at VB rail > 2 UVP at VN rail > 3 UVP at VPOS rail > 4 UVP at VNEG rail > 5 UVP at VDDH rail > 6 UVP at VEE rail > 7 SCP at VB rail > 8 SCP at VN rail > 9 SCP at VPOS rail > A SCP at VNEG rail > B SCP at VDDH rail > C SCP at VEE rail > D SCP at VCOM rail > E UVLO > F Thermal shutdown > > PG 0 > > THERM 8 Cool! Alistair > > Regards, > Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-23 12:14 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-10 12:29 [PATCH v15 0/8] Add support for the silergy,sy7636a Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 12:29 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis 2021-11-10 12:29 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml Alistair Francis 2021-11-17 21:39 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Andreas Kemnade 2021-11-17 21:39 ` Andreas Kemnade 2021-11-23 13:29 ` Alistair Francis 2021-11-23 13:29 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml Alistair Francis 2021-11-25 22:59 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Andreas Kemnade 2021-11-25 22:59 ` Andreas Kemnade 2021-11-29 11:41 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml Alistair Francis 2021-11-29 11:41 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis 2021-12-01 22:35 ` Andreas Kemnade 2021-12-01 22:35 ` Andreas Kemnade 2021-12-02 11:45 ` Alistair Francis 2021-12-02 11:45 ` [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml Alistair Francis 2021-11-10 12:29 ` [PATCH v15 2/8] mfd: simple-mfd-i2c: Add a Kconfig name Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 12:29 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Alistair Francis 2021-11-10 12:29 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a Alistair Francis 2021-11-15 23:10 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Andreas Kemnade 2021-11-15 23:10 ` Andreas Kemnade 2021-11-23 12:14 ` Alistair Francis [this message] 2021-11-23 12:14 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a Alistair Francis 2021-11-23 15:39 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Guenter Roeck 2021-11-23 15:39 ` Guenter Roeck 2021-11-24 8:11 ` Alistair Francis 2021-11-24 8:11 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a Alistair Francis 2021-11-24 19:35 ` [PATCH v15 3/8] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Andreas Kemnade 2021-11-24 19:35 ` Andreas Kemnade 2021-11-24 20:09 ` Guenter Roeck 2021-11-24 20:09 ` Guenter Roeck 2021-11-24 22:50 ` Andreas Kemnade 2021-11-24 22:50 ` Andreas Kemnade 2021-11-24 22:56 ` Guenter Roeck 2021-11-24 22:56 ` Guenter Roeck 2021-11-25 7:29 ` Andreas Kemnade 2021-11-25 7:29 ` Andreas Kemnade 2021-11-10 12:29 ` [PATCH v15 4/8] regulator: sy7636a: Remove requirement on sy7636a mfd Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 14:39 ` Mark Brown 2021-11-10 14:39 ` Mark Brown 2021-11-10 12:29 ` [PATCH v15 5/8] hwmon: sy7636a: Add temperature driver for sy7636a Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 15:55 ` Guenter Roeck 2021-11-10 15:55 ` Guenter Roeck 2021-11-10 12:29 ` [PATCH v15 6/8] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 12:29 ` [PATCH v15 7/8] ARM: dts: imx7d: remarkable2: " Alistair Francis 2021-11-10 12:29 ` Alistair Francis 2021-11-10 12:29 ` [PATCH v15 8/8] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis 2021-11-10 12:29 ` Alistair Francis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKmqyKPFOqWD7t6tC1Act97CVcY+yazrhwMLLr3j_wOyH50GTA@mail.gmail.com \ --to=alistair23@gmail.com \ --cc=alistair@alistair23.me \ --cc=amitk@kernel.org \ --cc=andreas@kemnade.info \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.