From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Eduardo Valentin <edubezval@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kukjin Kim <kgene@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 3/3] cpufreq: exynos: allow modular build
Date: Thu, 29 Jan 2015 09:09:03 +0530 [thread overview]
Message-ID: <CAKohpom9L4jiMRGn3OaWyYM7iR3Ame4-LKG144yuHmRxCJud3g@mail.gmail.com> (raw)
In-Reply-To: <1799972.nQ2Axu0CEJ@wuerfel>
On 29 January 2015 at 01:31, Arnd Bergmann <arnd@arndb.de> wrote:
>> config ARM_EXYNOS_CPUFREQ
>> - bool
>> + tristate "SAMSUNG EXYNOS CPUfreq Driver"
>> + depends on THERMAL
>> + default y
>> + help
>> + This adds the CPUFreq driver for Samsung EXYNOS platforms
>> +
>> + If in doubt, say N.
>
> Now the option shows up on all systems that include Kconfig.arm,
> in particular non-exynos machines that might not even be able
> to build this.
I am sure I am wrong here, but want to know what I am missing.
What about:
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index c3c3cf52d2d9..f3ee05067a69 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -27,7 +27,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ
config ARM_EXYNOS_CPUFREQ
tristate "SAMSUNG EXYNOS CPUfreq Driver"
- depends on THERMAL
+ depends on THERMAL && ARCH_EXYNOS
default y
help
This adds the CPUFreq driver for Samsung EXYNOS platforms
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] cpufreq: exynos: allow modular build
Date: Thu, 29 Jan 2015 09:09:03 +0530 [thread overview]
Message-ID: <CAKohpom9L4jiMRGn3OaWyYM7iR3Ame4-LKG144yuHmRxCJud3g@mail.gmail.com> (raw)
In-Reply-To: <1799972.nQ2Axu0CEJ@wuerfel>
On 29 January 2015 at 01:31, Arnd Bergmann <arnd@arndb.de> wrote:
>> config ARM_EXYNOS_CPUFREQ
>> - bool
>> + tristate "SAMSUNG EXYNOS CPUfreq Driver"
>> + depends on THERMAL
>> + default y
>> + help
>> + This adds the CPUFreq driver for Samsung EXYNOS platforms
>> +
>> + If in doubt, say N.
>
> Now the option shows up on all systems that include Kconfig.arm,
> in particular non-exynos machines that might not even be able
> to build this.
I am sure I am wrong here, but want to know what I am missing.
What about:
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index c3c3cf52d2d9..f3ee05067a69 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -27,7 +27,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ
config ARM_EXYNOS_CPUFREQ
tristate "SAMSUNG EXYNOS CPUfreq Driver"
- depends on THERMAL
+ depends on THERMAL && ARCH_EXYNOS
default y
help
This adds the CPUFreq driver for Samsung EXYNOS platforms
next prev parent reply other threads:[~2015-01-29 3:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:16 [PATCH 0/3] cpufreq: build fixes Arnd Bergmann
2015-01-28 13:16 ` Arnd Bergmann
2015-01-28 13:16 ` [PATCH 1/3] cpufreq: s3c: remove incorrect __init annotations Arnd Bergmann
2015-01-28 13:16 ` Arnd Bergmann
2015-01-29 3:23 ` Viresh Kumar
2015-01-29 3:23 ` Viresh Kumar
2015-01-28 13:16 ` [PATCH 2/3] cpufreq: s3c: remove last use of resume_clocks callback Arnd Bergmann
2015-01-28 13:16 ` Arnd Bergmann
2015-01-29 3:23 ` Viresh Kumar
2015-01-29 3:23 ` Viresh Kumar
2015-01-28 13:16 ` [PATCH 3/3] cpufreq: exynos: allow modular build Arnd Bergmann
2015-01-28 13:16 ` Arnd Bergmann
2015-01-28 17:22 ` Eduardo Valentin
2015-01-28 17:22 ` Eduardo Valentin
2015-01-28 20:01 ` Arnd Bergmann
2015-01-28 20:01 ` Arnd Bergmann
2015-01-29 3:39 ` Viresh Kumar [this message]
2015-01-29 3:39 ` Viresh Kumar
2015-01-29 10:01 ` Arnd Bergmann
2015-01-29 10:01 ` Arnd Bergmann
2015-01-29 10:10 ` Viresh Kumar
2015-01-29 10:10 ` Viresh Kumar
2015-01-29 12:42 ` Arnd Bergmann
2015-01-29 12:42 ` Arnd Bergmann
2015-01-29 22:21 ` Eduardo Valentin
2015-01-29 22:21 ` Eduardo Valentin
2015-01-30 21:24 ` Arnd Bergmann
2015-01-30 21:24 ` Arnd Bergmann
2015-01-30 21:51 ` Eduardo Valentin
2015-01-30 21:51 ` Eduardo Valentin
2015-01-31 22:37 ` Arnd Bergmann
2015-01-31 22:37 ` Arnd Bergmann
2015-01-30 0:58 ` [PATCH 0/3] cpufreq: build fixes Rafael J. Wysocki
2015-01-30 0:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpom9L4jiMRGn3OaWyYM7iR3Ame4-LKG144yuHmRxCJud3g@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=arnd@arndb.de \
--cc=edubezval@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.