From: Viresh Kumar <viresh.kumar@linaro.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
rjw@sisk.pl, Steve.Bannister@arm.com, linux-pm@vger.kernel.org,
Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>,
Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org, robin.randhawa@arm.com,
linux-arm-kernel@lists.infradead.org,
mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org,
charles.garcia-tobin@arm.com
Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Thu, 7 Mar 2013 09:46:16 +0800 [thread overview]
Message-ID: <CAKohponduoxw8KoWtCzfYgthXGmi=8=ydR4dzQOy--PXcPFfWg@mail.gmail.com> (raw)
In-Reply-To: <CAHLZz11PR6E7-yhrxwRi=HWo9tWByH5FUArDqfXQh6N0C_x0tQ@mail.gmail.com>
On 7 March 2013 08:49, Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
>> clk[cluster] = clk_get_sys(name, NULL);
>> - if (!IS_ERR(clk[cluster])) {
>> + if (!IS_ERR_OR_NULL(clk[cluster])) {
>> pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n",
>> __func__, clk[cluster], freq_table[cluster],
>> cluster);
>
>
> You seem pretty attached to IS_ERR_OR_NULL here.
Haha. Not really. I just wanted to get more logical conclusion out. Please check
the other mail (where i would reply to Russell), which might have more
discussion
around this.
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Thu, 7 Mar 2013 09:46:16 +0800 [thread overview]
Message-ID: <CAKohponduoxw8KoWtCzfYgthXGmi=8=ydR4dzQOy--PXcPFfWg@mail.gmail.com> (raw)
In-Reply-To: <CAHLZz11PR6E7-yhrxwRi=HWo9tWByH5FUArDqfXQh6N0C_x0tQ@mail.gmail.com>
On 7 March 2013 08:49, Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
>> clk[cluster] = clk_get_sys(name, NULL);
>> - if (!IS_ERR(clk[cluster])) {
>> + if (!IS_ERR_OR_NULL(clk[cluster])) {
>> pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n",
>> __func__, clk[cluster], freq_table[cluster],
>> cluster);
>
>
> You seem pretty attached to IS_ERR_OR_NULL here.
Haha. Not really. I just wanted to get more logical conclusion out. Please check
the other mail (where i would reply to Russell), which might have more
discussion
around this.
next prev parent reply other threads:[~2013-03-07 1:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 4:52 [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Viresh Kumar
2013-03-05 4:52 ` Viresh Kumar
2013-03-05 10:52 ` Russell King - ARM Linux
2013-03-05 10:52 ` Russell King - ARM Linux
2013-03-05 16:38 ` Viresh Kumar
2013-03-05 16:38 ` Viresh Kumar
2013-03-06 17:25 ` Russell King - ARM Linux
2013-03-06 17:25 ` Russell King - ARM Linux
2013-03-06 23:09 ` Viresh Kumar
2013-03-06 23:09 ` Viresh Kumar
2013-03-07 0:32 ` Viresh Kumar
2013-03-07 0:32 ` Viresh Kumar
2013-03-07 0:49 ` Harvey Harrison
2013-03-07 0:49 ` Harvey Harrison
2013-03-07 1:46 ` Viresh Kumar [this message]
2013-03-07 1:46 ` Viresh Kumar
2013-03-07 0:51 ` Russell King - ARM Linux
2013-03-07 0:51 ` Russell King - ARM Linux
2013-03-07 2:03 ` Viresh Kumar
2013-03-07 2:03 ` Viresh Kumar
2013-03-07 11:49 ` Russell King - ARM Linux
2013-03-07 11:49 ` Russell King - ARM Linux
2013-03-07 17:04 ` Viresh Kumar
2013-03-07 17:04 ` Viresh Kumar
2013-03-07 1:46 ` Olof Johansson
2013-03-07 1:46 ` Olof Johansson
2013-03-07 1:50 ` Olof Johansson
2013-03-07 1:50 ` Olof Johansson
2013-03-07 2:29 ` Viresh Kumar
2013-03-07 2:29 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohponduoxw8KoWtCzfYgthXGmi=8=ydR4dzQOy--PXcPFfWg@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=harvey.harrison@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.hambleton@broadcom.com \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=sudeep.karkadanagesha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.