From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] crypto: arm/crc32 - avoid warning when compiling with Clang
Date: Tue, 18 Sep 2018 08:52:00 -0700 [thread overview]
Message-ID: <CAKv+Gu8xkeKb1-ce_hNCcXLrdj+qdi2DsXWPUuAiZQY1Rz+rmw@mail.gmail.com> (raw)
In-Reply-To: <20180916043825.23247-2-stefan@agner.ch>
On 15 September 2018 at 21:38, Stefan Agner <stefan@agner.ch> wrote:
> The table id (second) argument to MODULE_DEVICE_TABLE is often
> referenced otherwise. This is not the case for CPU features. This
> leads to a warning when building the kernel with Clang:
> arch/arm/crypto/crc32-ce-glue.c:239:33: warning: variable
> 'crc32_cpu_feature' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cpu_feature crc32_cpu_feature[] = {
> ^
>
> Avoid warnings by using __maybe_unused, similar to commit 1f318a8bafcf
> ("modules: mark __inittest/__exittest as __maybe_unused").
>
> Fixes: 2a9faf8b7e43 ("crypto: arm/crc32 - enable module autoloading based on CPU feature bits")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm/crypto/crc32-ce-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/crypto/crc32-ce-glue.c b/arch/arm/crypto/crc32-ce-glue.c
> index 96e62ec105d0..cd9e93b46c2d 100644
> --- a/arch/arm/crypto/crc32-ce-glue.c
> +++ b/arch/arm/crypto/crc32-ce-glue.c
> @@ -236,7 +236,7 @@ static void __exit crc32_pmull_mod_exit(void)
> ARRAY_SIZE(crc32_pmull_algs));
> }
>
> -static const struct cpu_feature crc32_cpu_feature[] = {
> +static const struct cpu_feature __maybe_unused crc32_cpu_feature[] = {
> { cpu_feature(CRC32) }, { cpu_feature(PMULL) }, { }
> };
> MODULE_DEVICE_TABLE(cpu, crc32_cpu_feature);
> --
> 2.19.0
>
WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] crypto: arm/crc32 - avoid warning when compiling with Clang
Date: Tue, 18 Sep 2018 08:52:00 -0700 [thread overview]
Message-ID: <CAKv+Gu8xkeKb1-ce_hNCcXLrdj+qdi2DsXWPUuAiZQY1Rz+rmw@mail.gmail.com> (raw)
In-Reply-To: <20180916043825.23247-2-stefan@agner.ch>
On 15 September 2018 at 21:38, Stefan Agner <stefan@agner.ch> wrote:
> The table id (second) argument to MODULE_DEVICE_TABLE is often
> referenced otherwise. This is not the case for CPU features. This
> leads to a warning when building the kernel with Clang:
> arch/arm/crypto/crc32-ce-glue.c:239:33: warning: variable
> 'crc32_cpu_feature' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cpu_feature crc32_cpu_feature[] = {
> ^
>
> Avoid warnings by using __maybe_unused, similar to commit 1f318a8bafcf
> ("modules: mark __inittest/__exittest as __maybe_unused").
>
> Fixes: 2a9faf8b7e43 ("crypto: arm/crc32 - enable module autoloading based on CPU feature bits")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm/crypto/crc32-ce-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/crypto/crc32-ce-glue.c b/arch/arm/crypto/crc32-ce-glue.c
> index 96e62ec105d0..cd9e93b46c2d 100644
> --- a/arch/arm/crypto/crc32-ce-glue.c
> +++ b/arch/arm/crypto/crc32-ce-glue.c
> @@ -236,7 +236,7 @@ static void __exit crc32_pmull_mod_exit(void)
> ARRAY_SIZE(crc32_pmull_algs));
> }
>
> -static const struct cpu_feature crc32_cpu_feature[] = {
> +static const struct cpu_feature __maybe_unused crc32_cpu_feature[] = {
> { cpu_feature(CRC32) }, { cpu_feature(PMULL) }, { }
> };
> MODULE_DEVICE_TABLE(cpu, crc32_cpu_feature);
> --
> 2.19.0
>
next prev parent reply other threads:[~2018-09-18 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 4:38 [PATCH 1/2] cpufeature: avoid warning when compiling with clang Stefan Agner
2018-09-16 4:38 ` Stefan Agner
2018-09-16 4:38 ` [PATCH 2/2] crypto: arm/crc32 - avoid warning when compiling with Clang Stefan Agner
2018-09-16 4:38 ` Stefan Agner
2018-09-18 15:52 ` Ard Biesheuvel [this message]
2018-09-18 15:52 ` Ard Biesheuvel
2018-09-18 15:52 ` Ard Biesheuvel
2018-09-18 15:49 ` [PATCH 1/2] cpufeature: avoid warning when compiling with clang Ard Biesheuvel
2018-09-18 15:49 ` Ard Biesheuvel
2018-09-18 15:49 ` Ard Biesheuvel
2018-09-21 5:46 ` Herbert Xu
2018-09-21 5:46 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8xkeKb1-ce_hNCcXLrdj+qdi2DsXWPUuAiZQY1Rz+rmw@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.