From: Nick Desaulniers <ndesaulniers@google.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Nathan Chancellor <nathan@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
regressions@lists.linux.dev, lkft-triage@lists.linaro.org,
llvm@lists.linux.dev
Subject: Re: arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives
Date: Mon, 26 Sep 2022 11:17:00 -0700 [thread overview]
Message-ID: <CAKwvOdkCCyP8W2pHf9ETKMgUtKCgcSwUb6=bMJ_8riwjyknpCw@mail.gmail.com> (raw)
In-Reply-To: <YzHpT7t+9uSIYm0k@shell.armlinux.org.uk>
On Mon, Sep 26, 2022 at 11:02 AM Russell King (Oracle)
<linux@armlinux.org.uk> wrote:
>
> On Mon, Sep 26, 2022 at 10:42:45AM -0700, Nick Desaulniers wrote:
> > > On Mon, Sep 26, 2022 at 08:44:05AM -0700, Nathan Chancellor wrote:
> > > > Thank you for the testing and report! I brought this up on GitHub on
> > > > Friday as I noticed this as well:
> > > >
> > > > https://github.com/ClangBuiltLinux/linux/issues/1718
> >
> > Thanks for the reports. I'll take a look at filing additional bug
> > reports against clang, then moving the definition of
> > __kretprobe_trampoline to out of line assembler.
>
> Are you saying that .save should be accepted without a .fnstart?
No. It's just a bug in clang's inline assembler. But it does make
sense to just move it to out of line assembler anyways; having it be
inline provides little to no benefit.
Should I be using UNWIND from arch/arm/include/asm/unwind.h on these
.fnstart/.save/.pad/.fnend directives?
--
Thanks,
~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Nathan Chancellor <nathan@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
regressions@lists.linux.dev, lkft-triage@lists.linaro.org,
llvm@lists.linux.dev
Subject: Re: arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives
Date: Mon, 26 Sep 2022 11:17:00 -0700 [thread overview]
Message-ID: <CAKwvOdkCCyP8W2pHf9ETKMgUtKCgcSwUb6=bMJ_8riwjyknpCw@mail.gmail.com> (raw)
In-Reply-To: <YzHpT7t+9uSIYm0k@shell.armlinux.org.uk>
On Mon, Sep 26, 2022 at 11:02 AM Russell King (Oracle)
<linux@armlinux.org.uk> wrote:
>
> On Mon, Sep 26, 2022 at 10:42:45AM -0700, Nick Desaulniers wrote:
> > > On Mon, Sep 26, 2022 at 08:44:05AM -0700, Nathan Chancellor wrote:
> > > > Thank you for the testing and report! I brought this up on GitHub on
> > > > Friday as I noticed this as well:
> > > >
> > > > https://github.com/ClangBuiltLinux/linux/issues/1718
> >
> > Thanks for the reports. I'll take a look at filing additional bug
> > reports against clang, then moving the definition of
> > __kretprobe_trampoline to out of line assembler.
>
> Are you saying that .save should be accepted without a .fnstart?
No. It's just a bug in clang's inline assembler. But it does make
sense to just move it to out of line assembler anyways; having it be
inline provides little to no benefit.
Should I be using UNWIND from arch/arm/include/asm/unwind.h on these
.fnstart/.save/.pad/.fnend directives?
--
Thanks,
~Nick Desaulniers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-26 18:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:27 arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives Naresh Kamboju
2022-09-26 13:27 ` Naresh Kamboju
2022-09-26 15:44 ` Nathan Chancellor
2022-09-26 15:44 ` Nathan Chancellor
2022-09-26 15:46 ` Nathan Chancellor
2022-09-26 15:46 ` Nathan Chancellor
2022-09-26 17:42 ` Nick Desaulniers
2022-09-26 17:42 ` Nick Desaulniers
2022-09-26 18:02 ` Russell King (Oracle)
2022-09-26 18:02 ` Russell King (Oracle)
2022-09-26 18:17 ` Nick Desaulniers [this message]
2022-09-26 18:17 ` Nick Desaulniers
2022-09-26 18:37 ` [PATCH] ARM: kprobes: move __kretprobe_trampoline to out of line assembler Nick Desaulniers
2022-09-26 18:37 ` Nick Desaulniers
2022-09-26 18:42 ` Nick Desaulniers
2022-09-26 18:42 ` Nick Desaulniers
2022-09-27 22:28 ` [PATCH v2] " Nick Desaulniers
2022-09-27 22:28 ` Nick Desaulniers
2022-09-27 22:35 ` Russell King (Oracle)
2022-09-27 22:35 ` Russell King (Oracle)
2022-09-28 16:39 ` Nick Desaulniers
2022-09-28 16:39 ` Nick Desaulniers
2022-09-29 8:53 ` [PATCH] " kernel test robot
2022-09-30 21:15 ` [PATCH v3] " Nick Desaulniers
2022-09-30 21:15 ` Nick Desaulniers
2022-10-06 20:35 ` Nick Desaulniers
2022-10-06 20:35 ` Nick Desaulniers
2022-10-08 3:10 ` Chen Zhongjin
2022-10-08 3:10 ` Chen Zhongjin
2022-10-04 0:48 ` [PATCH] " kernel test robot
2022-10-05 22:59 ` Ard Biesheuvel
2022-10-05 22:59 ` Ard Biesheuvel
2022-09-26 16:11 ` arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives Russell King (Oracle)
2022-09-26 16:11 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdkCCyP8W2pHf9ETKMgUtKCgcSwUb6=bMJ_8riwjyknpCw@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.