From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Aleksandar Markovic <amarkovic@wavecomp.com>
Subject: Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files
Date: Thu, 19 Mar 2020 20:02:18 +0100 [thread overview]
Message-ID: <CAL1e-=gew7ReO-Q_KZHiRkh5mC2UPphFOsJDsWW0+q+SMOHVXg@mail.gmail.com> (raw)
In-Reply-To: <b400bf37-3364-cb31-991d-443970e6309f@vivier.eu>
[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]
On Thursday, March 19, 2020, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 19/03/2020 à 17:24, Aleksandar Markovic a écrit :
> >> I think we should first introduce a linux-user/generic/termbits.h as we
> >> have an asm-generic/termbits.h in the kernel and use it with all the
> >> targets except alpha, mips, hppa, sparc and xtensa.
> >>
> >> I think this linux-user/generic/termbits.h could be copied from
> >> linux-user/openrisc/termbits.h (without the ioctl definitions)
> >>
> >> Then you could update the remaining ones.
> >>
> >
> > I agree with you, Laurent, that would be the cleanest
> > implementation.
> >
> > However, I think it requires at least several days of meticulous
> > dev work, that I can't afford at this moment. May I ask you to
> > accept this series as is for 5.0, as a sort of bridge towards
> > the implementation you described? It certainly fixes a majority
> > of termbits-related bugs, many of them remained latent just
> > by fact that XXX and TARGET_XXX were identical. The most
> > affected targets, xtensa, mips and alpha should be cleaned up
> > by this series wrt termbits, and for great majority of issues
> > are cleaned up for all platforms.
> >
> > I just don't have enough time resources to additionally
> > devote to this problem.
>
> ok, but I need to review and test them, I don't know if I will have
> enough time for that. I will try...
>
>
OK, thanks!
Aleksandar
> Thanks,
> Laurent
>
[-- Attachment #2: Type: text/html, Size: 2015 bytes --]
prev parent reply other threads:[~2020-03-19 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:11 [PATCH 0/4] linux-user: Fix some issues in termbits.h files Aleksandar Markovic
2020-01-17 2:11 ` [PATCH 1/4] linux-user: alpha: Synchronize termbits.h with kernel Aleksandar Markovic
2020-01-17 2:11 ` [PATCH 2/4] linux-user: mips: " Aleksandar Markovic
2020-01-17 2:11 ` [PATCH 3/4] linux-user: xtensa: Fix some constants in termbits.h Aleksandar Markovic
2020-01-17 2:11 ` [PATCH 4/4] linux-user: Fix some constants in remaining termbits.h Aleksandar Markovic
2020-01-17 10:12 ` [PATCH 0/4] linux-user: Fix some issues in termbits.h files no-reply
2020-01-28 18:19 ` Laurent Vivier
2020-03-19 16:24 ` Aleksandar Markovic
2020-03-19 16:34 ` Laurent Vivier
2020-03-19 19:02 ` Aleksandar Markovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1e-=gew7ReO-Q_KZHiRkh5mC2UPphFOsJDsWW0+q+SMOHVXg@mail.gmail.com' \
--to=aleksandar.m.mail@gmail.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.