Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files

From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Aleksandar Markovic <amarkovic@wavecomp.com>
Subject: Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files
Date: Thu, 19 Mar 2020 17:24:26 +0100	[thread overview]
Message-ID: <CAL1e-=jOUxOKHFdVa06TpDwsbicKyGrn8mJ=dJtRcaAX6sFriQ@mail.gmail.com> (raw)
In-Reply-To: <994d96ac-ce43-9ff5-7212-eda6e12264fb@vivier.eu>

> I think we should first introduce a linux-user/generic/termbits.h as we
> have an asm-generic/termbits.h in the kernel and use it with all the
> targets except alpha, mips, hppa, sparc and xtensa.
>
> I think this linux-user/generic/termbits.h could be copied from
> linux-user/openrisc/termbits.h (without the ioctl definitions)
>
> Then you could update the remaining ones.
>

I agree with you, Laurent, that would be the cleanest
implementation.

However, I think it requires at least several days of meticulous
dev work, that I can't afford at this moment. May I ask you to
accept this series as is for 5.0, as a sort of bridge towards
the implementation you described? It certainly fixes a majority
of termbits-related bugs, many of them remained latent just
by fact that XXX and TARGET_XXX were identical. The most
affected targets, xtensa, mips and alpha should be cleaned up
by this series wrt termbits, and for great majority of issues
are cleaned up for all platforms.

I just don't have enough time resources to additionally
devote to this problem.

Sincerely,
Aleksandar

> Thanks,
> Laurent
>