From: John Stultz <john.stultz@linaro.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Xing Gao <xgao01@email.wm.edu>,
Jessica Frazelle <me@jessfraz.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jonathan Corbet <corbet@lwn.net>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Richard Cochran <richardcochran@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Marek <mmarek@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Olof Johansson <olof@lixom.net>, Shuah Khan <shuah@kernel.org>,
linux-doc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] time: Remove CONFIG_TIMER_STATS
Date: Tue, 7 Feb 2017 20:29:31 -0800 [thread overview]
Message-ID: <CALAqxLW6FowGNWgtnSh6S9B4S_C=GW29mq7uLvk=_KMceOfHSw@mail.gmail.com> (raw)
In-Reply-To: <20170207234031.GA27933@beast>
On Tue, Feb 7, 2017 at 3:40 PM, Kees Cook <keescook@chromium.org> wrote:
> Currently CONFIG_TIMER_STATS exposes process information across namespaces:
>
> kernel/time/timer_list.c print_timer():
>
> SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
>
> /proc/timer_list:
>
> #11: <0000000000000000>, hrtimer_wakeup, S:01, do_nanosleep, cron/2570
>
> Given that the tracer can give the same information, this patch entirely
> removes CONFIG_TIMER_STATS.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Kees Cook <keescook@chromium.org>
I don't have an issue with this, but I worry this would break some
tooling out there. Should it be marked as deprecated first?
Or maybe just pulling the band-aid off is the best way?
thanks
-john
WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Xing Gao <xgao01@email.wm.edu>,
Jessica Frazelle <me@jessfraz.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jonathan Corbet <corbet@lwn.net>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Richard Cochran <richardcochran@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Marek <mmarek@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Olof Johansson <olof@lixom.net>, Shuah Khan <shuah@kernel.org>,
linux-doc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH] time: Remove CONFIG_TIMER_STATS
Date: Tue, 7 Feb 2017 20:29:31 -0800 [thread overview]
Message-ID: <CALAqxLW6FowGNWgtnSh6S9B4S_C=GW29mq7uLvk=_KMceOfHSw@mail.gmail.com> (raw)
In-Reply-To: <20170207234031.GA27933@beast>
On Tue, Feb 7, 2017 at 3:40 PM, Kees Cook <keescook@chromium.org> wrote:
> Currently CONFIG_TIMER_STATS exposes process information across namespaces:
>
> kernel/time/timer_list.c print_timer():
>
> SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
>
> /proc/timer_list:
>
> #11: <0000000000000000>, hrtimer_wakeup, S:01, do_nanosleep, cron/2570
>
> Given that the tracer can give the same information, this patch entirely
> removes CONFIG_TIMER_STATS.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Kees Cook <keescook@chromium.org>
I don't have an issue with this, but I worry this would break some
tooling out there. Should it be marked as deprecated first?
Or maybe just pulling the band-aid off is the best way?
thanks
-john
next prev parent reply other threads:[~2017-02-08 4:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:40 [PATCH] time: Remove CONFIG_TIMER_STATS Kees Cook
2017-02-07 23:40 ` [kernel-hardening] " Kees Cook
2017-02-08 4:29 ` John Stultz [this message]
2017-02-08 4:29 ` [kernel-hardening] " John Stultz
2017-02-08 10:24 ` Thomas Gleixner
2017-02-08 10:24 ` [kernel-hardening] " Thomas Gleixner
2017-02-08 18:09 ` John Stultz
2017-02-08 18:09 ` [kernel-hardening] " John Stultz
2017-02-08 4:41 ` kbuild test robot
2017-02-08 4:41 ` [kernel-hardening] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLW6FowGNWgtnSh6S9B4S_C=GW29mq7uLvk=_KMceOfHSw@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=jiangshanlai@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@jessfraz.com \
--cc=mmarek@suse.com \
--cc=nicolas.iooss_linux@m4x.org \
--cc=nicolas.pitre@linaro.org \
--cc=oleg@redhat.com \
--cc=olof@lixom.net \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.com \
--cc=richardcochran@gmail.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=xgao01@email.wm.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.