From: John Stultz <john.stultz@linaro.org> To: Will McVicker <willmcvicker@google.com> Cc: Russell King <linux@armlinux.org.uk>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Thomas Gleixner <tglx@linutronix.de>, Lee Jones <lee.jones@linaro.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Saravana Kannan <saravanak@google.com>, Android Kernel Team <kernel-team@android.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, lkml <linux-kernel@vger.kernel.org>, Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>, "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended Date: Wed, 29 Sep 2021 13:46:05 -0700 [thread overview] Message-ID: <CALAqxLXUOY+tdJat0YaxAEiS_AWrwxBaLq3M90btSVdWfvFBag@mail.gmail.com> (raw) In-Reply-To: <CABYd82Z4pgJpYVhJEGjgbWgSQp7if_=Rf03VmTu+U9D3b=dVzA@mail.gmail.com> On Wed, Sep 29, 2021 at 1:01 PM Will McVicker <willmcvicker@google.com> wrote: > On Tue, Sep 28, 2021 at 8:42 PM John Stultz <john.stultz@linaro.org> wrote: > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker <willmcvicker@google.com> wrote: > > > > > > This allows modules to access the value of timekeeping_suspended without > > > giving them write access to the variable. > > > > > > > It's important to cover "the why" not "the what" in these commit > > messages, so you might add a note as to what code will be the user of > > this (the samsung/clk-pll.c code changed later in this series). > > > > thanks > > -john > > Thanks John for the tip. I will try to be better at that in the followup. I have to remind myself regularly as well. :) Apologies if my quick reply above seemed curt (as it does to me re-reading it now). Wasn't my intent. > For this specific patch, I am adding this new API because the Samsung > PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the > variable 'timekeeping_suspended' to detect timeouts before the > clocksource is initialized or timekeeping itself is suspended. My > patch series aims to modularize the Samsung PLL driver. So to keep the > driver's functionality intact, I need to add this additional API. Sounds good! Another small/medium suggestion: Since you're adding a new interface for non-core users of timekeeping_suspended, it might be good to switch the other users as well (seems like just drivers/clk/ti/clkctrl.c and kernel/sched/clock.c), then also remove the extern in include/linux/timekeeping.h (so there's one consistent method to access it)? I know it's a sort of scope creep, so apologies for asking, but it would make the series more attractive if it's not leaving something for others to clean up later. thanks -john
WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org> To: Will McVicker <willmcvicker@google.com> Cc: Russell King <linux@armlinux.org.uk>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Thomas Gleixner <tglx@linutronix.de>, Lee Jones <lee.jones@linaro.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Saravana Kannan <saravanak@google.com>, Android Kernel Team <kernel-team@android.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, lkml <linux-kernel@vger.kernel.org>, Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>, "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended Date: Wed, 29 Sep 2021 13:46:05 -0700 [thread overview] Message-ID: <CALAqxLXUOY+tdJat0YaxAEiS_AWrwxBaLq3M90btSVdWfvFBag@mail.gmail.com> (raw) In-Reply-To: <CABYd82Z4pgJpYVhJEGjgbWgSQp7if_=Rf03VmTu+U9D3b=dVzA@mail.gmail.com> On Wed, Sep 29, 2021 at 1:01 PM Will McVicker <willmcvicker@google.com> wrote: > On Tue, Sep 28, 2021 at 8:42 PM John Stultz <john.stultz@linaro.org> wrote: > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker <willmcvicker@google.com> wrote: > > > > > > This allows modules to access the value of timekeeping_suspended without > > > giving them write access to the variable. > > > > > > > It's important to cover "the why" not "the what" in these commit > > messages, so you might add a note as to what code will be the user of > > this (the samsung/clk-pll.c code changed later in this series). > > > > thanks > > -john > > Thanks John for the tip. I will try to be better at that in the followup. I have to remind myself regularly as well. :) Apologies if my quick reply above seemed curt (as it does to me re-reading it now). Wasn't my intent. > For this specific patch, I am adding this new API because the Samsung > PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the > variable 'timekeeping_suspended' to detect timeouts before the > clocksource is initialized or timekeeping itself is suspended. My > patch series aims to modularize the Samsung PLL driver. So to keep the > driver's functionality intact, I need to add this additional API. Sounds good! Another small/medium suggestion: Since you're adding a new interface for non-core users of timekeeping_suspended, it might be good to switch the other users as well (seems like just drivers/clk/ti/clkctrl.c and kernel/sched/clock.c), then also remove the extern in include/linux/timekeeping.h (so there's one consistent method to access it)? I know it's a sort of scope creep, so apologies for asking, but it would make the series more attractive if it's not leaving something for others to clean up later. thanks -john _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-29 20:46 UTC|newest] Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-28 23:56 [PATCH v2 00/12] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 01/12] arm64: don't have ARCH_EXYNOS select EXYNOS_CHIPID Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 13:58 ` (subset) " Krzysztof Kozlowski 2021-09-29 13:58 ` Krzysztof Kozlowski 2021-09-29 14:00 ` Krzysztof Kozlowski 2021-09-29 14:00 ` Krzysztof Kozlowski 2021-09-28 23:56 ` [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 3:42 ` John Stultz 2021-09-29 3:42 ` John Stultz 2021-09-29 20:01 ` Will McVicker 2021-09-29 20:01 ` Will McVicker 2021-09-29 20:46 ` John Stultz [this message] 2021-09-29 20:46 ` John Stultz 2021-09-30 18:31 ` Will McVicker 2021-09-30 18:31 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 03/12] clk: samsung: add support for CPU clocks Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 04/12] clk: samsung: exynos5433: update apollo and atlas clock probing Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 05/12] clk: export __clk_lookup Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-10-08 4:31 ` Stephen Boyd 2021-10-08 4:31 ` Stephen Boyd 2021-09-28 23:56 ` [PATCH v2 06/12] clk: samsung: modularize exynos arm64 clk drivers Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 07/12] clk: samsung: set exynos arm64 clk driver as tristate Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 13:09 ` Krzysztof Kozlowski 2021-09-29 13:09 ` Krzysztof Kozlowski 2021-09-28 23:56 ` [PATCH v2 08/12] pinctrl: samsung: modularize the ARM and ARM64 pinctrls Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 2:01 ` Chanho Park 2021-09-29 2:01 ` Chanho Park 2021-09-28 23:56 ` [PATCH v2 09/12] pinctrl: samsung: set PINCTRL_EXYNOS and PINCTRL_SAMSUNG as tristate Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-28 23:56 ` [PATCH v2 10/12] soc: samsung: pmu: modularize the Exynos ARMv8 PMU driver Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 13:11 ` Krzysztof Kozlowski 2021-09-29 13:11 ` Krzysztof Kozlowski 2021-09-28 23:56 ` [PATCH v2 11/12] soc: samsung: pm_domains: modularize EXYNOS_PM_DOMAINS Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 13:36 ` Krzysztof Kozlowski 2021-09-29 13:36 ` Krzysztof Kozlowski 2021-09-28 23:56 ` [PATCH v2 12/12] ARM: rtc: remove HAVE_S3C_RTC in favor of direct dependencies Will McVicker 2021-09-28 23:56 ` Will McVicker 2021-09-29 11:52 ` Alexandre Belloni 2021-09-29 11:52 ` Alexandre Belloni 2021-09-29 13:02 ` [PATCH v2 00/12] arm64: Kconfig: Update ARCH_EXYNOS select configs Krzysztof Kozlowski 2021-09-29 13:02 ` Krzysztof Kozlowski 2021-09-29 19:48 ` Will McVicker 2021-09-29 19:48 ` Will McVicker 2021-09-30 6:14 ` Krzysztof Kozlowski 2021-09-30 6:14 ` Krzysztof Kozlowski 2021-09-30 9:01 ` Arnd Bergmann 2021-09-30 9:01 ` Arnd Bergmann 2021-09-30 9:30 ` Lee Jones 2021-09-30 9:30 ` Lee Jones 2021-09-30 10:33 ` Krzysztof Kozlowski 2021-09-30 10:33 ` Krzysztof Kozlowski 2021-09-30 12:34 ` Lee Jones 2021-09-30 12:34 ` Lee Jones 2021-09-30 12:38 ` Krzysztof Kozlowski 2021-09-30 12:38 ` Krzysztof Kozlowski 2021-09-30 10:05 ` Geert Uytterhoeven 2021-09-30 10:05 ` Geert Uytterhoeven 2021-09-30 9:23 ` Lee Jones 2021-09-30 9:23 ` Lee Jones 2021-09-30 10:17 ` Geert Uytterhoeven 2021-09-30 10:17 ` Geert Uytterhoeven 2021-09-30 10:56 ` Lee Jones 2021-09-30 10:56 ` Lee Jones 2021-09-30 11:25 ` Geert Uytterhoeven 2021-09-30 11:25 ` Geert Uytterhoeven 2021-09-30 12:08 ` Lee Jones 2021-09-30 12:08 ` Lee Jones 2021-09-30 16:09 ` Geert Uytterhoeven 2021-09-30 16:09 ` Geert Uytterhoeven 2021-09-30 10:52 ` Krzysztof Kozlowski 2021-09-30 10:52 ` Krzysztof Kozlowski 2021-09-30 12:32 ` Lee Jones 2021-09-30 12:32 ` Lee Jones 2021-09-30 11:01 ` Tomasz Figa 2021-09-30 11:01 ` Tomasz Figa 2021-09-30 11:27 ` Geert Uytterhoeven 2021-09-30 11:27 ` Geert Uytterhoeven 2021-09-30 11:51 ` Lee Jones 2021-09-30 11:51 ` Lee Jones 2021-09-30 12:10 ` Tomasz Figa 2021-09-30 12:10 ` Tomasz Figa 2021-09-30 12:15 ` Krzysztof Kozlowski 2021-09-30 12:15 ` Krzysztof Kozlowski 2021-09-30 12:45 ` Lee Jones 2021-09-30 12:45 ` Lee Jones 2021-10-01 4:01 ` Christoph Hellwig 2021-10-01 4:01 ` Christoph Hellwig 2021-10-01 4:52 ` Saravana Kannan 2021-10-01 4:52 ` Saravana Kannan 2021-10-01 4:55 ` Christoph Hellwig 2021-10-01 4:55 ` Christoph Hellwig 2021-09-30 12:21 ` Krzysztof Kozlowski 2021-09-30 12:21 ` Krzysztof Kozlowski 2021-09-30 12:39 ` Lee Jones 2021-09-30 12:39 ` Lee Jones 2021-09-30 13:08 ` Krzysztof Kozlowski 2021-09-30 13:08 ` Krzysztof Kozlowski 2021-09-30 13:29 ` Lee Jones 2021-09-30 13:29 ` Lee Jones 2021-09-30 16:12 ` Geert Uytterhoeven 2021-09-30 16:12 ` Geert Uytterhoeven 2021-09-30 16:21 ` Lee Jones 2021-09-30 16:21 ` Lee Jones 2021-09-30 16:26 ` Geert Uytterhoeven 2021-09-30 16:26 ` Geert Uytterhoeven 2021-09-30 18:02 ` Will McVicker 2021-09-30 18:02 ` Will McVicker 2021-10-01 4:04 ` Christoph Hellwig 2021-10-01 4:04 ` Christoph Hellwig 2021-10-01 4:52 ` Olof Johansson 2021-10-01 4:52 ` Olof Johansson 2021-10-01 5:23 ` Saravana Kannan 2021-10-01 5:23 ` Saravana Kannan 2021-10-01 5:35 ` Olof Johansson 2021-10-01 5:35 ` Olof Johansson 2021-10-01 5:59 ` Will McVicker 2021-10-01 5:59 ` Will McVicker 2021-10-01 8:01 ` Krzysztof Kozlowski 2021-10-01 8:01 ` Krzysztof Kozlowski 2021-10-01 6:02 ` Saravana Kannan 2021-10-01 6:02 ` Saravana Kannan 2021-10-01 6:27 ` Olof Johansson 2021-10-01 6:27 ` Olof Johansson 2021-10-01 6:30 ` Olof Johansson 2021-10-01 6:30 ` Olof Johansson 2021-10-01 12:00 ` Arnd Bergmann 2021-10-01 12:00 ` Arnd Bergmann 2021-10-01 12:31 ` Lee Jones 2021-10-01 12:31 ` Lee Jones 2021-10-01 15:43 ` Olof Johansson 2021-10-01 15:43 ` Olof Johansson 2021-10-01 11:38 ` Linus Walleij 2021-10-01 11:38 ` Linus Walleij 2021-10-01 11:59 ` Geert Uytterhoeven 2021-10-01 11:59 ` Geert Uytterhoeven 2021-10-01 15:59 ` Olof Johansson 2021-10-01 15:59 ` Olof Johansson 2021-10-01 16:51 ` Will McVicker 2021-10-01 16:51 ` Will McVicker 2021-10-01 17:15 ` Olof Johansson 2021-10-01 17:15 ` Olof Johansson 2021-10-01 17:48 ` Will McVicker 2021-10-01 17:48 ` Will McVicker 2021-10-01 8:19 ` Geert Uytterhoeven 2021-10-01 8:19 ` Geert Uytterhoeven 2021-10-01 9:00 ` Arnd Bergmann 2021-10-01 9:00 ` Arnd Bergmann 2021-10-01 15:27 ` Olof Johansson 2021-10-01 15:27 ` Olof Johansson 2021-10-01 19:26 ` Saravana Kannan 2021-10-01 19:26 ` Saravana Kannan 2021-10-02 1:47 ` Tomasz Figa 2021-10-02 1:47 ` Tomasz Figa 2021-10-02 21:03 ` Olof Johansson 2021-10-02 21:03 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALAqxLXUOY+tdJat0YaxAEiS_AWrwxBaLq3M90btSVdWfvFBag@mail.gmail.com \ --to=john.stultz@linaro.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=catalin.marinas@arm.com \ --cc=cw00.choi@samsung.com \ --cc=geert@linux-m68k.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=tglx@linutronix.de \ --cc=tomasz.figa@gmail.com \ --cc=will@kernel.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.