From: Andy Lutomirski <luto@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Sean Christopherson <sean.j.christopherson@intel.com>,
"Huang, Kai" <kai.huang@intel.com>,
Jethro Beekman <jethro@fortanix.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"x86@kernel.org" <x86@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Haitao Huang <haitao.huang@linux.intel.com>,
"Dr . Greg Wettstein" <greg@enjellic.com>
Subject: Re: x86/sgx: uapi change proposal
Date: Thu, 10 Jan 2019 13:36:15 -0800 [thread overview]
Message-ID: <CALCETrXMW+tUyTaMmmdhGciqbktiqH6NCuLZbBqfhcnzCgMbnA@mail.gmail.com> (raw)
In-Reply-To: <20190110174550.GJ6589@linux.intel.com>
On Thu, Jan 10, 2019 at 9:46 AM Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
>
> On Tue, Jan 08, 2019 at 02:54:11PM -0800, Andy Lutomirski wrote:
> > I do think it makes sense to have QEMU delegate the various ENCLS
> > operations (especially EINIT) to the regular SGX interface, which will
> > mean that VM guests will have exactly the same access controls applied
> > as regular user programs, which is probably what we want. If so,
> > there will need to be a way to get INITTOKEN privilege for the purpose
> > of running non-Linux OSes in the VM, which isn't the end of the world.
> > We might still want the actual ioctl to do EINIT using an actual
> > explicit token to be somehow restricted in a way that strongly
> > discourages its use by anything other than a hypervisor. Or I suppose
> > we could just straight-up ignore the guest-provided init token.
>
> Does it even matter if just leave EINITTOKENKEY attribute unprivileged
> given that Linux requires that MSRs are writable? Maybe I'll just
> whitelist that attribute to any enclave?
>
I would at least make it work like the PROVISIONKEY bit (or whatever
it's called). Or just deny it at first. It's easy to start allowing
it if we need to down the road, but it's harder to start denying it.
Also, I don't really want to see some SDK invoke a launch enclave
because that's how it works on Windows and then do nothing with the
resulting EINITOKEN. If we don't allow it, then the SDKs will be
forced to do a better job, which is probably a good thing.
next prev parent reply other threads:[~2019-01-10 21:36 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 21:57 [RFC PATCH v5 0/5] x86: Add vDSO exception fixup for SGX Sean Christopherson
2018-12-14 21:57 ` [RFC PATCH v5 1/5] x86/vdso: Add support for exception fixup in vDSO functions Sean Christopherson
2018-12-14 21:57 ` [RFC PATCH v5 2/5] x86/fault: Add helper function to sanitize error code Sean Christopherson
2018-12-14 21:57 ` [RFC PATCH v5 3/5] x86/fault: Attempt to fixup unhandled #PF on ENCLU before signaling Sean Christopherson
2018-12-14 21:57 ` [RFC PATCH v5 4/5] x86/traps: Attempt to fixup exceptions in vDSO " Sean Christopherson
2018-12-14 21:57 ` [RFC PATCH v5 5/5] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions Sean Christopherson
2018-12-19 9:21 ` Jarkko Sakkinen
2018-12-18 4:18 ` [RFC PATCH v5 0/5] x86: Add vDSO exception fixup for SGX Jarkko Sakkinen
2018-12-18 15:08 ` Sean Christopherson
2018-12-19 4:43 ` Jarkko Sakkinen
2018-12-19 5:03 ` Jarkko Sakkinen
2018-12-19 7:58 ` x86/sgx: uapi change proposal Jarkko Sakkinen
2018-12-19 8:41 ` Jethro Beekman
2018-12-19 9:11 ` Jarkko Sakkinen
2018-12-19 9:36 ` Jethro Beekman
2018-12-19 10:43 ` Jarkko Sakkinen
2018-12-19 14:45 ` Sean Christopherson
2018-12-20 2:58 ` Andy Lutomirski
2018-12-20 10:32 ` Jarkko Sakkinen
2018-12-20 13:12 ` Jarkko Sakkinen
2018-12-20 13:19 ` Jarkko Sakkinen
2018-12-22 8:16 ` Jarkko Sakkinen
[not found] ` <20181222082502.GA13275@linux.intel.com>
2018-12-23 12:52 ` Jarkko Sakkinen
2018-12-23 20:42 ` Andy Lutomirski
2018-12-24 11:52 ` Jarkko Sakkinen
2019-01-02 20:47 ` Sean Christopherson
2019-01-03 15:02 ` Jarkko Sakkinen
[not found] ` <20190103162634.GA8610@linux.intel.com>
2019-01-09 14:45 ` Jarkko Sakkinen
2018-12-21 16:28 ` Sean Christopherson
2018-12-21 17:12 ` Andy Lutomirski
2018-12-21 18:24 ` Sean Christopherson
2018-12-21 23:41 ` Jarkko Sakkinen
2018-12-23 20:41 ` Andy Lutomirski
2018-12-24 12:01 ` Jarkko Sakkinen
2018-12-21 23:37 ` Jarkko Sakkinen
2018-12-22 6:32 ` Jarkko Sakkinen
2019-01-08 19:27 ` Huang, Kai
2019-01-08 22:09 ` Sean Christopherson
2019-01-08 22:54 ` Andy Lutomirski
2019-01-09 16:31 ` Sean Christopherson
2019-01-10 21:34 ` Andy Lutomirski
2019-01-10 22:22 ` Huang, Kai
2019-01-10 23:54 ` Sean Christopherson
2019-01-11 0:30 ` Andy Lutomirski
2019-01-11 1:32 ` Sean Christopherson
2019-01-11 12:58 ` Jarkko Sakkinen
2019-01-11 13:00 ` Jarkko Sakkinen
2019-01-11 23:19 ` Sean Christopherson
2019-01-18 14:37 ` Jarkko Sakkinen
2019-01-10 17:45 ` Jarkko Sakkinen
2019-01-10 21:36 ` Andy Lutomirski [this message]
2019-01-11 16:07 ` Jarkko Sakkinen
2019-01-09 5:24 ` Huang, Kai
2019-01-09 17:16 ` Sean Christopherson
2019-01-10 0:21 ` Huang, Kai
2019-01-10 0:40 ` Sean Christopherson
2019-01-10 17:43 ` Jarkko Sakkinen
2018-12-20 10:30 ` Jarkko Sakkinen
2018-12-19 14:43 ` Dr. Greg
2018-12-20 10:34 ` Jarkko Sakkinen
2018-12-20 22:06 ` Dr. Greg
2018-12-21 13:48 ` Jarkko Sakkinen
2018-12-20 12:08 ` Arnd Bergmann
2018-12-20 12:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrXMW+tUyTaMmmdhGciqbktiqH6NCuLZbBqfhcnzCgMbnA@mail.gmail.com \
--to=luto@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=greg@enjellic.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=josh@joshtriplett.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.