Re: [PATCH] selftests: bpf: config: add config fragments

From: William Tu <u9012063@gmail.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests: bpf: config: add config fragments
Date: Tue, 19 Jun 2018 05:56:10 -0700	[thread overview]
Message-ID: <CALDO+SY2eE6DHtVmfnUpMjTjHe3shfzae48nk_OehfUyuKNYsg@mail.gmail.com> (raw)
In-Reply-To: <CADYN=9KegM2wNCX7=BDct16bzzmr-02aG1c3MLDEEon1yGXnzQ@mail.gmail.com>

On Thu, Jun 14, 2018 at 11:41 PM, Anders Roxell
<anders.roxell@linaro.org> wrote:
> On Thu, 14 Jun 2018 at 14:09, William Tu <u9012063@gmail.com> wrote:
>>
>> On Thu, Jun 14, 2018 at 4:42 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
>> > On 14 June 2018 at 13:06, William Tu <u9012063@gmail.com> wrote:
>> >> On Tue, Jun 12, 2018 at 5:08 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
>> >>> On 06/12/2018 01:05 PM, Anders Roxell wrote:
>> >>>> Tests test_tunnel.sh fails due to config fragments ins't enabled.
>> >>>>
>> >>>> Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.")
>> >>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> >>>> ---
>> >>>>
>> >>>> All tests passes except ip6gretap that still fails. I'm unsure why.
>> >>>> Ideas?
>> >>
>> >> Hi Anders,
>> >>
>> >> ip6erspan is based on ip6gretap, does ip6erspan pass?
>> >
>> > it did pass  when I was sending the email.
>> > However, I retested this on next-20180613 and now it fails.
>> >
>> Does 'ip -s link show' show any errors/dropped on ip6gretap device?
>
> I rerun the test_ip6gretap test only and added "set -x" to
> test_tunnel.sh here's the output.
> I added "ip -s link show ip6gretap11" before the cleanup function in the script.
>
> # ./test_tunnel.sh
> + PING_ARG='-c 3 -w 10 -q'
> + ret=0
> + GREEN='\033[0;92m'
> + RED='\033[0;31m'
> + NC='\033[0m'
> + trap cleanup 0 3 6
> + trap cleanup_exit 2 9
> + cleanup
> + ip netns delete at_ns0
> + ip link del veth1
> + ip link del ipip11
> + ip link del ipip6tnl11
> + ip link del gretap11
> + ip link del ip6gre11
> + ip link del ip6gretap11
> + ip link del vxlan11
> + ip link del ip6vxlan11
> + ip link del geneve11
> + ip link del ip6geneve11
> + ip link del erspan11
> + ip link del ip6erspan11
> + bpf_tunnel_test
> + echo 'Testing IP6GRETAP tunnel...'
> Testing IP6GRETAP tunnel...
> + test_ip6gretap
> + TYPE=ip6gretap
> + DEV_NS=ip6gretap00
> + DEV=ip6gretap11
> + ret=0
> + check ip6gretap
> + ip link help ip6gretap
> + grep -q '^Usage:'
> + '[' 0 -ne 0 ']'
> + config_device
> + ip netns add at_ns0
> + ip link add veth0 type veth peer name veth1
> + ip link set veth0 netns at_ns0
> + ip netns exec at_ns0 ip addr add 172.16.1.100/24 dev veth0
> + ip netns exec at_ns0 ip link set dev veth0 up
> + ip link set dev veth1 up mtu 1500
> + ip addr add dev veth1 172.16.1.200/24
> + add_ip6gretap_tunnel
> + ip netns exec at_ns0 ip addr add ::11/96 dev veth0
> + ip netns exec at_ns0 ip link set dev veth0 up
> + ip addr add dev veth1 ::22/96
> + ip link set dev veth1 up
> + ip netns exec at_ns0 ip link add dev ip6gretap00 type ip6gretap seq
> flowlabel 0xbcdef key 2 local ::11 remote ::22
> + ip netns exec at_ns0 ip addr add dev ip6gretap00 10.1.1.100/24
> + ip netns exec at_ns0 ip addr add dev ip6gretap00 fc80::100/96
> + ip netns exec at_ns0 ip link set dev ip6gretap00 up
> + ip link add dev ip6gretap11 type ip6gretap external
> + ip addr add dev ip6gretap11 10.1.1.200/24
> + ip addr add dev ip6gretap11 fc80::200/24
> + ip link set dev ip6gretap11 up
> + attach_bpf ip6gretap11 ip6gretap_set_tunnel ip6gretap_get_tunnel
> + DEV=ip6gretap11
> + SET=ip6gretap_set_tunnel
> + GET=ip6gretap_get_tunnel
> + tc qdisc add dev ip6gretap11 clsact
> + tc filter add dev ip6gretap11 egress bpf da obj test_tunnel_kern.o
> sec ip6gretap_set_tunnel
> + tc filter add dev ip6gretap11 ingress bpf da obj test_tunnel_kern.o
> sec ip6gretap_get_tunnel
> + ping6 -c 3 -w 10 -q ::11
> PING ::11 (::11): 56 data bytes
>
> --- ::11 ping statistics ---
> 5 packets transmitted, 3 packets received, 40% packet loss
> round-trip min/avg/max = 0.139/1.857/5.293 ms
> + ip netns exec at_ns0 ping -c 3 -w 10 -q 10.1.1.200
> PING 10.1.1.200 (10.1.1.200): 56 data bytes
>
> --- 10.1.1.200 ping statistics ---
> 3 packets transmitted, 3 packets received, 0% packet loss
> round-trip min/avg/max = 0.214/0.256/0.305 ms
> + ping -c 3 -w 10 -q 10.1.1.100
> PING 10.1.1.100 (10.1.1.100): 56 data bytes
>
> --- 10.1.1.100 ping statistics ---
> 3 packets transmitted, 3 packets received, 0% packet loss
> round-trip min/avg/max = 0.210/0.211/0.213 ms
> + check_err 0
> + '[' 0 -eq 0 ']'
> + ret=0
> + ip netns exec at_ns0 ping6 -c 3 -w 10 -q fc80::200
> PING fc80::200 (fc80::200): 56 data bytes
>
> --- fc80::200 ping statistics ---
> 10 packets transmitted, 0 packets received, 100% packet loss
> + check_err 1
> + '[' 0 -eq 0 ']'
> + ret=1
> + ip -s link show ip6gretap11
> 19: ip6gretap11@NONE: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1434 qdisc
> pfifo_fast state UNKNOWN mode DEFAULT group default qlen 1000
>     link/ether de:d2:0c:53:80:8c brd ff:ff:ff:ff:ff:ff
>     RX: bytes  packets  errors  dropped overrun mcast
>     2096       25       0       0       0       0
>     TX: bytes  packets  errors  dropped carrier collsns
>     5324       36       5       5       0       0

So there are 5 errors at TX.
I couldn't reproduce in my local machine using 4.17-rc6.
How do I checkin the "next-20180613" source code?

Thanks
William