From: Ezequiel Garcia <elezegarcia@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Daniel Mack <zonque@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"martinez.javier@gmail.com" <martinez.javier@gmail.com>,
"matthias.bgg@googlemail.com" <matthias.bgg@googlemail.com>,
"eballetbo@gmail.com" <eballetbo@gmail.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND
Date: Tue, 22 Jan 2013 16:43:43 -0300 [thread overview]
Message-ID: <CALF0-+XdsKvJJpmxZEYXyhTZksgKRoAJ4TcyPV+G9WUbb7Dt_g@mail.gmail.com> (raw)
In-Reply-To: <20130122182749.GM15361@atomide.com>
On Tue, Jan 22, 2013 at 3:27 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Ezequiel Garcia <elezegarcia@gmail.com> [130122 10:17]:
>> On Mon, Jan 21, 2013 at 10:32 PM, Daniel Mack <zonque@gmail.com> wrote:
>> >
>> > I'm currently far away from my computer and can't prepare a patch for this, sorry. But I think you are right, so please just submit a patch for that, anyone :-)
>> >
>>
>> Ok, I'll try to submit a patch as soon as possible. If anyone wants to
>> do it instead, fine by me.
>
> No please go ahead as it seems that you can easily test it too.
>
No problem.
I now wonder if it's okey to exit upon probe failure.
In particular, the for_each should be like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
if (ret < 0) {
of_node_put(child);
return ret;
}
}
or like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
WARN_ON(ret < 0);
}
Ideas?
--
Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <elezegarcia@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"martinez.javier@gmail.com" <martinez.javier@gmail.com>,
"matthias.bgg@googlemail.com" <matthias.bgg@googlemail.com>,
"eballetbo@gmail.com" <eballetbo@gmail.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Daniel Mack <zonque@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND
Date: Tue, 22 Jan 2013 16:43:43 -0300 [thread overview]
Message-ID: <CALF0-+XdsKvJJpmxZEYXyhTZksgKRoAJ4TcyPV+G9WUbb7Dt_g@mail.gmail.com> (raw)
In-Reply-To: <20130122182749.GM15361@atomide.com>
On Tue, Jan 22, 2013 at 3:27 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Ezequiel Garcia <elezegarcia@gmail.com> [130122 10:17]:
>> On Mon, Jan 21, 2013 at 10:32 PM, Daniel Mack <zonque@gmail.com> wrote:
>> >
>> > I'm currently far away from my computer and can't prepare a patch for this, sorry. But I think you are right, so please just submit a patch for that, anyone :-)
>> >
>>
>> Ok, I'll try to submit a patch as soon as possible. If anyone wants to
>> do it instead, fine by me.
>
> No please go ahead as it seems that you can easily test it too.
>
No problem.
I now wonder if it's okey to exit upon probe failure.
In particular, the for_each should be like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
if (ret < 0) {
of_node_put(child);
return ret;
}
}
or like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
WARN_ON(ret < 0);
}
Ideas?
--
Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: elezegarcia@gmail.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND
Date: Tue, 22 Jan 2013 16:43:43 -0300 [thread overview]
Message-ID: <CALF0-+XdsKvJJpmxZEYXyhTZksgKRoAJ4TcyPV+G9WUbb7Dt_g@mail.gmail.com> (raw)
In-Reply-To: <20130122182749.GM15361@atomide.com>
On Tue, Jan 22, 2013 at 3:27 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Ezequiel Garcia <elezegarcia@gmail.com> [130122 10:17]:
>> On Mon, Jan 21, 2013 at 10:32 PM, Daniel Mack <zonque@gmail.com> wrote:
>> >
>> > I'm currently far away from my computer and can't prepare a patch for this, sorry. But I think you are right, so please just submit a patch for that, anyone :-)
>> >
>>
>> Ok, I'll try to submit a patch as soon as possible. If anyone wants to
>> do it instead, fine by me.
>
> No please go ahead as it seems that you can easily test it too.
>
No problem.
I now wonder if it's okey to exit upon probe failure.
In particular, the for_each should be like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
if (ret < 0) {
of_node_put(child);
return ret;
}
}
or like this:
for_each_node_by_name(child, "nand") {
ret = gpmc_probe_nand_child(pdev, child);
WARN_ON(ret < 0);
}
Ideas?
--
Ezequiel
next prev parent reply other threads:[~2013-01-22 19:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 22:27 [PATCH v2 1/3] mtd: omap-onenand: pass device_node in platform data Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-19 22:27 ` [PATCH v2 2/3] arm: omap2: gpmc-onenand: drop __init annotation Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-19 22:27 ` [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-19 22:27 ` Ezequiel Garcia
2013-01-21 12:30 ` Mark Rutland
2013-01-21 12:30 ` Mark Rutland
2013-01-21 12:30 ` Mark Rutland
2013-01-21 16:57 ` Ezequiel Garcia
2013-01-21 16:57 ` Ezequiel Garcia
2013-01-21 16:57 ` Ezequiel Garcia
2013-01-21 18:33 ` Tony Lindgren
2013-01-21 18:33 ` Tony Lindgren
2013-01-21 18:33 ` Tony Lindgren
2013-01-22 1:32 ` Daniel Mack
2013-01-22 1:32 ` Daniel Mack
2013-01-22 1:32 ` Daniel Mack
2013-01-22 18:13 ` Ezequiel Garcia
2013-01-22 18:13 ` Ezequiel Garcia
2013-01-22 18:13 ` Ezequiel Garcia
2013-01-22 18:27 ` Tony Lindgren
2013-01-22 18:27 ` Tony Lindgren
2013-01-22 18:27 ` Tony Lindgren
2013-01-22 19:43 ` Ezequiel Garcia [this message]
2013-01-22 19:43 ` Ezequiel Garcia
2013-01-22 19:43 ` Ezequiel Garcia
2013-01-22 20:40 ` Tony Lindgren
2013-01-22 20:40 ` Tony Lindgren
2013-01-22 20:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALF0-+XdsKvJJpmxZEYXyhTZksgKRoAJ4TcyPV+G9WUbb7Dt_g@mail.gmail.com \
--to=elezegarcia@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eballetbo@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martinez.javier@gmail.com \
--cc=matthias.bgg@googlemail.com \
--cc=tony@atomide.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.