Re: [PATCH] ARM: dts: arm: Update register-bit-led nodes 'reg' and node names

From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	ARM-SoC Maintainers <arm@kernel.org>, SoC Team <soc@kernel.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	 Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] ARM: dts: arm: Update register-bit-led nodes 'reg' and node names
Date: Mon, 8 Nov 2021 18:25:50 -0600	[thread overview]
Message-ID: <CAL_Jsq+XAVio9Drvi-XPN=wHojE2PaxLa3pjxdO73H_0iVXi3A@mail.gmail.com> (raw)
In-Reply-To: <20211105183930.GA1448386@roeck-us.net>

On Fri, Nov 5, 2021 at 1:39 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Hi,
>
> On Mon, Oct 25, 2021 at 01:20:03AM +0200, Linus Walleij wrote:
> > From: Rob Herring <robh@kernel.org>
> >
> > Add a 'reg' entry for register-bit-led nodes on the Arm Ltd platforms.
> > The 'reg' entry is the LED control register address. With this, the node
> > name can be updated to use a generic node name, 'led', and a
> > unit-address.
> >
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Liviu Dudau <liviu.dudau@arm.com>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > SoC folks: please apply this directly for v5.16.
>
> This patch results in widespread sysfs backtraces with various qemu arm
> emulations (versatilepb, versatileab, realview-pb-a8, realview-pbx-a9,
> realview-eb, realview-eb-mpcore, integratorcp, mps2-an385).

Sigh. I'm working on a fix for this. Though the only way to fix
without a DT ABI break is reverting. A stable kernel update is
probably good enough.

There's a problem with the clock changes, too, but it looks like it
just affects the CLCD.

Rob