From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: renesas,rsnd: Update audio graph references
Date: Thu, 12 Nov 2020 10:15:22 -0600 [thread overview]
Message-ID: <CAL_JsqJOqXvHhazzZ9qFAOcdG5UrFrvThbX2D64Tk+c6f=Leqg@mail.gmail.com> (raw)
In-Reply-To: <20201112160746.GA3681609@bogus>
On Thu, Nov 12, 2020 at 10:07 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 11, 2020 at 05:56:53PM +0530, Sameer Pujar wrote:
> > Since audio graph schema is refactored now update the related
> > references here.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> This should be part of the first patch. Things break in between.
>
> >
> > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > index 51f4dca..fc2ae22 100644
> > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > @@ -112,12 +112,10 @@ properties:
> > - pattern: '^clk_(a|b|c|i)$'
> >
> > port:
> > - description: OF-Graph subnode
> > - $ref: "audio-graph-card.yaml#/properties/port"
> > + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> >
> > ports:
> > - description: multi OF-Graph subnode
> > - $ref: "audio-graph-card.yaml#/properties/ports"
> > + $ref: /schemas/graph.yaml#/properties/ports
Actually, with the graph.yaml dependency that doesn't work either. I
think this probably needs to be a ref to just audio-graph.yaml at the
top level and that should pick up port and ports schemas.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 2/2] ASoC: renesas,rsnd: Update audio graph references
Date: Thu, 12 Nov 2020 10:15:22 -0600 [thread overview]
Message-ID: <CAL_JsqJOqXvHhazzZ9qFAOcdG5UrFrvThbX2D64Tk+c6f=Leqg@mail.gmail.com> (raw)
In-Reply-To: <20201112160746.GA3681609@bogus>
On Thu, Nov 12, 2020 at 10:07 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 11, 2020 at 05:56:53PM +0530, Sameer Pujar wrote:
> > Since audio graph schema is refactored now update the related
> > references here.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> This should be part of the first patch. Things break in between.
>
> >
> > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > index 51f4dca..fc2ae22 100644
> > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > @@ -112,12 +112,10 @@ properties:
> > - pattern: '^clk_(a|b|c|i)$'
> >
> > port:
> > - description: OF-Graph subnode
> > - $ref: "audio-graph-card.yaml#/properties/port"
> > + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> >
> > ports:
> > - description: multi OF-Graph subnode
> > - $ref: "audio-graph-card.yaml#/properties/ports"
> > + $ref: /schemas/graph.yaml#/properties/ports
Actually, with the graph.yaml dependency that doesn't work either. I
think this probably needs to be a ref to just audio-graph.yaml at the
top level and that should pick up port and ports schemas.
Rob
next prev parent reply other threads:[~2020-11-12 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 12:26 [PATCH 0/2] Refactor Audio Graph schema Sameer Pujar
2020-11-11 12:26 ` Sameer Pujar
2020-11-11 12:26 ` [PATCH 1/2] ASoC: audio-graph-card: Refactor schema Sameer Pujar
2020-11-11 12:26 ` Sameer Pujar
2020-11-12 16:06 ` Rob Herring
2020-11-12 16:06 ` Rob Herring
2020-11-11 12:26 ` [PATCH 2/2] ASoC: renesas,rsnd: Update audio graph references Sameer Pujar
2020-11-11 12:26 ` Sameer Pujar
2020-11-12 16:07 ` Rob Herring
2020-11-12 16:07 ` Rob Herring
2020-11-12 16:15 ` Rob Herring [this message]
2020-11-12 16:15 ` Rob Herring
2020-11-11 23:24 ` [PATCH 0/2] Refactor Audio Graph schema Kuninori Morimoto
2020-11-11 23:24 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJOqXvHhazzZ9qFAOcdG5UrFrvThbX2D64Tk+c6f=Leqg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.