From: Rob Herring <robh+dt@kernel.org> To: Douglas Anderson <dianders@chromium.org> Cc: "John Youn" <johnyoun@synopsys.com>, "Felipe Balbi" <balbi@ti.com>, "Heiko Stübner" <heiko@sntech.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, lyz <lyz@rock-chips.com>, wulf <wulf@rock-chips.com>, "Pawel Moll" <pawel.moll@arm.com>, "Mark Rutland" <mark.rutland@arm.com>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Kumar Gala" <galak@codeaurora.org>, "Paul Zimmerman" <paulz@synopsys.com>, "Gregory Herrero" <gregory.herrero@intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Linux USB List" <linux-usb@vger.kernel.org> Subject: Re: [PATCH v2 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Date: Mon, 2 Nov 2015 10:12:32 -0600 [thread overview] Message-ID: <CAL_JsqKCEC3=PmD27zZ2KMY-UwZTjoZrwnEimWOvgqLeJ6wRjg@mail.gmail.com> (raw) In-Reply-To: <1446236275-12698-2-git-send-email-dianders@chromium.org> On Fri, Oct 30, 2015 at 3:17 PM, Douglas Anderson <dianders@chromium.org> wrote: > From: Doug Anderson <dianders@chromium.org> > > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). I would think re-enumerating means autosuspend is broken. > We can get the PHY out of its bad state by asserting its "port reset", > but unfortunately that seems to assert a reset onto the USB bus so it > could confuse things if we don't actually deenumerate / reenumerate the > device. > > We can also get the PHY out of its bad state by fully resetting it using > the reset from the CRU (clock reset unit), which does a more full > reset. The CRU-based reset appears to actually cause devices on the bus > to be removed and reinserted, which fixes the problem (albeit in a hacky > way). The reset from the CRU goes to the PHY, correct? Therefore, the binding should reflect that. Connecting it to the host controller is a hack. So describe the reset connection properly and then add a .phy_reset() hook to the phy subsystem. Then call that when flag property you added is set. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: "John Youn" <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>, "Felipe Balbi" <balbi-l0cyMroinI0@public.gmane.org>, "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, "Greg Kroah-Hartman" <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, lyz <lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, wulf <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, "Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>, "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "Ian Campbell" <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, "Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, "Paul Zimmerman" <paulz-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>, "Gregory Herrero" <gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Linux USB List" <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v2 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Date: Mon, 2 Nov 2015 10:12:32 -0600 [thread overview] Message-ID: <CAL_JsqKCEC3=PmD27zZ2KMY-UwZTjoZrwnEimWOvgqLeJ6wRjg@mail.gmail.com> (raw) In-Reply-To: <1446236275-12698-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> On Fri, Oct 30, 2015 at 3:17 PM, Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote: > From: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). I would think re-enumerating means autosuspend is broken. > We can get the PHY out of its bad state by asserting its "port reset", > but unfortunately that seems to assert a reset onto the USB bus so it > could confuse things if we don't actually deenumerate / reenumerate the > device. > > We can also get the PHY out of its bad state by fully resetting it using > the reset from the CRU (clock reset unit), which does a more full > reset. The CRU-based reset appears to actually cause devices on the bus > to be removed and reinserted, which fixes the problem (albeit in a hacky > way). The reset from the CRU goes to the PHY, correct? Therefore, the binding should reflect that. Connecting it to the host controller is a hack. So describe the reset connection properly and then add a .phy_reset() hook to the phy subsystem. Then call that when flag property you added is set. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-02 16:13 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-30 20:17 [PATCH v2 0/2] Patches to fix remote wakeup on rk3288 dwc2 "host" port Douglas Anderson 2015-10-30 20:17 ` Douglas Anderson 2015-10-30 20:17 ` Douglas Anderson 2015-10-30 20:17 ` [PATCH v2 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Douglas Anderson 2015-11-02 16:12 ` Rob Herring [this message] 2015-11-02 16:12 ` Rob Herring 2015-11-02 16:22 ` Doug Anderson 2015-11-02 17:16 ` Rob Herring 2015-11-02 17:48 ` Doug Anderson 2015-11-02 17:48 ` Doug Anderson [not found] ` <1446236275-12698-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2016-07-19 12:00 ` [PATCH v3 0/2] usb: dwc2: fix the usb host for host port at RK3288 Randy Li 2016-07-19 12:05 ` [PATCH 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Randy Li [not found] ` <1468929933-6971-1-git-send-email-randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2016-07-20 1:36 ` Rob Herring 2016-07-20 2:54 ` Randy Li [not found] ` <0c61cf90-6fea-19ce-ce74-91648cb2d921-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2016-07-21 20:48 ` Rob Herring 2016-08-15 22:19 ` John Youn [not found] ` <38019f37-8d68-b7c1-a5b1-b34ffbadf461-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> 2016-08-16 1:10 ` Randy Li [not found] ` <39f96d60-09c0-c71f-b6e3-c84c8304e5f6-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2016-08-16 2:33 ` John Youn 2016-08-20 20:32 ` [PATCH 0/4 v4] usb: dwc2: fix the usb host for host port at RK32 Randy Li 2016-08-20 20:32 ` Randy Li 2016-08-20 20:32 ` [PATCH 1/4] phy: Add reset callback Randy Li 2016-08-20 20:32 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li 2016-08-20 20:32 ` Randy Li 2016-08-22 11:47 ` Kishon Vijay Abraham I 2016-08-22 11:47 ` Kishon Vijay Abraham I 2016-08-22 13:00 ` Heiko Stübner 2016-08-29 9:32 ` Kishon Vijay Abraham I 2016-08-29 9:32 ` Kishon Vijay Abraham I 2016-08-20 20:32 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li 2016-08-20 21:30 ` Sergei Shtylyov 2016-08-21 7:56 ` [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li 2016-08-21 7:56 ` Randy Li 2016-08-21 7:56 ` [PATCH 1/4] phy: Add reset callback Randy Li 2016-08-21 7:56 ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li 2016-08-21 7:56 ` Randy Li 2016-08-23 17:53 ` Rob Herring 2016-08-23 17:53 ` Rob Herring 2016-08-21 7:56 ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li 2016-08-21 7:56 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li 2016-08-21 11:06 ` Sergei Shtylyov 2016-08-21 12:19 ` ayaka 2016-08-21 12:19 ` ayaka 2016-08-22 10:30 ` Sergei Shtylyov 2016-08-22 10:30 ` Sergei Shtylyov 2016-08-21 19:31 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li 2016-08-21 19:31 ` [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li 2016-08-21 19:31 ` Randy Li 2016-08-23 20:46 ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform John Youn 2016-08-23 20:46 ` John Youn 2016-08-24 8:54 ` Randy Li 2016-08-24 8:54 ` Randy Li 2016-08-25 18:23 ` John Youn 2016-08-25 18:23 ` John Youn 2016-08-29 7:51 ` Felipe Balbi 2016-08-29 7:51 ` Felipe Balbi 2016-08-29 18:24 ` John Youn 2016-08-29 18:24 ` John Youn 2016-08-20 20:32 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li 2016-07-19 12:05 ` [PATCH 2/2] " Randy Li 2015-10-30 20:17 ` [PATCH v2 " Douglas Anderson 2015-10-30 20:17 ` Douglas Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqKCEC3=PmD27zZ2KMY-UwZTjoZrwnEimWOvgqLeJ6wRjg@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=balbi@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.herrero@intel.com \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=johnyoun@synopsys.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=lyz@rock-chips.com \ --cc=mark.rutland@arm.com \ --cc=paulz@synopsys.com \ --cc=pawel.moll@arm.com \ --cc=wulf@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.