From: Rob Herring <robh+dt@kernel.org>
To: patchwork-bot+netdevbpf@kernel.org,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, sihui.liu@ingenic.com,
jun.jiang@ingenic.com, sernia.zhou@foxmail.com,
"周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Subject: Re: [PATCH v3 0/2] Add Ingenic SoCs MAC support.
Date: Tue, 15 Jun 2021 17:03:31 -0600 [thread overview]
Message-ID: <CAL_JsqKEwrtZKK3viOzY8nW8fPmqnJO+WANvBfMzNYhg_aRrmg@mail.gmail.com> (raw)
In-Reply-To: <162370200625.25455.5879439335776203648.git-patchwork-notify@kernel.org>
On Mon, Jun 14, 2021 at 2:20 PM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> > v2->v3:
> > 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> > 2.Change tx clk delay and rx clk delay from hardware value to ps.
> > 3.return -EINVAL when a unsupported value is encountered when
> > parsing the binding.
> > 4.Simplify the code of the RGMII part of X2000 SoC according to
> > Andrew Lunn’s suggestion.
> > 5.Follow the example of "dwmac-mediatek.c" to improve the code
> > that handles delays according to Andrew Lunn’s suggestion.
> >
> > [...]
>
> Here is the summary with links:
> - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
> https://git.kernel.org/netdev/net-next/c/3b8401066e5a
> - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
> https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7
Perhaps 3 hours is not sufficient time to review. It may be a v3, but
the binding appears to have changed quite a bit in addition to being
broken.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: patchwork-bot+netdevbpf@kernel.org,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, sihui.liu@ingenic.com,
jun.jiang@ingenic.com, sernia.zhou@foxmail.com,
"周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Subject: Re: [PATCH v3 0/2] Add Ingenic SoCs MAC support.
Date: Tue, 15 Jun 2021 17:03:31 -0600 [thread overview]
Message-ID: <CAL_JsqKEwrtZKK3viOzY8nW8fPmqnJO+WANvBfMzNYhg_aRrmg@mail.gmail.com> (raw)
In-Reply-To: <162370200625.25455.5879439335776203648.git-patchwork-notify@kernel.org>
On Mon, Jun 14, 2021 at 2:20 PM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> > v2->v3:
> > 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> > 2.Change tx clk delay and rx clk delay from hardware value to ps.
> > 3.return -EINVAL when a unsupported value is encountered when
> > parsing the binding.
> > 4.Simplify the code of the RGMII part of X2000 SoC according to
> > Andrew Lunn’s suggestion.
> > 5.Follow the example of "dwmac-mediatek.c" to improve the code
> > that handles delays according to Andrew Lunn’s suggestion.
> >
> > [...]
>
> Here is the summary with links:
> - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
> https://git.kernel.org/netdev/net-next/c/3b8401066e5a
> - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
> https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7
Perhaps 3 hours is not sufficient time to review. It may be a v3, but
the binding appears to have changed quite a bit in addition to being
broken.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: patchwork-bot+netdevbpf@kernel.org,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, sihui.liu@ingenic.com,
jun.jiang@ingenic.com, sernia.zhou@foxmail.com,
"周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Subject: Re: [PATCH v3 0/2] Add Ingenic SoCs MAC support.
Date: Tue, 15 Jun 2021 17:03:31 -0600 [thread overview]
Message-ID: <CAL_JsqKEwrtZKK3viOzY8nW8fPmqnJO+WANvBfMzNYhg_aRrmg@mail.gmail.com> (raw)
In-Reply-To: <162370200625.25455.5879439335776203648.git-patchwork-notify@kernel.org>
On Mon, Jun 14, 2021 at 2:20 PM <patchwork-bot+netdevbpf@kernel.org> wrote:
>
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Tue, 15 Jun 2021 01:15:35 +0800 you wrote:
> > v2->v3:
> > 1.Add "ingenic,mac.yaml" for Ingenic SoCs.
> > 2.Change tx clk delay and rx clk delay from hardware value to ps.
> > 3.return -EINVAL when a unsupported value is encountered when
> > parsing the binding.
> > 4.Simplify the code of the RGMII part of X2000 SoC according to
> > Andrew Lunn’s suggestion.
> > 5.Follow the example of "dwmac-mediatek.c" to improve the code
> > that handles delays according to Andrew Lunn’s suggestion.
> >
> > [...]
>
> Here is the summary with links:
> - [v3,1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs.
> https://git.kernel.org/netdev/net-next/c/3b8401066e5a
> - [v3,2/2] net: stmmac: Add Ingenic SoCs MAC support.
> https://git.kernel.org/netdev/net-next/c/2bb4b98b60d7
Perhaps 3 hours is not sufficient time to review. It may be a v3, but
the binding appears to have changed quite a bit in addition to being
broken.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 23:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 17:15 [PATCH v3 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` [PATCH v3 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 17:36 ` Andrew Lunn
2021-06-15 14:04 ` Rob Herring
2021-06-15 14:04 ` Rob Herring
2021-06-15 14:04 ` Rob Herring
2021-06-15 23:05 ` Rob Herring
2021-06-15 23:05 ` Rob Herring
2021-06-15 23:05 ` Rob Herring
2021-06-16 7:45 ` 周琰杰
2021-06-16 7:45 ` 周琰杰
2021-06-16 7:45 ` 周琰杰
2021-06-17 3:24 ` 周琰杰
2021-06-17 3:24 ` 周琰杰
2021-06-17 3:24 ` 周琰杰
2021-06-18 19:50 ` Rob Herring
2021-06-18 19:50 ` Rob Herring
2021-06-18 19:50 ` Rob Herring
2021-06-14 17:15 ` [PATCH v3 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:15 ` 周琰杰 (Zhou Yanjie)
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 17:36 ` Andrew Lunn
2021-06-14 20:20 ` [PATCH v3 0/2] " patchwork-bot+netdevbpf
2021-06-14 20:20 ` patchwork-bot+netdevbpf
2021-06-14 20:20 ` patchwork-bot+netdevbpf
2021-06-15 23:03 ` Rob Herring [this message]
2021-06-15 23:03 ` Rob Herring
2021-06-15 23:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKEwrtZKK3viOzY8nW8fPmqnJO+WANvBfMzNYhg_aRrmg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.