From: Rob Herring <robh@kernel.org>
To: Min Guo <min.guo@mediatek.com>
Cc: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Linux USB List <linux-usb@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Tony Lindgren <tony@atomide.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
Date: Mon, 4 Mar 2019 11:42:58 -0600 [thread overview]
Message-ID: <CAL_JsqKb_afdZFaOoB5yvs2hX-T9HPVy_d30zu7f7yiqaRPaLg@mail.gmail.com> (raw)
In-Reply-To: <1551058604.12020.34.camel@mhfsdcap03>
On Sun, Feb 24, 2019 at 7:36 PM Min Guo <min.guo@mediatek.com> wrote:
>
> Hi Rob,
> On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote:
> > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote:
> > > From: Min Guo <min.guo@mediatek.com>
> > >
> > > This adds support for MediaTek musb controller in
> > > host, peripheral and otg mode.
> > >
> > > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > > ---
> > > changes in v5:
> > > suggested by Rob:
> > > 1. Modify compatible as
> > > - compatible : should be one of:
> > > "mediatek,mt-2701"
> > > ...
> > > followed by "mediatek,mtk-musb"
> > > 2. Add usb connector child node
> > >
> > > changes in v4:
> > > suggested by Sergei:
> > > 1. String alignment
> > >
> > > changes in v3:
> > > 1. no changes
> > >
> > > changes in v2:
> > > suggested by Bin:
> > > 1. Modify DRC to DRD
> > > suggested by Rob:
> > > 2. Drop the "<soc-model>-musb" in compatible
> > > 3. Remove phy-names
> > > 4. Add space after comma in clock-names
> > > ---
> > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++
> > > 1 file changed, 54 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > new file mode 100644
> > > index 0000000..0632e6e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > @@ -0,0 +1,54 @@
> > > +MediaTek musb DRD/OTG controller
> > > +-------------------------------------------
> > > +
> > > +Required properties:
> > > + - compatible : should be one of:
> > > + "mediatek,mt-2701"
> >
> > That looks like a top-level SoC compatible and doesn't match the
> > example.
> "mediatek,mt-2701" is an example, just to describe a specific SOC.
> May I modify compatibel like:
> compatible : should be "mediatek,mtk-musb"
No, you should fix the example adding "mediatek,mtk-musb".
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Min Guo <min.guo@mediatek.com>
Cc: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Linux USB List <linux-usb@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Tony Lindgren <tony@atomide.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: [v5,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
Date: Mon, 4 Mar 2019 11:42:58 -0600 [thread overview]
Message-ID: <CAL_JsqKb_afdZFaOoB5yvs2hX-T9HPVy_d30zu7f7yiqaRPaLg@mail.gmail.com> (raw)
On Sun, Feb 24, 2019 at 7:36 PM Min Guo <min.guo@mediatek.com> wrote:
>
> Hi Rob,
> On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote:
> > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote:
> > > From: Min Guo <min.guo@mediatek.com>
> > >
> > > This adds support for MediaTek musb controller in
> > > host, peripheral and otg mode.
> > >
> > > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > > ---
> > > changes in v5:
> > > suggested by Rob:
> > > 1. Modify compatible as
> > > - compatible : should be one of:
> > > "mediatek,mt-2701"
> > > ...
> > > followed by "mediatek,mtk-musb"
> > > 2. Add usb connector child node
> > >
> > > changes in v4:
> > > suggested by Sergei:
> > > 1. String alignment
> > >
> > > changes in v3:
> > > 1. no changes
> > >
> > > changes in v2:
> > > suggested by Bin:
> > > 1. Modify DRC to DRD
> > > suggested by Rob:
> > > 2. Drop the "<soc-model>-musb" in compatible
> > > 3. Remove phy-names
> > > 4. Add space after comma in clock-names
> > > ---
> > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++
> > > 1 file changed, 54 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > new file mode 100644
> > > index 0000000..0632e6e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > @@ -0,0 +1,54 @@
> > > +MediaTek musb DRD/OTG controller
> > > +-------------------------------------------
> > > +
> > > +Required properties:
> > > + - compatible : should be one of:
> > > + "mediatek,mt-2701"
> >
> > That looks like a top-level SoC compatible and doesn't match the
> > example.
> "mediatek,mt-2701" is an example, just to describe a specific SOC.
> May I modify compatibel like:
> compatible : should be "mediatek,mtk-musb"
No, you should fix the example adding "mediatek,mtk-musb".
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Min Guo <min.guo@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux USB List <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, Bin Liu <b-liu@ti.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
Date: Mon, 4 Mar 2019 11:42:58 -0600 [thread overview]
Message-ID: <CAL_JsqKb_afdZFaOoB5yvs2hX-T9HPVy_d30zu7f7yiqaRPaLg@mail.gmail.com> (raw)
In-Reply-To: <1551058604.12020.34.camel@mhfsdcap03>
On Sun, Feb 24, 2019 at 7:36 PM Min Guo <min.guo@mediatek.com> wrote:
>
> Hi Rob,
> On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote:
> > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote:
> > > From: Min Guo <min.guo@mediatek.com>
> > >
> > > This adds support for MediaTek musb controller in
> > > host, peripheral and otg mode.
> > >
> > > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > > ---
> > > changes in v5:
> > > suggested by Rob:
> > > 1. Modify compatible as
> > > - compatible : should be one of:
> > > "mediatek,mt-2701"
> > > ...
> > > followed by "mediatek,mtk-musb"
> > > 2. Add usb connector child node
> > >
> > > changes in v4:
> > > suggested by Sergei:
> > > 1. String alignment
> > >
> > > changes in v3:
> > > 1. no changes
> > >
> > > changes in v2:
> > > suggested by Bin:
> > > 1. Modify DRC to DRD
> > > suggested by Rob:
> > > 2. Drop the "<soc-model>-musb" in compatible
> > > 3. Remove phy-names
> > > 4. Add space after comma in clock-names
> > > ---
> > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++
> > > 1 file changed, 54 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > new file mode 100644
> > > index 0000000..0632e6e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > > @@ -0,0 +1,54 @@
> > > +MediaTek musb DRD/OTG controller
> > > +-------------------------------------------
> > > +
> > > +Required properties:
> > > + - compatible : should be one of:
> > > + "mediatek,mt-2701"
> >
> > That looks like a top-level SoC compatible and doesn't match the
> > example.
> "mediatek,mt-2701" is an example, just to describe a specific SOC.
> May I modify compatibel like:
> compatible : should be "mediatek,mtk-musb"
No, you should fix the example adding "mediatek,mtk-musb".
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-04 17:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 7:36 [PATCH v5 0/6] Add MediaTek MUSB Controller Driver min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,1/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 1/6] " min.guo
2019-02-22 16:49 ` Rob Herring
2019-02-22 16:49 ` Rob Herring
2019-02-22 16:49 ` [v5,1/6] " Rob Herring
2019-02-22 16:49 ` [PATCH v5 1/6] " Rob Herring
2019-02-23 3:04 ` Min Guo
2019-02-23 3:04 ` Min Guo
2019-02-25 1:36 ` Min Guo
2019-02-25 1:36 ` Min Guo
2019-02-25 1:36 ` [v5,1/6] " min.guo
2019-02-25 1:36 ` [PATCH v5 1/6] " Min Guo
2019-03-04 17:42 ` Rob Herring [this message]
2019-03-04 17:42 ` Rob Herring
2019-03-04 17:42 ` [v5,1/6] " Rob Herring
2019-03-04 17:42 ` [PATCH v5 1/6] " Rob Herring
2019-03-05 1:19 ` Min Guo
2019-03-05 1:19 ` Min Guo
2019-03-05 1:19 ` [v5,1/6] " min.guo
2019-03-05 1:19 ` [PATCH v5 1/6] " Min Guo
2019-02-19 7:36 ` [PATCH v5 2/6] arm: dts: mt2701: Add usb2 device nodes min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,2/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 2/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 3/6] usb: musb: Add get/set toggle hooks min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,3/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 3/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 4/6] usb: musb: Add noirq type of dma create interface min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,4/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 4/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 5/6] usb: musb: Add musb_clearb/w() interface min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,5/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 5/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 6/6] usb: musb: Add support for MediaTek musb controller min.guo
2019-02-19 7:36 ` min.guo
2019-02-19 7:36 ` [v5,6/6] " min.guo
2019-02-19 7:36 ` [PATCH v5 6/6] " min.guo
2019-03-30 8:52 ` Fabien Parent
2019-03-30 8:52 ` Fabien Parent
2019-03-30 8:52 ` [v5,6/6] " Fabien Parent
2019-04-01 5:35 ` [PATCH v5 6/6] " Min Guo
2019-04-01 5:35 ` Min Guo
2019-04-01 5:35 ` [v5,6/6] " min.guo
2019-04-01 5:35 ` [PATCH v5 6/6] " Min Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKb_afdZFaOoB5yvs2hX-T9HPVy_d30zu7f7yiqaRPaLg@mail.gmail.com \
--to=robh@kernel.org \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.