Re: [PATCH v9 2/3] dt-bindings: pwm: add IPQ6018 binding

From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Robert Marko" <robert.marko@sartura.hr>,
	linux-pwm@vger.kernel.org,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	devicetree@vger.kernel.org,
	"Kathiravan T" <kathirav@codeaurora.org>,
	linux-arm-msm@vger.kernel.org,
	"Balaji Prakash J" <bjagadee@codeaurora.org>
Subject: Re: [PATCH v9 2/3] dt-bindings: pwm: add IPQ6018 binding
Date: Wed, 1 Dec 2021 10:07:25 -0600	[thread overview]
Message-ID: <CAL_JsqKgRMiK9Uvh=EJDW7n_1Sz79NFQ7_K+RzqZ7nBAoQsJLg@mail.gmail.com> (raw)
In-Reply-To: <87ee6wgc0b.fsf@tarshish>

On Tue, Nov 30, 2021 at 10:55 PM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Hi Rob,
>
> On Tue, Nov 30 2021, Rob Herring wrote:
> > On Tue, 30 Nov 2021 19:37:29 +0200, Baruch Siach wrote:
> >> DT binding for the PWM block in Qualcomm IPQ6018 SoC.
> >>
> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >> ---
> >>
> >> v9:
> >>
> >>   Add 'ranges' property to example (Rob)
> >>
> >>   Drop label in example (Rob)
> >>
> >> v8:
> >>
> >>   Add size cell to 'reg' (Rob)
> >>
> >> v7:
> >>
> >>   Use 'reg' instead of 'offset' (Rob)
> >>
> >>   Drop 'clock-names' and 'assigned-clock*' (Bjorn)
> >>
> >>   Use single cell address/size in example node (Bjorn)
> >>
> >>   Move '#pwm-cells' lower in example node (Bjorn)
> >>
> >>   List 'reg' as required
> >>
> >> v6:
> >>
> >>   Device node is child of TCSR; remove phandle (Rob Herring)
> >>
> >>   Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
> >>
> >> v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn
> >>     Andersson, Kathiravan T)
> >>
> >> v4: Update the binding example node as well (Rob Herring's bot)
> >>
> >> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
> >>
> >> v2: Make #pwm-cells const (Rob Herring)
> >> ---
> >>  .../devicetree/bindings/pwm/ipq-pwm.yaml      | 53 +++++++++++++++++++
> >>  1 file changed, 53 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/pwm/ipq-pwm.example.dt.yaml:0:0:
> > /example-0/syscon@1937000: failed to match any schema with compatible:
> > ['qcom,tcsr-ipq6018', 'syscon', 'simple-mfd']
>
> My previous submission[1] had this text above the patch changelog:
>
> ---
> This series does not convert the TCSR binding documentation to YAML. As
> a result, this commit adds new a dt_binding_check warning:
>
> /example-0/syscon@1937000: failed to match any schema with compatible: ['qcom,tcsr-ipq 6018', 'syscon', 'simple-mfd']
>
> If that is a blocker to IPQ6018 PWM support, so be it. Patches will wait
> for someone else to push them further.

That one looks pretty trivial to convert and there are lots of people
working on QCom stuff, so I'm going to say yes it is required.

Rob