All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: "Petr Štetiar" <ynezz@true.cz>, netdev <netdev@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address
Date: Tue, 7 May 2019 10:57:36 -0500	[thread overview]
Message-ID: <CAL_JsqL66PdCv7bFwfD9p6VQCcXOesz3EjPcYB9FGosgjOS8yw@mail.gmail.com> (raw)
In-Reply-To: <20190505.214727.1839442238121977055.davem@davemloft.net>

On Sun, May 5, 2019 at 11:47 PM David Miller <davem@davemloft.net> wrote:
>
> From: Petr Štetiar <ynezz@true.cz>
> Date: Fri,  3 May 2019 16:27:05 +0200
>
> > this patch series is a continuation of my previous attempt[1], where I've
> > tried to wire MTD layer into of_get_mac_address, so it would be possible to
> > load MAC addresses from various NVMEMs as EEPROMs etc.
>  ...
>
> Series applied, thank you.

Patch 1 at least is still be discussed. What was implemented based on
my comments on v2 is really broken. Now the allocated buffer is
tracked by both devm and DT refcounting. Whoever's ref count drops
first will free the buffer.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	devicetree@vger.kernel.org,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	netdev <netdev@vger.kernel.org>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"Petr Štetiar" <ynezz@true.cz>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address
Date: Tue, 7 May 2019 10:57:36 -0500	[thread overview]
Message-ID: <CAL_JsqL66PdCv7bFwfD9p6VQCcXOesz3EjPcYB9FGosgjOS8yw@mail.gmail.com> (raw)
In-Reply-To: <20190505.214727.1839442238121977055.davem@davemloft.net>

On Sun, May 5, 2019 at 11:47 PM David Miller <davem@davemloft.net> wrote:
>
> From: Petr Štetiar <ynezz@true.cz>
> Date: Fri,  3 May 2019 16:27:05 +0200
>
> > this patch series is a continuation of my previous attempt[1], where I've
> > tried to wire MTD layer into of_get_mac_address, so it would be possible to
> > load MAC addresses from various NVMEMs as EEPROMs etc.
>  ...
>
> Series applied, thank you.

Patch 1 at least is still be discussed. What was implemented based on
my comments on v2 is really broken. Now the allocated buffer is
tracked by both devm and DT refcounting. Whoever's ref count drops
first will free the buffer.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-05-07 15:57 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 14:27 [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar
2019-05-03 14:27 ` Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 01/10] of_net: add " Petr Štetiar
2019-05-03 14:36   ` Maxime Ripard
2019-05-03 14:36     ` Maxime Ripard
2019-05-03 15:44     ` Petr Štetiar
2019-05-06 14:04       ` Maxime Ripard
2019-05-03 14:27 ` [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-07 16:44   ` Rob Herring
2019-05-07 16:44     ` Rob Herring
2019-05-07 16:44     ` Rob Herring
2019-05-08  8:41     ` Petr Štetiar
2019-05-08  8:41       ` Petr Štetiar
2019-05-08  8:41       ` Petr Štetiar
2019-05-08 11:48       ` Andrew Lunn
2019-05-08 11:48         ` Andrew Lunn
2019-05-08 11:48         ` Andrew Lunn
2019-05-03 14:27 ` [PATCH v4 03/10] net: macb: support of_get_mac_address new ERR_PTR error Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 04/10] net: davinci: " Petr Štetiar
     [not found] ` <1556893635-18549-1-git-send-email-ynezz-knWk7/PSn+s@public.gmane.org>
2019-05-03 14:27   ` [PATCH v4 05/10] net: ethernet: " Petr Štetiar
2019-05-03 14:27     ` Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 06/10] net: usb: " Petr Štetiar
2019-05-03 14:27   ` [v4,06/10] " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 07/10] net: wireless: " Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-06  7:59   ` Kalle Valo
2019-05-06  7:59     ` Kalle Valo
2019-05-03 14:27 ` [PATCH v4 08/10] staging: octeon-ethernet: " Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-03 15:32   ` [PATCH v5] " Petr Štetiar
2019-05-03 15:32     ` Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 09/10] ARM: Kirkwood: " Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 10/10] powerpc: tsi108: " Petr Štetiar
2019-05-03 14:27   ` Petr Štetiar
2019-05-06  4:47 ` [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address David Miller
2019-05-06  4:47   ` David Miller
2019-05-06  8:32   ` Petr Štetiar
2019-05-06  8:32     ` Petr Štetiar
2019-05-06 14:41     ` Maxime Chevallier
2019-05-06 14:41       ` Maxime Chevallier
2019-05-06 16:19       ` Petr Štetiar
2019-05-06 16:19         ` Petr Štetiar
2019-05-07 15:57   ` Rob Herring [this message]
2019-05-07 15:57     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqL66PdCv7bFwfD9p6VQCcXOesz3EjPcYB9FGosgjOS8yw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.