From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Andrew Murray <andrew.murray@arm.com>,
Marc Zyngier <maz@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Tariq Toukan <tariqt@mellanox.com>,
Frank Rowand <frowand.list@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
james.quinlan@broadcom.com, Matthias Brugger <mbrugger@suse.com>,
Phil Elwell <phil@raspberrypi.org>,
Jeremy Linton <jeremy.linton@arm.com>,
PCI <linux-pci@vger.kernel.org>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-acpi@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org, devicetree@vger.kernel.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations
Date: Tue, 3 Dec 2019 09:53:05 -0600 [thread overview]
Message-ID: <CAL_JsqLMCXdnZag3jihV_dzuR+wFaVKFb7q_PdKTxTg0LVA6cw@mail.gmail.com> (raw)
In-Reply-To: <20191203114743.1294-9-nsaenzjulienne@suse.de>
On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> The function now is safe to use while expecting a 64bit value. Use it
> where relevant.
What was wrong with the existing code? This is missing some context.
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++-
> drivers/of/device.c | 3 ++-
In any case,
Acked-by: Rob Herring <robh@kernel.org>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++-
> drivers/pci/controller/cadence/pcie-cadence.c | 3 ++-
> drivers/pci/controller/pcie-brcmstb.c | 3 ++-
> drivers/pci/controller/pcie-rockchip-ep.c | 5 +++--
> kernel/dma/direct.c | 2 +-
> 8 files changed, 15 insertions(+), 9 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Andrew Murray <andrew.murray@arm.com>,
Marc Zyngier <maz@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Tariq Toukan <tariqt@mellanox.com>,
Frank Rowand <frowand.list@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
james.quinlan@broadcom.com, Matthias
Subject: Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations
Date: Tue, 3 Dec 2019 09:53:05 -0600 [thread overview]
Message-ID: <CAL_JsqLMCXdnZag3jihV_dzuR+wFaVKFb7q_PdKTxTg0LVA6cw@mail.gmail.com> (raw)
In-Reply-To: <20191203114743.1294-9-nsaenzjulienne@suse.de>
On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> The function now is safe to use while expecting a 64bit value. Use it
> where relevant.
What was wrong with the existing code? This is missing some context.
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++-
> drivers/of/device.c | 3 ++-
In any case,
Acked-by: Rob Herring <robh@kernel.org>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++-
> drivers/pci/controller/cadence/pcie-cadence.c | 3 ++-
> drivers/pci/controller/pcie-brcmstb.c | 3 ++-
> drivers/pci/controller/pcie-rockchip-ep.c | 5 +++--
> kernel/dma/direct.c | 2 +-
> 8 files changed, 15 insertions(+), 9 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Heiko Stuebner <heiko@sntech.de>, PCI <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Eric Anholt <eric@anholt.net>, Hanjun Guo <guohanjun@huawei.com>,
Frank Rowand <frowand.list@gmail.com>,
Christoph Hellwig <hch@lst.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-rdma@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Phil Elwell <phil@raspberrypi.org>,
linux-acpi@vger.kernel.org,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Len Brown <lenb@kernel.org>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Matthias Brugger <mbrugger@suse.com>,
netdev <netdev@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Stefan Wahren <wahrenst@gmx.net>,
james.quinlan@broadcom.com, Sudeep Holla <sudeep.holla@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations
Date: Tue, 3 Dec 2019 09:53:05 -0600 [thread overview]
Message-ID: <CAL_JsqLMCXdnZag3jihV_dzuR+wFaVKFb7q_PdKTxTg0LVA6cw@mail.gmail.com> (raw)
In-Reply-To: <20191203114743.1294-9-nsaenzjulienne@suse.de>
On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> The function now is safe to use while expecting a 64bit value. Use it
> where relevant.
What was wrong with the existing code? This is missing some context.
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++-
> drivers/of/device.c | 3 ++-
In any case,
Acked-by: Rob Herring <robh@kernel.org>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++-
> drivers/pci/controller/cadence/pcie-cadence.c | 3 ++-
> drivers/pci/controller/pcie-brcmstb.c | 3 ++-
> drivers/pci/controller/pcie-rockchip-ep.c | 5 +++--
> kernel/dma/direct.c | 2 +-
> 8 files changed, 15 insertions(+), 9 deletions(-)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Heiko Stuebner <heiko@sntech.de>, PCI <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Eric Anholt <eric@anholt.net>, Hanjun Guo <guohanjun@huawei.com>,
Frank Rowand <frowand.list@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-rdma@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Phil Elwell <phil@raspberrypi.org>,
linux-acpi@vger.kernel.org,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Len Brown <lenb@kernel.org>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Matthias Brugger <mbrugger@suse.com>,
netdev <netdev@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Stefan Wahren <wahrenst@gmx.net>,
james.quinlan@broadcom.com, Sudeep Holla <sudeep.holla@arm.com>,
Andrew Murray <andrew.murray@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations
Date: Tue, 3 Dec 2019 09:53:05 -0600 [thread overview]
Message-ID: <CAL_JsqLMCXdnZag3jihV_dzuR+wFaVKFb7q_PdKTxTg0LVA6cw@mail.gmail.com> (raw)
In-Reply-To: <20191203114743.1294-9-nsaenzjulienne@suse.de>
On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> The function now is safe to use while expecting a 64bit value. Use it
> where relevant.
What was wrong with the existing code? This is missing some context.
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++-
> drivers/of/device.c | 3 ++-
In any case,
Acked-by: Rob Herring <robh@kernel.org>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++-
> drivers/pci/controller/cadence/pcie-cadence.c | 3 ++-
> drivers/pci/controller/pcie-brcmstb.c | 3 ++-
> drivers/pci/controller/pcie-rockchip-ep.c | 5 +++--
> kernel/dma/direct.c | 2 +-
> 8 files changed, 15 insertions(+), 9 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-03 15:53 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 11:47 [PATCH v4 0/8] Raspberry Pi 4 PCIe support Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 1/8] dt-bindings: PCI: Add bindings for brcmstb's PCIe device Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 15:03 ` Andrew Murray
2019-12-03 15:03 ` Andrew Murray
2019-12-03 11:47 ` [PATCH v4 2/8] ARM: dts: bcm2711: Enable PCIe controller Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-16 6:46 ` Jian-Hong Pan
2019-12-16 6:46 ` Jian-Hong Pan
2019-12-16 9:49 ` Nicolas Saenz Julienne
2019-12-16 9:49 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 3/8] PCI: brcmstb: Add Broadcom STB PCIe host controller driver Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 4/8] PCI: brcmstb: Add MSI support Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 5/8] MAINTAINERS: Add brcmstb PCIe controller Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 6/8] arm64: defconfig: Enable Broadcom's STB " Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 7/8] linux/log2.h: Fix 64bit calculations in roundup/down_pow_two() Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 16:39 ` Chuck Lever
2019-12-03 16:39 ` Chuck Lever
2019-12-03 16:39 ` Chuck Lever
2019-12-03 16:39 ` Chuck Lever
2019-12-04 10:56 ` Martin Habets
2019-12-04 10:56 ` Martin Habets
2019-12-04 10:56 ` Martin Habets
2019-12-04 10:56 ` Martin Habets
2019-12-04 14:17 ` Leon Romanovsky
2019-12-04 14:17 ` Leon Romanovsky
2019-12-04 14:17 ` Leon Romanovsky
2019-12-05 0:39 ` Lu Baolu
2019-12-05 0:39 ` Lu Baolu
2019-12-05 0:39 ` Lu Baolu
2019-12-05 17:48 ` Robin Murphy
2019-12-05 17:48 ` Robin Murphy
2019-12-05 17:48 ` Robin Murphy
2019-12-12 12:31 ` Nicolas Saenz Julienne
2019-12-12 12:31 ` Nicolas Saenz Julienne
2019-12-12 12:31 ` Nicolas Saenz Julienne
2019-12-05 22:30 ` Bjorn Helgaas
2019-12-05 22:30 ` Bjorn Helgaas
2019-12-05 22:30 ` Bjorn Helgaas
2019-12-05 22:30 ` Bjorn Helgaas
2019-12-12 13:16 ` Nicolas Saenz Julienne
2019-12-12 13:16 ` Nicolas Saenz Julienne
2019-12-12 13:16 ` Nicolas Saenz Julienne
2019-12-12 13:16 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 11:47 ` Nicolas Saenz Julienne
2019-12-03 15:53 ` Rob Herring [this message]
2019-12-03 15:53 ` Rob Herring
2019-12-03 15:53 ` Rob Herring
2019-12-03 15:53 ` Rob Herring
2019-12-03 16:06 ` Nicolas Saenz Julienne
2019-12-03 16:06 ` Nicolas Saenz Julienne
2019-12-03 16:06 ` Nicolas Saenz Julienne
2019-12-03 16:06 ` Nicolas Saenz Julienne
2019-12-05 20:38 ` Bjorn Helgaas
2019-12-05 20:38 ` Bjorn Helgaas
2019-12-05 20:38 ` Bjorn Helgaas
2019-12-05 20:38 ` Bjorn Helgaas
2019-12-12 13:21 ` Nicolas Saenz Julienne
2019-12-12 13:21 ` Nicolas Saenz Julienne
2019-12-12 13:21 ` Nicolas Saenz Julienne
2019-12-12 13:21 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLMCXdnZag3jihV_dzuR+wFaVKFb7q_PdKTxTg0LVA6cw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=andrew.murray@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=guohanjun@huawei.com \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=james.quinlan@broadcom.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=mbrugger@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=sudeep.holla@arm.com \
--cc=tariqt@mellanox.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.