Re: [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog

From: Rob Herring <robh@kernel.org>
To: Xingyu Chen <xingyu.chen@amlogic.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Kevin Hilman <khilman@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Qianggui Song <qianggui.song@amlogic.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Jian Hu <jian.hu@amlogic.com>,
	LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
Date: Tue, 29 Oct 2019 15:51:47 -0500	[thread overview]
Message-ID: <CAL_JsqLr-Cgu4yZFGTfO=qpFPLBZ1gb-1+DZ35eQX3dUsadm4g@mail.gmail.com> (raw)
In-Reply-To: <1914e315-3cb7-9251-f871-0024e0e4f68b@amlogic.com>

On Mon, Oct 28, 2019 at 3:35 AM Xingyu Chen <xingyu.chen@amlogic.com> wrote:
>
> Hi, Rob
>
> On 2019/10/26 4:30, Rob Herring wrote:
> > On Fri, Oct 25, 2019 at 02:13:02PM +0800, Xingyu Chen wrote:
> >> The binding targets the Meson-A/C series compatible SoCs, in which the
> >> watchdog registers are in secure world.
> >>
> >> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> >> ---
> >>   .../bindings/watchdog/amlogic,meson-sec-wdt.yaml   | 34 ++++++++++++++++++++++
> >>   1 file changed, 34 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
> >> new file mode 100644
> >> index 00000000..0bbc807
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
> >> @@ -0,0 +1,34 @@
> >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >> +# Copyright (c) 2019 Amlogic, Inc
> >> +%YAML 1.2
> >> +---
> >> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#"
> >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> >> +
> >> +title: Amlogic Meson Secure Watchdog Timer
> >> +
> >> +maintainers:
> >> +  - Xingyu Chen <xingyu.chen@amlogic.com>
> >> +
> >> +description: |+
> >> +  Secure Watchdog Timer used in Meson-A/C series Compatible SoCs
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - amlogic,meson-sec-wdt
> >
> > If there are no other properties, then you don't need this. Just have
> > the secure firmware driver instantiate the watchdog.
> I'am very sorry i don't understand how to initialize the watchdog driver
> if the compatible property is removed, Could you give me more
> suggestions or examples ？ Thank you very much.

platform_device_register_simple() from the secure firmware driver.

Rob