From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: send (re)assoc peer command when NSS changed
Date: Thu, 18 Dec 2014 06:28:22 +0100 [thread overview]
Message-ID: <CALhHN=rvAPMPOWyOM207sAiS+YQ2fWKEM0BO6d1KM7a+F6e3zQ@mail.gmail.com> (raw)
In-Reply-To: <87a92mr2gi.fsf@kamboji.qca.qualcomm.com>
On 17 December 2014 at 11:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Assoc peer command contain information about NSS.
>> When we will get IEEE80211_RC_NSS_CHANGED we should
>> also send (re) assoc peer command to be sure firmware
>> will know about it and RC will work correctly.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> Does this fix a user visible bug or is this something you just found
> from doing code review?
>
In case we will get only IEEE80211_RC_NSS_CHANGED we will not update
FW configuration correctly. This is not the problem when IBSS, while
we update two flags in one step IEEE80211_RC_SUPP_RATES_CHANGED |
IEEE80211_RC_NSS_CHANGED.
We could have problems when mac80211 will send only NSS_CHANGED flag.
This seems could happen when we will get WLAN_EID_OPMODE_NOTIF. I
didn't test such case, but I believe some AP could send such
notification. So, this fix potential TP issue.
BR
Janusz
WARNING: multiple messages have this Message-ID (diff)
From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: send (re)assoc peer command when NSS changed
Date: Thu, 18 Dec 2014 06:28:22 +0100 [thread overview]
Message-ID: <CALhHN=rvAPMPOWyOM207sAiS+YQ2fWKEM0BO6d1KM7a+F6e3zQ@mail.gmail.com> (raw)
In-Reply-To: <87a92mr2gi.fsf@kamboji.qca.qualcomm.com>
On 17 December 2014 at 11:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>
>> Assoc peer command contain information about NSS.
>> When we will get IEEE80211_RC_NSS_CHANGED we should
>> also send (re) assoc peer command to be sure firmware
>> will know about it and RC will work correctly.
>>
>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>
> Does this fix a user visible bug or is this something you just found
> from doing code review?
>
In case we will get only IEEE80211_RC_NSS_CHANGED we will not update
FW configuration correctly. This is not the problem when IBSS, while
we update two flags in one step IEEE80211_RC_SUPP_RATES_CHANGED |
IEEE80211_RC_NSS_CHANGED.
We could have problems when mac80211 will send only NSS_CHANGED flag.
This seems could happen when we will get WLAN_EID_OPMODE_NOTIF. I
didn't test such case, but I believe some AP could send such
notification. So, this fix potential TP issue.
BR
Janusz
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-12-18 5:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 8:52 [PATCH 1/2] ath10k: fix low TX rates when IBSS and HT Janusz Dziedzic
2014-12-16 8:52 ` Janusz Dziedzic
2014-12-16 8:53 ` [PATCH 2/2] ath10k: send (re)assoc peer command when NSS changed Janusz Dziedzic
2014-12-16 8:53 ` Janusz Dziedzic
2014-12-17 10:32 ` Kalle Valo
2014-12-17 10:32 ` Kalle Valo
2014-12-18 5:28 ` Janusz Dziedzic [this message]
2014-12-18 5:28 ` Janusz Dziedzic
2014-12-18 6:02 ` Kalle Valo
2014-12-18 6:02 ` Kalle Valo
2014-12-16 11:10 ` [PATCH 1/2] ath10k: fix low TX rates when IBSS and HT Yeoh Chun-Yeow
2014-12-16 11:10 ` Yeoh Chun-Yeow
2014-12-16 11:22 ` Janusz Dziedzic
2014-12-16 11:22 ` Janusz Dziedzic
2014-12-16 11:45 ` Janusz Dziedzic
2014-12-16 11:45 ` Janusz Dziedzic
2014-12-16 13:32 ` Yeoh Chun-Yeow
2014-12-16 13:32 ` Yeoh Chun-Yeow
2014-12-17 3:56 ` Yeoh Chun-Yeow
2014-12-17 3:56 ` Yeoh Chun-Yeow
2014-12-16 13:32 ` Yeoh Chun-Yeow
2014-12-16 13:32 ` Yeoh Chun-Yeow
2014-12-23 15:23 ` Kalle Valo
2014-12-23 15:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALhHN=rvAPMPOWyOM207sAiS+YQ2fWKEM0BO6d1KM7a+F6e3zQ@mail.gmail.com' \
--to=janusz.dziedzic@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.